File path: /columba-1.4-src/core/src/main/java/org/columba/core/plugin/ExtensionHandler.java | File path: /columba-1.4-src/plugins/org.columba.chat.altura/src/org/columba/chat/model/BuddyList.java | |||
Method name: IExtension getExtension(String)
|
Method name: BuddyStatus getBuddy(String)
|
|||
Number of AST nodes: 5 | Number of AST nodes: 5 | |||
1 | if (id == null)↵ | 1 | if (jabberId == null)↵ | |
2 | throw new IllegalArgumentException("id == null");↵ | 2 | throw new IllegalArgumentException("jabberId == null");↵ | |
3 | if (map.containsKey(id))↵ | 3 | if (map.containsKey(jabberId))↵ | |
4 | return (IExtension) map.get(id);↵ | 4 | return (BuddyStatus) map.get(jabberId);↵ | |
5 | return null; | 5 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2 |
Clones location | Clones are in different classes |
Number of node comparisons | 11 |
Number of mapped statements | 4 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 1.4 |
Clone type | Type 2 |
ID | Statement | ID | Statement | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | if (id == null) |
| 1 | if (jabberId == null) | |||||||||||||
2 | throw new IllegalArgumentException("id == null"); |
| 2 | throw new IllegalArgumentException("jabberId == null"); | |||||||||||||
3 | if (map.containsKey(id)) |
| 3 | if (map.containsKey(jabberId)) | |||||||||||||
|
| 4 | return (BuddyStatus)map.get(jabberId); | ||||||||||||||
4 | return (IExtension)map.get(id); |
| | ||||||||||||||
5 | return null; | 5 | return null; |
Row | Violation |
---|---|
1 | Unmatched statement return (BuddyStatus)map.get(jabberId); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
2 | Unmatched return (BuddyStatus)map.get(jabberId); |
3 | Unmatched statement return (IExtension)map.get(id); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
4 | Unmatched return (IExtension)map.get(id); |