File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/facade/ContactFacade.java | File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/facade/ContactFacade.java | |||
Method name: List
|
Method name: List
|
|||
Number of AST nodes: 5 | Number of AST nodes: 5 | |||
1 | Iterator<IContactModelPartial> it = map.values()↵ | 1 | Iterator<IContactModelPartial> it = folder.getHeaderItemList()↵ | |
2 | .iterator();↵ | 2 | .iterator();↵ | |
3 | while (it.hasNext()) {↵ | 3 | while (it.hasNext()) {↵ | |
4 | IContactModelPartial partial = it.next();↵ | 4 | IContactModelPartial contactModel = it.next();↵ | |
5 | IContactItem item = createContactItem(partial);↵ | 5 | IContactItem item = createContactItem(contactModel);↵ | |
6 | groupItem.addContact(item);↵ | 6 | v.add(item);↵ | |
7 | } | 7 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.5 |
Clones location | Clones are declared in the same class |
Number of node comparisons | 19 |
Number of mapped statements | 3 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 28.7 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
| 12 | Iterator<IContactModelPartial> it = folder.getHeaderItemList().iterator(); | |||||||||||
19 | Iterator<IContactModelPartial> it = map.values().iterator(); |
| | |||||||||||
20 | while (it.hasNext()) | 13 | while (it.hasNext()) | |||||||||||
21 | IContactModelPartial partial = it.next(); |
| 14 | IContactModelPartial contactModel = it.next(); | ||||||||||
22 | IContactItem item = createContactItem(partial); |
| 15 | IContactItem item = createContactItem(contactModel); | ||||||||||
|
| 16 | v.add(item); | |||||||||||
23 | groupItem.addContact(item); |
| |
Row | Violation |
---|---|
1 | Unmatched statement Iterator<IContactModelPartial> it=folder.getHeaderItemList().iterator(); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
2 | Unmatched statement Iterator<IContactModelPartial> it=map.values().iterator(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
3 | Unmatched statement v.add(item); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
4 | Unmatched statement groupItem.addContact(item); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
5 | Unmatched statement groupItem.addContact(item); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |