File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/gui/config/account/AccountDialog.java | File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/gui/config/account/AccountDialog.java | |||
Method name: boolean isFinished()
|
Method name: boolean isFinished()
|
|||
Number of AST nodes: 7 | Number of AST nodes: 8 | |||
1 | result = incomingServerPanel.isFinished();↵ | |||
1 | if (!result) {↵ | 2 | if (!result) {↵ | |
2 | tp.setSelectedComponent(identityPanel);↵ | 3 | tp.setSelectedComponent(incomingServerPanel);↵ | |
3 | return false;↵ | 4 | return false;↵ | |
4 | }↵ | 5 | }↵ | |
5 | result = incomingServerPanel.isFinished();↵ | 6 | result = outgoingServerPanel.isFinished();↵ | |
6 | if (!result) {↵ | 7 | if (!result) {↵ | |
7 | tp.setSelectedComponent(incomingServerPanel);↵ | 8 | tp.setSelectedComponent(outgoingServerPanel);↵ | |
8 | return false;↵ | 9 | return false;↵ | |
9 | } | 10 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.1 |
Clones location | Clones are in the same method |
Number of node comparisons | 30 |
Number of mapped statements | 7 |
Number of unmapped statements in the first code fragment | 0 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 0.9 |
Clone type | Type 3 |
ID | Statement | ID | Statement | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
2 | if (!result) | 6 | if (!result) | ||||||||||||||
3 | tp.setSelectedComponent(identityPanel); |
| 7 | tp.setSelectedComponent(incomingServerPanel); | |||||||||||||
4 | return false; |
| 8 | return false; | |||||||||||||
5 | result = incomingServerPanel.isFinished(); | 5 | result = incomingServerPanel.isFinished(); | ||||||||||||||
|
| 9 | result = outgoingServerPanel.isFinished(); | ||||||||||||||
6 | if (!result) | 10 | if (!result) | ||||||||||||||
7 | tp.setSelectedComponent(incomingServerPanel); |
| 11 | tp.setSelectedComponent(outgoingServerPanel); | |||||||||||||
8 | return false; |
| 12 | return false; |
Row | Violation |
---|---|
1 | Unmatched statement result=outgoingServerPanel.isFinished(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Conditional return false; |
3 | Conditional return false; |
4 | Conditional return false; |
5 | Conditional return false; |