it = contactModel.getInstantMessagingIterator(); while (it.hasNext()) { InstantMessagingModel m = ((InstantMessagingModel) it.next()); parser.addInstantMessaging(m); } // <phone> // <business>value</business> // <home>value</home> // </phone> it = contactModel.getPhoneIterator();
while (it.hasNext()) { IEmailModel m = ((IEmailModel) it.next()); parser.addEmail(m); } // <im> // <aol>value</aol> // <yahoo>value</yahoo> // <jabber>value</jabber> // </im> it = contactModel.getInstantMessagingIterator();
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/model/ContactModelXMLFactory.java File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/model/ContactModelXMLFactory.java
Method name: Document marshall(IContactModel) Method name: Document marshall(IContactModel)
Number of AST nodes: 5 Number of AST nodes: 4
1
it = contactModel.getInstantMessagingIterator();
2
		while (it.hasNext()) {
1
while (it.hasNext()) {
3
			InstantMessagingModel m = ((InstantMessagingModel) it.next());
2
			IEmailModel m = ((IEmailModel) it.next());
4
			parser.addInstantMessaging(m);
3
			parser.addEmail(m);
5
		}
4
		}
6
		// <phone>
5
		// <im>
7
		// <business>value</business>
6
		// <aol>value</aol>
8
		// <home>value</home>
7
		// <yahoo>value</yahoo>
9
		// </phone
8
		// <jabber>value</jabber>
10
>
9
		// </im>
11
		it = contactModel.getPhoneIterator();
10
		it = contactModel.getInstantMessagingIterator();
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in the same method
Number of node comparisons13
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements3
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment1
    Time elapsed for statement mapping (ms)13.4
    Clone typeType 3
    Mapped Statements
    ID Statement ID Statement
    44
    it = contactModel.getInstantMessagingIterator();
    44
    it = contactModel.getInstantMessagingIterator();
    45
    while (it.hasNext())
    41
    while (it.hasNext())
                                                                                          
    42
    IEmailModel m = ((IEmailModel)it.next());
    Preondition Violations
    Unmatched statement IEmailModel m=((IEmailModel)it.next()); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    42
    IEmailModel m = ((IEmailModel)it.next());
    46
    InstantMessagingModel m = ((InstantMessagingModel)it.next());
    46
    InstantMessagingModel m = ((InstantMessagingModel)it.next());
    Preondition Violations
    Unmatched statement InstantMessagingModel m=((InstantMessagingModel)it.next()); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
                                                                                                                                  
    47
    parser.addInstantMessaging(m);
    47
    parser.addInstantMessaging(m);
    43
    parser.addEmail(m);
    Differences
    Expression1Expression2Difference
    addInstantMessagingaddEmailMETHOD_INVOCATION_NAME_MISMATCH
    org.columba.addressbook.model.InstantMessagingModelorg.columba.addressbook.model.IEmailModelVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Expression parser.addInstantMessaging(m) is a void method call, and thus it cannot be parameterized
    Expression parser.addEmail(m) is a void method call, and thus it cannot be parameterized
    Type org.columba.addressbook.model.InstantMessagingModel of variable m does not match with type org.columba.addressbook.model.IEmailModel of variable m
    • Make classes org.columba.addressbook.model.InstantMessagingModel and org.columba.addressbook.model.IEmailModel extend a common superclass
    43
    parser.addEmail(m);
    48
    it = contactModel.getPhoneIterator();
                                                                                  
    Precondition Violations (5)
    Row Violation
    1Unmatched statement IEmailModel m=((IEmailModel)it.next()); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    2Unmatched statement InstantMessagingModel m=((InstantMessagingModel)it.next()); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    3Expression parser.addInstantMessaging(m) is a void method call, and thus it cannot be parameterized
    4Expression parser.addEmail(m) is a void method call, and thus it cannot be parameterized
    5Type org.columba.addressbook.model.InstantMessagingModel of variable m does not match with type org.columba.addressbook.model.IEmailModel of variable m