File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/filter/plugins/DateFilter.java | File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/filter/plugins/PriorityFilter.java | |||
Method name: boolean process(IFolder, Object)
|
Method name: boolean process(IFolder, Object)
|
|||
Number of AST nodes: 18 | Number of AST nodes: 16 | |||
1 | Date date↵ | 1 | boolean result = false;↵ | |
2 | = transformDate(pattern);↵ | 2 | String s = (String) searchPattern;↵ | |
3 | if (date == null)↵ | 3 | ↵ | |
4 | return false;↵ | |||
5 | boolean result = false;↵ | 4 | Integer searchPatternInt = transformPriority(s);↵ | |
6 | // get date↵ | 5 | ↵ | |
7 | Date d = (Date) ((IMailbox)folder).getAttribute(uid, ↵ | 6 | Integer priority = (Integer) ((IMailbox)folder).getAttribute(uid,↵ | |
8 | "columba.date");↵ | 7 | "columba.priority");↵ | |
9 | if (d == null) {↵ | 8 | if (priority == null) {↵ | |
10 | LOG.fine("field date not found");↵ | |||
11 | return false;↵ | 9 | return false;↵ | |
12 | }↵ | 10 | }↵ | |
13 | switch (condition) {↵ | 11 | switch (condition) {↵ | |
14 | case FilterCriteria.DATE_BEFORE:↵ | 12 | case FilterCriteria.↵ | |
15 | if (d.before(date)↵ | 13 | IS:↵ | |
16 | ) {↵ | 14 | if (priority.compareTo(searchPatternInt) == 0) {↵ | |
17 | result = true;↵ | 15 | result = true;↵ | |
18 | }↵ | 16 | }↵ | |
19 | break;↵ | 17 | break;↵ | |
20 | case FilterCriteria.DATE_AFTER:↵ | 18 | case FilterCriteria.↵ | |
21 | if (d.after(date)↵ | 19 | IS_NOT:↵ | |
22 | ) {↵ | 20 | if (priority.compareTo(searchPatternInt) != 0) {↵ | |
23 | result = true;↵ | 21 | result = true;↵ | |
24 | }↵ | 22 | }↵ | |
25 | break;↵ | 23 | break;↵ | |
26 | }↵ | 24 | }↵ | |
27 | return result; | 25 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.1 |
Clones location | Clones are in different classes having the same super class |
Number of node comparisons | 30 |
Number of mapped statements | 4 |
Number of unmapped statements in the first code fragment | 14 |
Number of unmapped statements in the second code fragment | 12 |
Time elapsed for statement mapping (ms) | 4.6 |
Clone type | Type 3 |
ID | Statement | ID | Statement | |||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | Date date = transformDate(pattern); | | ||||||||||||||||
2 | if (date == null) |
| 5 | if (priority == null) | ||||||||||||||
3 | return false; | 6 | return false; | |||||||||||||||
4 | boolean result = false; | 1 | boolean result = false; | |||||||||||||||
| 2 | String s = (String)searchPattern; | ||||||||||||||||
| 3 | Integer searchPatternInt = transformPriority(s); | ||||||||||||||||
| 4 | Integer priority = (Integer)((IMailbox)folder).getAttribute(uid, "columba.priority"); | ||||||||||||||||
5 | Date d = (Date)((IMailbox)folder).getAttribute(uid, "columba.date"); | | ||||||||||||||||
6 | if (d == null) | | ||||||||||||||||
7 | LOG.fine("field date not found"); | | ||||||||||||||||
8 | return false; |
| | |||||||||||||||
| 7 | switch (condition) | ||||||||||||||||
| 8 | case FilterCriteria.IS: | ||||||||||||||||
| 9 | if (priority.compareTo(searchPatternInt) == 0) | ||||||||||||||||
|
| 10 | result = true; | |||||||||||||||
|
| 11 | break; | |||||||||||||||
| 12 | case FilterCriteria.IS_NOT: | ||||||||||||||||
| 13 | if (priority.compareTo(searchPatternInt) != 0) | ||||||||||||||||
|
| 14 | result = true; | |||||||||||||||
|
| 15 | break; | |||||||||||||||
9 | switch (condition) | | ||||||||||||||||
10 | case FilterCriteria.DATE_BEFORE: | | ||||||||||||||||
11 | if (d.before(date)) | | ||||||||||||||||
12 | result = true; |
| | |||||||||||||||
13 | break; |
| | |||||||||||||||
14 | case FilterCriteria.DATE_AFTER: | | ||||||||||||||||
15 | if (d.after(date)) | | ||||||||||||||||
16 | result = true; |
| | |||||||||||||||
17 | break; |
| | |||||||||||||||
18 | return result; | 16 | return result; |
Row | Violation |
---|---|
1 | Type java.util.Date of variable date does not match with type java.lang.Integer of variable priority |
2 | Unmatched return false; |
3 | Unmatched statement result=true; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
4 | Unmatched break; |
5 | Unmatched statement result=true; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
6 | Unmatched break; |
7 | Unmatched statement result=true; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
8 | Unmatched break; |
9 | Unmatched statement result=true; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
10 | Unmatched break; |
11 | Not all possible execution flows end in a return statement |