for (int i = 0; i < members.count(); i++) { XmlElement m = members.getElement(i); Integer str = new Integer(m.getAttribute("uid")); if ( str.equals(uid) ) return m; }
for (int i = 0; i < custom.count(); i++) { XmlElement child = custom.getElement(i); String name = child.getAttribute("id"); if (name.equals(id)) return new ViewItem(child); }
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/model/GroupModel.java File path: /columba-1.4-src/core/src/main/java/org/columba/core/gui/frame/FrameManager.java
Method name: XmlElement getMember(Object) Method name: ViewItem createCustomViewItem(String)
Number of AST nodes: 5 Number of AST nodes: 5
1
for (int i = 0; i < members.count(); i++) {
1
for (int i = 0; i < custom.count(); i++) {
2
			XmlElement m = members.getElement(i);
2
			XmlElement child = custom.getElement(i);
3
			Integer str = new Integer(m.getAttribute("uid"));
3
			String name = child.getAttribute("id");
4
			if ( str.equals(uid) )
4
			if (name.equals(id))
5
				return m;
5
				return new ViewItem(child);
6
		}
6
		}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.3
Clones locationClones are in different classes
Number of node comparisons13
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements3
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)2.1
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    2
    for (int i = 0; i < members.count(); i++)
    2
    for (int i = 0; i < members.count(); i++)
    5
    for (int i = 0; i < custom.count(); i++)
    Differences
    Expression1Expression2Difference
    memberscustomVARIABLE_NAME_MISMATCH
    5
    for (int i = 0; i < custom.count(); i++)
    3
    XmlElement m = members.getElement(i);
    3
    XmlElement m = members.getElement(i);
    6
    XmlElement child = custom.getElement(i);
    Differences
    Expression1Expression2Difference
    mchildVARIABLE_NAME_MISMATCH
    memberscustomVARIABLE_NAME_MISMATCH
    6
    XmlElement child = custom.getElement(i);
    4
    Integer str = new Integer(m.getAttribute("uid"));
    4
    Integer str = new Integer(m.getAttribute("uid"));
    Preondition Violations
    Unmatched statement Integer str=new Integer(m.getAttribute("uid")); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    Unmatched statement Integer str=new Integer(m.getAttribute("uid")); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
                                                                                                        
                                                                                    
    7
    String name = child.getAttribute("id");
    Preondition Violations
    Unmatched statement String name=child.getAttribute("id"); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    Unmatched statement String name=child.getAttribute("id"); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    7
    String name = child.getAttribute("id");
    5
    if (str.equals(uid))
    5
    if (str.equals(uid))
    8
    if (name.equals(id))
    Differences
    Expression1Expression2Difference
    uididVARIABLE_NAME_MISMATCH
    java.lang.Objectjava.lang.StringVARIABLE_TYPE_MISMATCH
    strnameVARIABLE_NAME_MISMATCH
    java.lang.Integerjava.lang.StringVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type java.lang.Object of variable uid does not match with type java.lang.String of variable id
    • Make classes java.lang.Object and java.lang.String extend a common superclass
    Type java.lang.Integer of variable str does not match with type java.lang.String of variable name
    • Make classes java.lang.Integer and java.lang.String extend a common superclass
    8
    if (name.equals(id))
    6
    return m;
    6
    return m;
    Preondition Violations
    Unmatched statement return m; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    Unmatched return m;
                            
                                                                
    9
    return new ViewItem(child);
    Preondition Violations
    Unmatched statement return new ViewItem(child); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    Unmatched return new ViewItem(child);
    9
    return new ViewItem(child);
    Precondition Violations (11)
    Row Violation
    1Unmatched statement Integer str=new Integer(m.getAttribute("uid")); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    2Unmatched statement Integer str=new Integer(m.getAttribute("uid")); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    3Unmatched statement String name=child.getAttribute("id"); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    4Unmatched statement String name=child.getAttribute("id"); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    5Type java.lang.Object of variable uid does not match with type java.lang.String of variable id
    6Type java.lang.Integer of variable str does not match with type java.lang.String of variable name
    7Unmatched statement return m; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    8Unmatched return m;
    9Unmatched statement return new ViewItem(child); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    10Unmatched return new ViewItem(child);
    11The refactoring of the clones is infeasible, because classes org.columba.addressbook.model.GroupModel and org.columba.core.gui.frame.FrameManager do not have a common superclass