File path: /columba-1.4-src/calendar/src/main/java/org/columba/calendar/search/ComplexResultPanel.java | File path: /columba-1.4-src/core/src/main/java/org/columba/core/gui/search/GenericResultPanel.java | |||
Method name: void resultArrived(IResultEvent)
|
Method name: void resultArrived(IResultEvent)
|
|||
Number of AST nodes: 7 | Number of AST nodes: 7 | |||
1 | if (!event.getProviderName().equals(this.providerTechnicalName))↵ | 1 | if (!event.getProviderName().equals(this.providerName))↵ | |
2 | return;↵ | 2 | return;↵ | |
3 | List<ISearchResult> result = event.getSearchResults();↵ | 3 | List<ISearchResult> result = event.getSearchResults();↵ | |
4 | Iterator<ISearchResult> it = result.iterator();↵ | 4 | Iterator<ISearchResult> it = result.iterator();↵ | |
5 | while (it.hasNext()) {↵ | 5 | while (it.hasNext()) {↵ | |
6 | list.add(it.next());↵ | 6 | listModel.addElement(it.next());↵ | |
7 | }↵ | 7 | }↵ | |
8 | list.↵ | 8 | // setPreferredSize(list.getPreferredSize());↵ | |
9 | revalidate(); | 9 | revalidate(); | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.7 |
Clones location | Clones are in different classes |
Number of node comparisons | 19 |
Number of mapped statements | 6 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 15.3 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | if (!event.getProviderName().equals(this.providerTechnicalName)) |
| 1 | if (!event.getProviderName().equals(this.providerName)) | ||||||||||||||
2 | return; | 2 | return; | |||||||||||||||
3 | List<ISearchResult> result = event.getSearchResults(); | 3 | List<ISearchResult> result = event.getSearchResults(); | |||||||||||||||
4 | Iterator<ISearchResult> it = result.iterator(); | 4 | Iterator<ISearchResult> it = result.iterator(); | |||||||||||||||
5 | while (it.hasNext()) | 5 | while (it.hasNext()) | |||||||||||||||
|
| 6 | listModel.addElement(it.next()); | |||||||||||||||
6 | list.add(it.next()); |
| | |||||||||||||||
7 | list.revalidate(); |
| 7 | revalidate(); |
Row | Violation |
---|---|
1 | Unmatched statement listModel.addElement(it.next()); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Unmatched statement list.add(it.next()); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
3 | Expression list.revalidate() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
4 | Expression revalidate() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
5 | Expression list.revalidate() is a void method call, and thus it cannot be parameterized |
6 | Expression revalidate() is a void method call, and thus it cannot be parameterized |
7 | The refactoring of the clones is infeasible, because classes org.columba.calendar.search.ComplexResultPanel and org.columba.core.gui.search.GenericResultPanel do not have a common superclass |