if (defaultViews == null) { XmlElement gui = Config.getInstance().get("views").getElement( "/views"); defaultViews = new XmlElement("defaultviews"); gui.addElement(defaultViews); } // search through defaultViews to get settings for given id ViewItem view = null; for (int i = 0; i < defaultViews.count(); i++) { XmlElement child = defaultViews.getElement(i); String childId = child.getAttribute("id"); if ((childId != null) && childId.equals(id)) { view = new ViewItem(child); break; } } return view;
IFolderItem item = parent.getConfiguration(); XmlElement property = item.getElement("property"); if (property != null) { String expanded = property.getAttribute("expanded"); if (expanded == null) { expanded = "true"; } // expand folder int row = getRowForPath(new TreePath(parent.getPath())); if (expanded.equals("true")) { expandRow(row); } } // recursivly expand all children for (int i = 0; i < parent.getChildCount(); i++) { IMailFolder child = (IMailFolder) parent.getChildAt(i); expand(child); }
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/core/src/main/java/org/columba/core/gui/frame/FrameManager.java File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/gui/tree/TreeView.java
Method name: ViewItem loadDefaultView(String) Method name: void expand(IMailFolder)
Number of AST nodes: 12 Number of AST nodes: 12
1
if (defaultViews == null) {
2
			XmlElement gui = Config.getInstance().get("views").getElement(
3
					"/views
1
IFolderItem item = parent.getConfiguration();
4
");
2
		XmlElement property = item.getElement("property");
5
	
6
		defaultViews = new XmlElement("defaultviews
3
		if (property != null) {
7
");
4
			String expanded = property.getAttribute("expanded");
8
			gui.addElement(defaultViews)
5
			if (expanded == null) {
9
;
6
				expanded = "true";
10
		}
7
			}
11
		// search through defaultViews to get settings for given id
8
			// 
12
		ViewItem view = null;
9
expand folder
10
			int row = getRowForPath(new TreePath(parent.getPath()));
11
			if (expanded.equals("true")) {
12
				expandRow(row);
13
			}
14
		}
15
		// recursivly expand all children
13
		for (int i = 0; i < defaultViews.count(); i++) {
16
		for (int i = 0; i < parent.getChildCount(); i++) {
14
			XmlElement child = defaultViews.getElement(i);
17
			
15
			String childId = child.getAttribute("id");
18
IMailFolder child = (IMailFolder) parent.getChildAt(i);
16
			if ((childId != null) && childId.equals(id)) {
19
			
17
				view = new ViewItem(child);
18
				break;
19
			}
20
		}
21
		return view;
20
expand(child);
21
		}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.3
Clones locationClones are in different classes
Number of node comparisons10
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment11
    Number of unmapped statements in the second code fragment11
    Time elapsed for statement mapping (ms)5.8
    Clone typeType 3
    Mapped Statements
    ID Statement ID Statement
    1
    if (defaultViews == null)
                                                          
    2
    XmlElement gui = Config.getInstance().get("views").getElement("/views");
                                                                                                                                                      
    3
    defaultViews = new XmlElement("defaultviews");
    3
    defaultViews = new XmlElement("defaultviews");
    Preondition Violations
    Unmatched statement defaultViews=new XmlElement("defaultviews"); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
                                                                                                  
    4
    gui.addElement(defaultViews);
    4
    gui.addElement(defaultViews);
    Preondition Violations
    Unmatched statement gui.addElement(defaultViews); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
                                                                    
    5
    ViewItem view = null;
    5
    ViewItem view = null;
    1
    IFolderItem item = parent.getConfiguration();
    Differences
    Expression1Expression2Difference
    org.columba.core.config.ViewItemorg.columba.mail.config.IFolderItemSUBCLASS_TYPE_MISMATCH
    viewitemVARIABLE_NAME_MISMATCH
    org.columba.core.config.ViewItemorg.columba.mail.config.IFolderItemSUBCLASS_TYPE_MISMATCH
    nullparent.getConfiguration()TYPE_COMPATIBLE_REPLACEMENT
    1
    IFolderItem item = parent.getConfiguration();
                                                                                                          
    2
    XmlElement property = item.getElement("property");
    Preondition Violations
    Unmatched statement XmlElement property=item.getElement("property"); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    2
    XmlElement property = item.getElement("property");
                                                  
    3
    if (property != null)
                                                                                                              
    4
    String expanded = property.getAttribute("expanded");
                                                  
    5
    if (expanded == null)
                                          
    6
    expanded = "true";
                                                                                                                      
    7
    int row = getRowForPath(new TreePath(parent.getPath()));
                                                                
    8
    if (expanded.equals("true"))
                                        
    9
    expandRow(row);
    Preondition Violations
    Unmatched statement expandRow(row); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    9
    expandRow(row);
    6
    for (int i = 0; i < defaultViews.count(); i++)
                                                                                                
    7
    XmlElement child = defaultViews.getElement(i);
                                                                                                  
    8
    String childId = child.getAttribute("id");
                                                                                          
    9
    if ((childId != null) && childId.equals(id))
                                                                                                
    10
    view = new ViewItem(child);
    10
    view = new ViewItem(child);
    Preondition Violations
    Unmatched statement view=new ViewItem(child); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
                                                              
    11
    break;
    11
    break;
    Preondition Violations
    Unmatched break;
                        
                                                                                                      
    10
    for (int i = 0; i < parent.getChildCount(); i++)
                                                                                                                    
    11
    IMailFolder child = (IMailFolder)parent.getChildAt(i);
                                        
    12
    expand(child);
    12
    return view;
    12
    return view;
    Preondition Violations
    Unmatched statement return view; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    Unmatched return view;
                                    
    Precondition Violations (10)
    Row Violation
    1Unmatched statement defaultViews=new XmlElement("defaultviews"); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    2Unmatched statement gui.addElement(defaultViews); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    3Unmatched statement XmlElement property=item.getElement("property"); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    4Unmatched statement expandRow(row); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    5Unmatched statement view=new ViewItem(child); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    6Unmatched break;
    7Unmatched statement return view; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    8Unmatched return view;
    9Clone fragment #1 returns variable view with type org.columba.core.config.ViewItem , while Clone fragment #2 returns variable item with type org.columba.mail.config.IFolderItem
    10The refactoring of the clones is infeasible, because classes org.columba.core.gui.frame.FrameManager and org.columba.mail.gui.tree.TreeView do not have a common superclass