File path: /columba-1.4-src/core/src/main/java/org/columba/core/gui/frame/FrameManager.java | File path: /columba-1.4-src/core/src/main/java/org/columba/core/gui/globalactions/NewSubmenu.java | |||
Method name: boolean isManaged(String)
|
Method name: String[] getManagedFrames(IExtensionHandler)
|
|||
Number of AST nodes: 7 | Number of AST nodes: 7 | |||
1 | while (_enum.hasMoreElements()) {↵ | 1 | while (_enum.hasMoreElements()) {↵ | |
2 | IExtension extension = (IExtension) _enum.nextElement();↵ | 2 | IExtension extension = (IExtension) _enum.nextElement();↵ | |
3 | String managed = extension.getMetadata().getAttribute("managed");↵ | 3 | String managed = extension.getMetadata().getAttribute("managed");↵ | |
4 | if (managed == null)↵ | 4 | if (managed == null)↵ | |
5 | managed = "false";↵ | 5 | managed = "false";↵ | |
6 | if ( (extension.getMetadata().getId().equals(frameMediatorId)) && managed.equals("true") ) return true↵ | 6 | if (managed.equals("true"))↵ | |
7 | ;↵ | 7 | result.add(extension.getMetadata().getId());↵ | |
8 | } | 8 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.4 |
Clones location | Clones are in different classes |
Number of node comparisons | 16 |
Number of mapped statements | 5 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 2.4 |
Clone type | Type 3 |
ID | Statement | ID | Statement | ||||
---|---|---|---|---|---|---|---|
2 | while (_enum.hasMoreElements()) | 3 | while (_enum.hasMoreElements()) | ||||
3 | IExtension extension = (IExtension)_enum.nextElement(); | 4 | IExtension extension = (IExtension)_enum.nextElement(); | ||||
4 | String managed = extension.getMetadata().getAttribute("managed"); | 5 | String managed = extension.getMetadata().getAttribute("managed"); | ||||
5 | if (managed == null) | 6 | if (managed == null) | ||||
6 | managed = "false"; | 7 | managed = "false"; | ||||
7 | if ((extension.getMetadata().getId().equals(frameMediatorId)) && managed.equals("true")) |
| | ||||
8 | return true; |
| | ||||
|
| 8 | if (managed.equals("true")) | ||||
|
| 9 | result.add(extension.getMetadata().getId()); |
Row | Violation |
---|---|
1 | Unmatched statement if((extension.getMetadata().getId().equals(frameMediatorId)) && managed.equals("true")) cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Unmatched return true; |
3 | Unmatched statement if(managed.equals("true")) cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
4 | Unmatched statement result.add(extension.getMetadata().getId()); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
5 | Clone fragment #1 returns variables extension, managed , while Clone fragment #2 returns variables managed, extension |
6 | The refactoring of the clones is infeasible, because classes org.columba.core.gui.frame.FrameManager and org.columba.core.gui.globalactions.NewSubmenu do not have a common superclass |