AbstractMailCheckingAction action = get(uid); // remove this account if (action != null) { list.remove(action); }
if (appendSignature && signatureFile != null) { String signature = getSignature(signatureFile); if (signature != null) { body = body + "\r\n\r\n" + signature; } }
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/mailchecking/MailCheckingManager.java File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/composer/MessageComposer.java
Method name: void remove(int) Method name: StreamableMimePart composeTextMimePart(boolean)
Number of AST nodes: 3 Number of AST nodes: 4
1
AbstractMailCheckingAction action = get(uid);
2
        // remove this account
3
        if (action != null) {
4
            list.remove(action);
5
        
1
if (appendSignature && signatureFile != null) {
2
			String signature = getSignature(signatureFile);
3
			if (signature != null) {
4
				body = body + "\r\n\r\n" + signature;
5
			}
6
}
6
		}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.2
Clones locationClones are in different classes
Number of node comparisons5
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)1.0
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    AbstractMailCheckingAction action = get(uid);
                                                                                                
                                                                                                      
    10
    String signature = getSignature(signatureFile);
    2
    if (action != null)
    2
    if (action != null)
    11
    if (signature != null)
    Differences
    Expression1Expression2Difference
    actionsignatureVARIABLE_NAME_MISMATCH
    org.columba.mail.mailchecking.AbstractMailCheckingActionjava.lang.StringVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.columba.mail.mailchecking.AbstractMailCheckingAction of variable action does not match with type java.lang.String of variable signature
    • Make classes org.columba.mail.mailchecking.AbstractMailCheckingAction and java.lang.String extend a common superclass
    11
    if (signature != null)
    3
    list.remove(action);
    3
    list.remove(action);
    Preondition Violations
    Unmatched statement list.remove(action); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
                                                  
                                                                                  
    12
    body = body + "\r\n\r\n" + signature;
    Preondition Violations
    Unmatched statement body=body + "\r\n\r\n" + signature; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    12
    body = body + "\r\n\r\n" + signature;
    Precondition Violations (4)
    Row Violation
    1Type org.columba.mail.mailchecking.AbstractMailCheckingAction of variable action does not match with type java.lang.String of variable signature
    2Unmatched statement list.remove(action); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    3Unmatched statement body=body + "\r\n\r\n" + signature; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    4The refactoring of the clones is infeasible, because the number of macthed statements is equal to zero