File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/folder/mbox/CachedMboxFolder.java | File path: /columba-1.4-src/core/src/main/java/org/columba/core/gui/util/AboutDialog.java | |||
Method name: IDataStorage getDataStorageInstance()
|
Method name: AboutDialog getInstance()
|
|||
Number of AST nodes: 3 | Number of AST nodes: 3 | |||
1 | if (dataStorage == null) {↵ | 1 | if (instance == null) {↵ | |
2 | dataStorage = new MboxDataStorage(this);↵ | 2 | instance = new Abo↵ | |
3 | }↵ | |||
4 | return dataStorag↵ | 3 | utDialog();↵ | |
4 | }↵ | |||
5 | e; | 5 | return instance; | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2 |
Clones location | Clones are in different classes |
Number of node comparisons | 5 |
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 17.7 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | if (dataStorage == null) |
| 1 | if (instance == null) | ||||||||||||||
|
| 2 | instance = new AboutDialog(); | |||||||||||||||
2 | dataStorage = new MboxDataStorage(this); |
| | |||||||||||||||
|
| 3 | return instance; | |||||||||||||||
3 | return dataStorage; |
| |
Row | Violation |
---|---|
1 | Type org.columba.mail.folder.IDataStorage of variable dataStorage does not match with type org.columba.core.gui.util.AboutDialog of variable instance |
2 | Unmatched statement instance=new AboutDialog(); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
3 | Unmatched statement instance=new AboutDialog(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |
4 | Unmatched statement dataStorage=new MboxDataStorage(this); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
5 | Unmatched return instance; |
6 | Unmatched return dataStorage; |
7 | The refactoring of the clones is infeasible, because the number of macthed statements is equal to zero |