File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/composer/MessageComposer.java | File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/gui/composer/SignatureView.java | |||
Method name: String getSignature(File)
|
Method name: void readSignature(File)
|
|||
Number of AST nodes: 6 | Number of AST nodes: 6 | |||
1 | BufferedReader in = new BufferedReader(new FileReader(file));↵ | 1 | BufferedReader in = new BufferedReader(↵ | |
2 | /*↵ | |||
3 | * BufferedReader in = new BufferedReader( new InputStreamReader(↵ | |||
4 | * new FileInputStream(file), model.getCharsetName()));↵ | |||
5 | */↵ | |||
2 | new FileReader(signatureFile));↵ | |||
6 | String str;↵ | 3 | String str;↵ | |
7 | while ((str = in.readLine()) != null) {↵ | 4 | while ((str = in.readLine()) != null) {↵ | |
8 | strbuf.append(str + "\n");↵ | 5 | strbuf.append(str + "\n");↵ | |
9 | }↵ | 6 | }↵ | |
10 | in.close();↵ | 7 | in.close();↵ | |
11 | ↵ | |||
12 | return strbuf.toString(); | 8 | textPane.setText(strbuf.toString()); | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.3 |
Clones location | Clones are in different classes |
Number of node comparisons | 15 |
Number of mapped statements | 5 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 2.1 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
3 | BufferedReader in = new BufferedReader(new FileReader(file)); |
| 3 | BufferedReader in = new BufferedReader(new FileReader(signatureFile)); | ||||||||||
4 | String str; | 4 | String str; | |||||||||||
5 | while ((str = in.readLine()) != null) | 5 | while ((str = in.readLine()) != null) | |||||||||||
6 | strbuf.append(str + "\n"); | 6 | strbuf.append(str + "\n"); | |||||||||||
7 | in.close(); | 7 | in.close(); | |||||||||||
|
| 8 | textPane.setText(strbuf.toString()); | |||||||||||
8 | return strbuf.toString(); |
| |
Row | Violation |
---|---|
1 | Unmatched statement textPane.setText(strbuf.toString()); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Unmatched statement return strbuf.toString(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
3 | Unmatched return strbuf.toString(); |