File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/gui/config/subscribe/SynchronizeFolderListCommand.java | File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/gui/tree/FolderTreeModel.java | |||
Method name: DefaultMutableTreeNode ensureChild(String, String, DefaultMutableTreeNode)
|
Method name: IMailFolder findFolder(IMailFolder, String)
|
|||
Number of AST nodes: 4 | Number of AST nodes: 4 | |||
1 | while (children.hasMoreElements()) {↵ | 1 | for (Enumeration e = parentFolder.children(); e.hasMoreElements();) {↵ | |
2 | node = (ListInfoTreeNode) children.nextElement();↵ | 2 | child = (IMailFolder) e.nextElement();↵ | |
3 | if (node.toString().equals(name)) {↵ | 3 | if (child.getName().equals(str)) {↵ | |
4 | return node;↵ | 4 | return child;↵ | |
5 | }↵ | 5 | }↵ | |
6 | } | 6 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.9 |
Clones location | Clones are in different classes |
Number of node comparisons | 8 |
Number of mapped statements | 5 |
Number of unmapped statements in the first code fragment | 0 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 5.2 |
Clone type | Type 2 |
ID | Statement | ID | Statement | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
3 | while (children.hasMoreElements()) |
| 2 | for (Enumeration e = parentFolder.children(); e.hasMoreElements(); ) | |||||||||||||||||||||
4 | node = (ListInfoTreeNode)children.nextElement(); |
| 3 | child = (IMailFolder)e.nextElement(); | |||||||||||||||||||||
5 | if (node.toString().equals(name)) |
| 4 | if (child.getName().equals(str)) | |||||||||||||||||||||
6 | return node; |
| 5 | return child; |
Row | Violation |
---|---|
1 | Expression (ListInfoTreeNode)children.nextElement() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression (IMailFolder)e.nextElement() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Expression node.toString() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
4 | Expression child.getName() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
5 | Not all possible execution flows end in a return statement |
6 | The refactoring of the clones is infeasible, because classes org.columba.mail.gui.config.subscribe.SynchronizeFolderListCommand and org.columba.mail.gui.tree.FolderTreeModel do not have a common superclass |