if (dataStorage == null) { dataStorage = new MHDataStorage(this); } return dataStorage;
if (instance == null) { instance = new LogRecordList(); } return instance;
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/folder/mh/CachedMHFolder.java File path: /columba-1.4-src/plugins/org.columba.core.LogDisplay/src/org/columba/core/gui/logdisplay/LogRecordList.java
Method name: IDataStorage getDataStorageInstance() Method name: LogRecordList getInstance()
Number of AST nodes: 3 Number of AST nodes: 3
1
if (dataStorage == null) {
1
if (instance == null) {
2
            dataStorage = new MHDataStorage(this);
2
            instance = new LogRecordList();
3
        }
3
        }
4
        return dataStorage;
4
        return instance;
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons5
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)17.4
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    if (dataStorage == null)
    1
    if (dataStorage == null)
    1
    if (instance == null)
    Differences
    Expression1Expression2Difference
    dataStorageinstanceVARIABLE_NAME_MISMATCH
    org.columba.mail.folder.IDataStorageorg.columba.core.gui.logdisplay.LogRecordListVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.columba.mail.folder.IDataStorage of variable dataStorage does not match with type org.columba.core.gui.logdisplay.LogRecordList of variable instance
    • Make classes org.columba.mail.folder.IDataStorage and org.columba.core.gui.logdisplay.LogRecordList extend a common superclass
    1
    if (instance == null)
                                                                    
    2
    instance = new LogRecordList();
    Preondition Violations
    Unmatched statement instance=new LogRecordList(); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    2
    instance = new LogRecordList();
    2
    dataStorage = new MHDataStorage(this);
    2
    dataStorage = new MHDataStorage(this);
    Preondition Violations
    Unmatched statement dataStorage=new MHDataStorage(this); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
                                                                                  
                                          
    3
    return instance;
    Preondition Violations
    Unmatched return instance;
    3
    return instance;
    3
    return dataStorage;
    3
    return dataStorage;
    Preondition Violations
    Unmatched return dataStorage;
                                                
    Precondition Violations (6)
    Row Violation
    1Type org.columba.mail.folder.IDataStorage of variable dataStorage does not match with type org.columba.core.gui.logdisplay.LogRecordList of variable instance
    2Unmatched statement instance=new LogRecordList(); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    3Unmatched statement dataStorage=new MHDataStorage(this); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    4Unmatched return instance;
    5Unmatched return dataStorage;
    6The refactoring of the clones is infeasible, because the number of macthed statements is equal to zero