if (viewItem == null) { viewItem = new ViewItem(getRoot().getElement("/options/gui/view")); } return viewItem;
if (instance == null) { instance = new AboutDialog(); } return instance;
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/config/ComposerOptionsXmlConfig.java File path: /columba-1.4-src/core/src/main/java/org/columba/core/gui/util/AboutDialog.java
Method name: ViewItem getViewItem() Method name: AboutDialog getInstance()
Number of AST nodes: 3 Number of AST nodes: 3
1
if (viewItem == null) {
1
if (instance == null) {
2
            viewItem = new ViewItem(getRoot().getElement("/options/gui/view"));
3
        }
4
        return viewItem
2
			instance = new AboutDialog();
3
		}
5
;
4
		return instance;
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.2
Clones locationClones are in different classes
Number of node comparisons5
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)0.9
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    if (viewItem == null)
    1
    if (viewItem == null)
    1
    if (instance == null)
    Differences
    Expression1Expression2Difference
    viewIteminstanceVARIABLE_NAME_MISMATCH
    org.columba.core.config.ViewItemorg.columba.core.gui.util.AboutDialogVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.columba.core.config.ViewItem of variable viewItem does not match with type org.columba.core.gui.util.AboutDialog of variable instance
    • Make classes org.columba.core.config.ViewItem and org.columba.core.gui.util.AboutDialog extend a common superclass
    1
    if (instance == null)
                                                                
    2
    instance = new AboutDialog();
    Preondition Violations
    Unmatched statement instance=new AboutDialog(); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    Unmatched statement instance=new AboutDialog(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    2
    instance = new AboutDialog();
    2
    viewItem = new ViewItem(getRoot().getElement("/options/gui/view"));
    2
    viewItem = new ViewItem(getRoot().getElement("/options/gui/view"));
    Preondition Violations
    Unmatched statement viewItem=new ViewItem(getRoot().getElement("/options/gui/view")); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
                                                                                                                                            
                                          
    3
    return instance;
    Preondition Violations
    Unmatched return instance;
    3
    return instance;
    3
    return viewItem;
    3
    return viewItem;
    Preondition Violations
    Unmatched return viewItem;
                                          
    Precondition Violations (7)
    Row Violation
    1Type org.columba.core.config.ViewItem of variable viewItem does not match with type org.columba.core.gui.util.AboutDialog of variable instance
    2Unmatched statement instance=new AboutDialog(); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    3Unmatched statement instance=new AboutDialog(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    4Unmatched statement viewItem=new ViewItem(getRoot().getElement("/options/gui/view")); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    5Unmatched return instance;
    6Unmatched return viewItem;
    7The refactoring of the clones is infeasible, because the number of macthed statements is equal to zero