File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/config/MainFrameOptionsXmlConfig.java | File path: /columba-1.4-src/core/src/main/java/org/columba/core/facade/ServiceFacadeRegistry.java | |||
Method name: ViewItem getViewItem()
|
Method name: Object getServiceInstance()
|
|||
Number of AST nodes: 3 | Number of AST nodes: 3 | |||
1 | if (viewItem == null) {↵ | 1 | if (↵ | |
2 | viewItem = new ViewItem(getRoot().getElement("/options/gui/viewlist/view"));↵ | |||
3 | }↵ | |||
4 | ↵ | 2 | serviceInstance == null) {↵ | |
3 | // load instance of service↵ | |||
4 | serviceInstance = loadInstance(implementationName);↵ | |||
5 | }↵ | |||
5 | return viewItem; | 6 | return serviceInstance; | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.1 |
Clones location | Clones are in different classes |
Number of node comparisons | 5 |
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 0.5 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | if (viewItem == null) |
| 1 | if (serviceInstance == null) | ||||||||||||||
|
| 2 | serviceInstance = loadInstance(implementationName); | |||||||||||||||
2 | viewItem = new ViewItem(getRoot().getElement("/options/gui/viewlist/view")); |
| | |||||||||||||||
|
| 3 | return serviceInstance; | |||||||||||||||
3 | return viewItem; |
| |
Row | Violation |
---|---|
1 | Type org.columba.core.config.ViewItem of variable viewItem does not match with type java.lang.Object of variable serviceInstance |
2 | Unmatched statement serviceInstance=loadInstance(implementationName); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
3 | Unmatched statement viewItem=new ViewItem(getRoot().getElement("/options/gui/viewlist/view")); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
4 | Unmatched return serviceInstance; |
5 | Unmatched return viewItem; |
6 | The refactoring of the clones is infeasible, because the number of macthed statements is equal to zero |