File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/composer/MessageComposer.java | File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/mailchecking/MailCheckingManager.java | |||
Method name: StreamableMimePart composeHtmlMimePart(boolean)
|
Method name: void remove(int)
|
|||
Number of AST nodes: 5 | Number of AST nodes: 3 | |||
1 | if (signatureFile != null) {↵ | |||
2 | String signature = getSignature(signatureFile);↵ | |||
3 | if (signature != null) {↵ | |||
4 | buf.append("\r\n\r\n");↵ | |||
5 | // TODO: Should we take some action to ensure signature is valid↵ | |||
6 | // html?↵ | |||
7 | buf.append(signature);↵ | |||
8 | }↵ | |||
9 | ↵ | 1 | AbstractMailCheckingAction action = get(uid);↵ | |
2 | // remove this account↵ | |||
3 | if (action != null) {↵ | |||
4 | list.remove(action);↵ | |||
10 | } | 5 | } | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2 |
Clones location | Clones are in different classes |
Number of node comparisons | 7 |
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 3 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 1.3 |
Clone type | Type 3 |
ID | Statement | ID | Statement | |||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1 | AbstractMailCheckingAction action = get(uid); | ||||||||||||||||
30 | String signature = getSignature(signatureFile); | | ||||||||||||||||
31 | if (signature != null) |
| 2 | if (action != null) | ||||||||||||||
|
| 3 | list.remove(action); | |||||||||||||||
32 | buf.append("\r\n\r\n"); |
| | |||||||||||||||
33 | buf.append(signature); |
| |
Row | Violation |
---|---|
1 | Type java.lang.String of variable signature does not match with type org.columba.mail.mailchecking.AbstractMailCheckingAction of variable action |
2 | Unmatched statement list.remove(action); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
3 | Unmatched statement buf.append("\r\n\r\n"); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
4 | Unmatched statement buf.append(signature); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
5 | The refactoring of the clones is infeasible, because the number of macthed statements is equal to zero |