File path: /columba-1.4-src/core/src/main/java/org/columba/core/search/SearchManager.java | File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/facade/ContactFacade.java | |||
Method name: void execute(IWorkerStatusController)
|
Method name: void addContact(IContactItem)
|
|||
Number of AST nodes: 3 | Number of AST nodes: 3 | |||
1 | String providerTechnicalName = ref.getProviderTechnicalName();↵ | |||
2 | ISearchProvider p = getProvider(providerTechnicalName);↵ | |||
3 | doExecute(ref.getSearchTerm(), p, ref↵ | |||
4 | .getSearchCriteriaTechnicalName(),↵ | |||
5 | ref.isSearchInside(), ref.getS↵ | 1 | IFolder folder = dialog.getSelectedFolder();↵ | |
2 | String uid = folder.getId();↵ | |||
6 | tartIndex(), ref↵ | 3 | addContact(uid, contactI↵ | |
7 | .getResultCount()); | 4 | tem); | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.0 |
Clones location | Clones are in different classes |
Number of node comparisons | 9 |
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 0.0 |
Clone type | Type 2 |
ID | Statement | ID | Statement | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 6 | IFolder folder = dialog.getSelectedFolder(); | |||||||||||||||||||||||
| 7 | String uid = folder.getId(); | |||||||||||||||||||||||
20 | String providerTechnicalName = ref.getProviderTechnicalName(); | | |||||||||||||||||||||||
21 | ISearchProvider p = getProvider(providerTechnicalName); |
| | ||||||||||||||||||||||
22 | doExecute(ref.getSearchTerm(), p, ref.getSearchCriteriaTechnicalName(), ref.isSearchInside(), ref.getStartIndex(), ref.getResultCount()); |
| 8 | addContact(uid, contactItem); |
Row | Violation |
---|---|
1 | Unmatched statement ISearchProvider p=getProvider(providerTechnicalName); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
2 | Expression doExecute(ref.getSearchTerm(),p,ref.getSearchCriteriaTechnicalName(),ref.isSearchInside(),ref.getStartIndex(),ref.getResultCount()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Expression addContact(uid,contactItem) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
4 | Expression doExecute(ref.getSearchTerm(),p,ref.getSearchCriteriaTechnicalName(),ref.isSearchInside(),ref.getStartIndex(),ref.getResultCount()) is a void method call, and thus it cannot be parameterized |
5 | Expression addContact(uid,contactItem) is a void method call, and thus it cannot be parameterized |
6 | Expression doExecute(ref.getSearchTerm(),p,ref.getSearchCriteriaTechnicalName(),ref.isSearchInside(),ref.getStartIndex(),ref.getResultCount()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
7 | Expression addContact(uid,contactItem) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
8 | Expression doExecute(ref.getSearchTerm(),p,ref.getSearchCriteriaTechnicalName(),ref.isSearchInside(),ref.getStartIndex(),ref.getResultCount()) is a void method call, and thus it cannot be parameterized |
9 | Expression addContact(uid,contactItem) is a void method call, and thus it cannot be parameterized |
10 | The refactoring of the clones is infeasible, because classes org.columba.core.search.SearchManager.SearchCommand and org.columba.addressbook.facade.ContactFacade do not have a common superclass |