if (dataStorage == null) { dataStorage = new MboxDataStorage(this); } return dataStorage;
if (list == null) { list = new AccountList(getRoot().getElement("/accountlist")); } return list;
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/folder/mbox/CachedMboxFolder.java File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/config/AccountXmlConfig.java
Method name: IDataStorage getDataStorageInstance() Method name: AccountList getAccountList()
Number of AST nodes: 3 Number of AST nodes: 3
1
if (dataStorage == null) {
1
if (list == null) {
2
            dataStorage = new MboxDataStorage(this);
2
            list = new AccountList(getRoot().getElement("/accountlist"));
3
        }
3
        }
4
        return dataStorage;
4
        return list;
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons5
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)17.4
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    if (dataStorage == null)
    1
    if (dataStorage == null)
    1
    if (list == null)
    Differences
    Expression1Expression2Difference
    dataStoragelistVARIABLE_NAME_MISMATCH
    org.columba.mail.folder.IDataStorageorg.columba.mail.config.AccountListVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.columba.mail.folder.IDataStorage of variable dataStorage does not match with type org.columba.mail.config.AccountList of variable list
    • Make classes org.columba.mail.folder.IDataStorage and org.columba.mail.config.AccountList extend a common superclass
    1
    if (list == null)
                                                                                                                                
    2
    list = new AccountList(getRoot().getElement("/accountlist"));
    Preondition Violations
    Unmatched statement list=new AccountList(getRoot().getElement("/accountlist")); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    2
    list = new AccountList(getRoot().getElement("/accountlist"));
    2
    dataStorage = new MboxDataStorage(this);
    2
    dataStorage = new MboxDataStorage(this);
    Preondition Violations
    Unmatched statement dataStorage=new MboxDataStorage(this); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
                                                                                      
                                  
    3
    return list;
    Preondition Violations
    Unmatched return list;
    3
    return list;
    3
    return dataStorage;
    3
    return dataStorage;
    Preondition Violations
    Unmatched return dataStorage;
                                                
    Precondition Violations (6)
    Row Violation
    1Type org.columba.mail.folder.IDataStorage of variable dataStorage does not match with type org.columba.mail.config.AccountList of variable list
    2Unmatched statement list=new AccountList(getRoot().getElement("/accountlist")); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    3Unmatched statement dataStorage=new MboxDataStorage(this); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    4Unmatched return list;
    5Unmatched return dataStorage;
    6The refactoring of the clones is infeasible, because the number of macthed statements is equal to zero