if (dataStorage == null) { dataStorage = new XmlDataStorage(this); } return dataStorage;
if (delimiter == null) { // try to determine delimiter delimiter = fetchDelimiter(); } return delimiter;
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/folder/AddressbookFolder.java File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/imap/IMAPServer.java
Method name: DataStorage getDataStorageInstance() Method name: String getDelimiter()
Number of AST nodes: 3 Number of AST nodes: 3
1
if (dataStorage == null) {
1
if (delimiter == null) {
2
            dataStorage = new XmlDataStorage(this
2
            // try to determine delimiter
3
);
3
            delimiter = fetchDelimiter();
4
        }
4
        }
5
        return dataStorage;
5
        return delimiter;
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons5
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)7.1
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    if (dataStorage == null)
    1
    if (dataStorage == null)
    1
    if (delimiter == null)
    Differences
    Expression1Expression2Difference
    dataStoragedelimiterVARIABLE_NAME_MISMATCH
    org.columba.addressbook.folder.DataStoragejava.lang.StringVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.columba.addressbook.folder.DataStorage of variable dataStorage does not match with type java.lang.String of variable delimiter
    • Make classes org.columba.addressbook.folder.DataStorage and java.lang.String extend a common superclass
    1
    if (delimiter == null)
                                                                
    2
    delimiter = fetchDelimiter();
    Preondition Violations
    Unmatched statement delimiter=fetchDelimiter(); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    Unmatched statement delimiter=fetchDelimiter(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    2
    delimiter = fetchDelimiter();
    2
    dataStorage = new XmlDataStorage(this);
    2
    dataStorage = new XmlDataStorage(this);
    Preondition Violations
    Unmatched statement dataStorage=new XmlDataStorage(this); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
                                                                                    
                                            
    3
    return delimiter;
    Preondition Violations
    Unmatched return delimiter;
    3
    return delimiter;
    3
    return dataStorage;
    3
    return dataStorage;
    Preondition Violations
    Unmatched return dataStorage;
                                                
    Precondition Violations (7)
    Row Violation
    1Type org.columba.addressbook.folder.DataStorage of variable dataStorage does not match with type java.lang.String of variable delimiter
    2Unmatched statement delimiter=fetchDelimiter(); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    3Unmatched statement delimiter=fetchDelimiter(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    4Unmatched statement dataStorage=new XmlDataStorage(this); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    5Unmatched return delimiter;
    6Unmatched return dataStorage;
    7The refactoring of the clones is infeasible, because the number of macthed statements is equal to zero