if (dataStorage == null) { dataStorage = new MHDataStorage(this); } return dataStorage;
if (instance == null) { throw new RuntimeException("Must call Constructor first!"); } return instance;
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/folder/mh/CachedMHFolder.java File path: /columba-1.4-src/core/src/main/java/org/columba/core/config/Config.java
Method name: IDataStorage getDataStorageInstance() Method name: Config getInstance()
Number of AST nodes: 3 Number of AST nodes: 3
1
if (dataStorage == null) {
1
if (instance == null) {
2
            dataStorage = new MHDataStorage(this);
3
        }
4
        return dataStorag
2
			throw new RuntimeException("Must call Constructor first!");
3
		}
5
e;
4
		return instance;
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons5
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)16.8
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    if (dataStorage == null)
    1
    if (dataStorage == null)
    1
    if (instance == null)
    Differences
    Expression1Expression2Difference
    dataStorageinstanceVARIABLE_NAME_MISMATCH
    org.columba.mail.folder.IDataStorageorg.columba.core.config.ConfigVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.columba.mail.folder.IDataStorage of variable dataStorage does not match with type org.columba.core.config.Config of variable instance
    • Make classes org.columba.mail.folder.IDataStorage and org.columba.core.config.Config extend a common superclass
    1
    if (instance == null)
                                                                                                                                
    2
    throw new RuntimeException("Must call Constructor first!");
    Preondition Violations
    Unmatched statement throw new RuntimeException("Must call Constructor first!"); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    Unmatched throw new RuntimeException("Must call Constructor first!");
    2
    throw new RuntimeException("Must call Constructor first!");
    2
    dataStorage = new MHDataStorage(this);
    2
    dataStorage = new MHDataStorage(this);
    Preondition Violations
    Unmatched statement dataStorage=new MHDataStorage(this); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
                                                                                  
                                          
    3
    return instance;
    Preondition Violations
    Unmatched statement return instance; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    Unmatched return instance;
    3
    return instance;
    3
    return dataStorage;
    3
    return dataStorage;
    Preondition Violations
    Unmatched return dataStorage;
                                                
    Precondition Violations (8)
    Row Violation
    1Type org.columba.mail.folder.IDataStorage of variable dataStorage does not match with type org.columba.core.config.Config of variable instance
    2Unmatched statement throw new RuntimeException("Must call Constructor first!"); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    3Unmatched throw new RuntimeException("Must call Constructor first!");
    4Unmatched statement dataStorage=new MHDataStorage(this); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    5Unmatched statement return instance; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    6Unmatched return instance;
    7Unmatched return dataStorage;
    8The refactoring of the clones is infeasible, because the number of macthed statements is equal to zero