if (model != null) { model.close(id); model = null; }
if (add != null) { _adds.put(add, item); }
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/core/src/main/java/org/columba/core/io/CloneInputStream.java File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/gui/composer/util/AddressCollector.java
Method name: void close() Method name: void addAddress(String, IHeaderItem)
Number of AST nodes: 3 Number of AST nodes: 2
1
if (model != null) {
1
if (add != null) {
2
			model.close(id);
2
			
3
			model = null;
3
_adds.put(add, item);
4
		}
4
		}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons6
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment1
    Time elapsed for statement mapping (ms)0.6
    Clone typeType 3
    Mapped Statements
    ID Statement ID Statement
    1
    if (model != null)
    1
    if (model != null)
    1
    if (add != null)
    Differences
    Expression1Expression2Difference
    modeladdVARIABLE_NAME_MISMATCH
    org.columba.core.io.CloneStreamMasterjava.lang.StringVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.columba.core.io.CloneStreamMaster of variable model does not match with type java.lang.String of variable add
    • Make classes org.columba.core.io.CloneStreamMaster and java.lang.String extend a common superclass
    1
    if (add != null)
                                                  
    2
    _adds.put(add, item);
    Preondition Violations
    Unmatched statement _adds.put(add,item); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    2
    _adds.put(add, item);
    2
    model.close(id);
    2
    model.close(id);
    Preondition Violations
    Unmatched statement model.close(id); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    Unmatched statement model.close(id); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
                                          
    3
    model = null;
    3
    model = null;
    Preondition Violations
    Unmatched statement model=null; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
                                
    Precondition Violations (6)
    Row Violation
    1Type org.columba.core.io.CloneStreamMaster of variable model does not match with type java.lang.String of variable add
    2Unmatched statement _adds.put(add,item); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    3Unmatched statement model.close(id); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    4Unmatched statement model.close(id); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    5Unmatched statement model=null; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    6The refactoring of the clones is infeasible, because the number of macthed statements is equal to zero