File path: /emf-2.4.1/src/org/eclipse/emf/ecore/xml/type/internal/DataValue.java | File path: /emf-2.4.1/src/org/eclipse/emf/ecore/xml/type/internal/DataValue.java | |||
Method name: void initializePath(String, int)
|
Method name: void initializePath(String, int)
|
|||
Number of AST nodes: 10 | Number of AST nodes: 10 | |||
1 | testChar = p_uriSpec.charAt(index);↵ | 1 | testChar = p_uriSpec.charAt(index);↵ | |
2 | ↵ | 2 | ↵ | |
3 | if (testChar == '?' || testChar == '#') {↵ | |||
4 | break;↵ | |||
5 | }↵ | |||
6 | ↵ | |||
3 | // check for valid escape sequence↵ | 7 | // check for valid escape sequence↵ | |
4 | if (testChar == '%') {↵ | 8 | if (testChar == '%') {↵ | |
5 | if (index+2 >= end ||↵ | 9 | if (index+2 >= end ||↵ | |
6 | !isHex(p_uriSpec.charAt(index+1)) ||↵ | 10 | !isHex(p_uriSpec.charAt(index+1)) ||↵ | |
7 | !isHex(p_uriSpec.charAt(index+2))) {↵ | 11 | !isHex(p_uriSpec.charAt(index+2))) {↵ | |
8 | throw new MalformedURIException(↵ | 12 | throw new MalformedURIException(↵ | |
9 | "Path contains invalid escape sequence!");↵ | 13 | "Opaque part contains invalid escape sequence!");↵ | |
10 | }↵ | 14 | }↵ | |
11 | index += 2;↵ | 15 | index += 2;↵ | |
12 | }↵ | 16 | }↵ | |
13 | // Path segments cannot contain '[' or ']' since pchar↵ | 17 | // If the scheme specific part is opaque, it can contain '['↵ | |
14 | // production was not changed by RFC 2732.↵ | 18 | // and ']'. uric_no_slash wasn't modified by RFC 2732, which↵ | |
15 | else if (!isPathCharacter(testChar)) {↵ | 19 | ↵ | |
16 | if (testChar == '?' || testChar ==↵ | 20 | // I've interpreted as an error in the spec, since the ↵ | |
17 | '#') {↵ | 21 | // production should be equivalent to (uric - '/'), and uric↵ | |
18 | break;↵ | 22 | ↵ | |
19 | }↵ | 23 | // contains '[' and ']'. - mrglavas↵ | |
24 | else if (!isURICharacter(testChar)) {↵ | |||
20 | throw new MalformedURIException(↵ | 25 | throw new MalformedURIException(↵ | |
21 | "Path contains invalid character: " + testChar);↵ | 26 | "Opaque part contains invalid character: " + testChar);↵ | |
22 | }↵ | 27 | }↵ | |
23 | ++index; | 28 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 1.2 |
Clones location | Clones are in the same method |
Number of node comparisons | 17 |
Number of mapped statements | 7 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 4.0 |
Clone type | Type 3 |
ID | Statement | ID | Statement | |||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
10 | testChar = p_uriSpec.charAt(index); | 21 | testChar = p_uriSpec.charAt(index); | |||||||||||||
11 | if (testChar == '%') | 24 | if (testChar == '%') | |||||||||||||
12 | if (index + 2 >= end || !isHex(p_uriSpec.charAt(index + 1)) || !isHex(p_uriSpec.charAt(index + 2))) | 25 | if (index + 2 >= end || !isHex(p_uriSpec.charAt(index + 1)) || !isHex(p_uriSpec.charAt(index + 2))) | |||||||||||||
13 | throw new MalformedURIException("Path contains invalid escape sequence!"); |
| 26 | throw new MalformedURIException("Opaque part contains invalid escape sequence!"); | ||||||||||||
14 | index += 2; | 27 | index += 2; | |||||||||||||
15 | else if (!isPathCharacter(testChar)) |
| 28 | else if (!isURICharacter(testChar)) | ||||||||||||
16 | if (testChar == '?' || testChar == '#') |
| | |||||||||||||
17 | break; |
| | |||||||||||||
18 | throw new MalformedURIException("Path contains invalid character: " + testChar); |
| 29 | throw new MalformedURIException("Opaque part contains invalid character: " + testChar); |
Row | Violation |
---|---|
1 | Expression isPathCharacter(testChar) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression isURICharacter(testChar) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Unmatched statement if(testChar == '?' || testChar == '#') cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
4 | Unmatched break; |
5 | Clone fragment #1 returns variables testChar, index , while Clone fragment #2 returns variables testChar, index |