String dialectName = properties.getProperty( Environment.DIALECT ); if ( dialectName == null ) { return determineDialect( connection ); } else { return constructDialect( dialectName ); }
if (value==null) { return null; } else { return (Serializable) deepCopy( value, session.getEntityMode(), session.getFactory() ); }
Clone fragments detected by clone detection tool
File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/dialect/resolver/DialectFactory.java File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/type/AbstractType.java
Method name: Dialect buildDialect(Properties, Connection) Method name: Serializable disassemble(Object, SessionImplementor, Object)
Number of AST nodes: 4 Number of AST nodes: 3
1
String dialectName = properties.getProperty( Environment.DIALECT );
2
		if ( dialectName == null ) {
1
if (value==null) {
3
			return determineDialect( connection );
2
			return 
4
		}
5
		else {
6
			return constructDialect( dialectName
3
null;
4
		}
5
		else {
7
 );
6
			return (Serializable) deepCopy( value, session.getEntityMode(), session.getFactory() );
8
		}
7
		}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.2
Clones locationClones are in different classes
Number of node comparisons9
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements2
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment1
    Time elapsed for statement mapping (ms)5.1
    Clone typeType 3
    Mapped Statements
    ID Statement ID Statement
    1
    String dialectName = properties.getProperty(Environment.DIALECT);
                                                                                                                                        
    2
    if (dialectName == null)
    2
    if (dialectName == null)
    1
    if (value == null)
    Differences
    Expression1Expression2Difference
    dialectNamevalueVARIABLE_NAME_MISMATCH
    java.lang.Stringjava.lang.ObjectVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type java.lang.String of variable dialectName does not match with type java.lang.Object of variable value
    • Make classes java.lang.String and java.lang.Object extend a common superclass
    1
    if (value == null)
    3
    return determineDialect(connection);
    3
    return determineDialect(connection);
    2
    return null;
    Differences
    Expression1Expression2Difference
    determineDialect(connection)nullTYPE_COMPATIBLE_REPLACEMENT
    Preondition Violations
    Expression determineDialect(connection) is a method call throwing exception(s) that should be caught by a try block that will be extracted
    • Inline private method determineDialect
    2
    return null;
    else
            
                                                                                                                                                                              
    3
    return (Serializable)deepCopy(value, session.getEntityMode(), session.getFactory());
    Preondition Violations
    Unmatched statement return (Serializable)deepCopy(value,session.getEntityMode(),session.getFactory()); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    Unmatched statement return (Serializable)deepCopy(value,session.getEntityMode(),session.getFactory()); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    Unmatched return (Serializable)deepCopy(value,session.getEntityMode(),session.getFactory());
    3
    return (Serializable)deepCopy(value, session.getEntityMode(), session.getFactory());
    4
    return constructDialect(dialectName);
    4
    return constructDialect(dialectName);
    Preondition Violations
    Unmatched statement return constructDialect(dialectName); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    Unmatched statement return constructDialect(dialectName); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    Unmatched return constructDialect(dialectName);
                                                                                    
    Precondition Violations (9)
    Row Violation
    1Type java.lang.String of variable dialectName does not match with type java.lang.Object of variable value
    2Expression determineDialect(connection) is a method call throwing exception(s) that should be caught by a try block that will be extracted
    3Unmatched statement return (Serializable)deepCopy(value,session.getEntityMode(),session.getFactory()); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    4Unmatched statement return (Serializable)deepCopy(value,session.getEntityMode(),session.getFactory()); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    5Unmatched return (Serializable)deepCopy(value,session.getEntityMode(),session.getFactory());
    6Unmatched statement return constructDialect(dialectName); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    7Unmatched statement return constructDialect(dialectName); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    8Unmatched return constructDialect(dialectName);
    9Not all possible execution flows end in a return statement