File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/loader/criteria/CriteriaQueryTranslator.java | File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/sql/Update.java | |||
Method name: String getOrderBy()
|
Method name: String toStatementString()
|
|||
Number of AST nodes: 5 | Number of AST nodes: 6 | |||
1 | while ( criterionIterator.hasNext() ) {↵ | 1 | while ( iter.hasNext() ) {↵ | |
2 | CriteriaImpl.OrderEntry oe = ( CriteriaImpl.OrderEntry ) criterionIterator.next();↵ | 2 | final Map.Entry e = (Map.Entry) iter.next();↵ | |
3 | orderBy↵ | 3 | if ( conditionsAppended ) {↵ | |
4 | buf.append( " and " );↵ | |||
5 | }↵ | |||
4 | .append( oe.getOrder().toSqlString( oe.getCriteria(), this ) );↵ | 6 | buf.append( e.getKey() ).append( e.get↵ | |
5 | if ( criterionIterator.hasNext() ) {↵ | |||
6 | orderBy.append( ", " );↵ | |||
7 | }↵ | 7 | Value() );↵ | |
8 | conditionsAppended = true;↵ | |||
8 | } | 9 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2 |
Clones location | Clones are in different classes |
Number of node comparisons | 16 |
Number of mapped statements | 3 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 3 |
Time elapsed for statement mapping (ms) | 2.2 |
Clone type | Type 3 |
ID | Statement | ID | Statement | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
3 | while (criterionIterator.hasNext()) |
| 29 | while (iter.hasNext()) | |||||||||||||
4 | CriteriaImpl.OrderEntry oe = (CriteriaImpl.OrderEntry)criterionIterator.next(); |
| | ||||||||||||||
5 | orderBy.append(oe.getOrder().toSqlString(oe.getCriteria(), this)); |
| | ||||||||||||||
|
| 30 | final Map.Entry e = (Map.Entry)iter.next(); | ||||||||||||||
6 | if (criterionIterator.hasNext()) |
| 31 | if (conditionsAppended) | |||||||||||||
7 | orderBy.append(", "); |
| 32 | buf.append(" and "); | |||||||||||||
| 33 | buf.append(e.getKey()).append(e.getValue()); | |||||||||||||||
|
| 34 | conditionsAppended = true; |
Row | Violation |
---|---|
1 | Unmatched statement CriteriaImpl.OrderEntry oe=(CriteriaImpl.OrderEntry)criterionIterator.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Unmatched statement orderBy.append(oe.getOrder().toSqlString(oe.getCriteria(),this)); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |
3 | Unmatched statement final Map.Entry e=(Map.Entry)iter.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
4 | Expression conditionsAppended cannot be parameterized, because it has dependencies to/from statements that will be extracted |
5 | Unmatched statement conditionsAppended=true; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |