File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/hql/ast/HqlSqlWalker.java | File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/loader/custom/sql/SQLQueryParser.java | |||
Method name: void trackNamedParameterPositions(String)
|
Method name: void addNamedParameter(String)
|
|||
Number of AST nodes: 10 | Number of AST nodes: 10 | |||
1 | Integer loc = new Integer( parameterCount++ );↵ | 1 | Integer loc = new Integer( parameterCount++ );↵ | |
2 | Object o = namedParameters.get( name );↵ | 2 | Object o = namedParameterBindPoints.get( name );↵ | |
3 | if ( o == null ) {↵ | 3 | if ( o == null ) {↵ | |
4 | namedParameters.put( name, loc );↵ | 4 | namedParameterBindPoints.put( name, loc );↵ | |
5 | }↵ | 5 | }↵ | |
6 | else if ( o instanceof Integer ) {↵ | 6 | else if ( o instanceof Integer ) {↵ | |
7 | ArrayList list = new ArrayList( 4 );↵ | 7 | ArrayList list = new ArrayList( 4 );↵ | |
8 | list.add( o );↵ | 8 | list.add( o );↵ | |
9 | list.add( loc );↵ | 9 | list.add( loc );↵ | |
10 | namedParameters.put( name, list );↵ | 10 | namedParameterBindPoints.put( name, list );↵ | |
11 | }↵ | 11 | }↵ | |
12 | else {↵ | 12 | else {↵ | |
13 | ( ( ArrayList ) o ).add( loc );↵ | 13 | ( ( List ) o ).add( loc );↵ | |
14 | } | 14 | } | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.4 |
Clones location | Clones are in different classes |
Number of node comparisons | 55 |
Number of mapped statements | 10 |
Number of unmapped statements in the first code fragment | 0 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 6.4 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | Integer loc = new Integer(parameterCount++); | 1 | Integer loc = new Integer(parameterCount++); | |||||||||||||
2 | Object o = namedParameters.get(name); |
| 2 | Object o = namedParameterBindPoints.get(name); | ||||||||||||
3 | if (o == null) | 3 | if (o == null) | |||||||||||||
4 | namedParameters.put(name, loc); |
| 4 | namedParameterBindPoints.put(name, loc); | ||||||||||||
5 | else if (o instanceof Integer) | 5 | else if (o instanceof Integer) | |||||||||||||
6 | ArrayList list = new ArrayList(4); | 6 | ArrayList list = new ArrayList(4); | |||||||||||||
7 | list.add(o); | 7 | list.add(o); | |||||||||||||
8 | list.add(loc); | 8 | list.add(loc); | |||||||||||||
9 | namedParameters.put(name, list); |
| 9 | namedParameterBindPoints.put(name, list); | ||||||||||||
else | else | |||||||||||||||
10 | ((ArrayList)o).add(loc); |
| 10 | ((List)o).add(loc); |
Row | Violation |
---|---|
1 | Expression (ArrayList)o cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression (List)o cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | The refactoring of the clones is infeasible, because classes org.hibernate.hql.ast.HqlSqlWalker and org.hibernate.loader.custom.sql.SQLQueryParser.ParameterSubstitutionRecognizer do not have a common superclass |