File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/id/SequenceHiLoGenerator.java | File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/id/TableHiLoGenerator.java | |||
Method name: Serializable generate(SessionImplementor, Object)
|
Method name: Serializable generate(SessionImplementor, Object)
|
|||
Number of AST nodes: 12 | Number of AST nodes: 11 | |||
1 | if (maxLo < 1) {↵ | 1 | if (maxLo < 1) {↵ | |
2 | //keep the behavior consistent even for boundary usages↵ | 2 | //keep the behavior consistent even for boundary usages↵ | |
3 | long val = ( (Number) super.generate(session, obj) ).longValue();↵ | 3 | long val = ( (Number) super.generate(session, obj) ).longValue();↵ | |
4 | if (val == 0) val = ( (Number) super.generate(session, obj) ).longValue();↵ | 4 | if (val == 0) val = ( (Number) super.generate(session, obj) ).longValue();↵ | |
5 | return IdentifierGeneratorFactory.createNumber( val, returnClass );↵ | 5 | return IdentifierGeneratorFactory.createNumber( val, returnClass );↵ | |
6 | }↵ | 6 | }↵ | |
7 | if ( lo>maxLo ) {↵ | 7 | if (lo>maxLo) {↵ | |
8 | long hival = ( (Number) super.generate(session, obj) ).longValue();↵ | 8 | long hival = ( (Number) super.generate(session, obj) ).longValue();↵ | |
9 | lo = (hival == 0) ? 1 : 0;↵ | 9 | lo = (hival == 0) ? 1 : 0;↵ | |
10 | hi = hival * ( maxLo+1 );↵ | 10 | hi = hival * (maxLo+1);↵ | |
11 | if ( log.isDebugEnabled() )↵ | 11 | ↵ | |
12 | log.debug("new hi value: " + hival);↵ | 12 | log.debug("new hi value: " + hival);↵ | |
13 | }↵ | 13 | }↵ | |
14 | return IdentifierGeneratorFactory.createNumber( hi + lo++, returnClass ); | 14 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.3 |
Clones location | Clones are in different classes |
Number of node comparisons | 30 |
Number of mapped statements | 10 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 4.0 |
Clone type | Type 3 |
ID | Statement | ID | Statement | |||||||
---|---|---|---|---|---|---|---|---|---|---|
1 | if (maxLo < 1) | 1 | if (maxLo < 1) | |||||||
2 | long val = ((Number)super.generate(session, obj)).longValue(); |
| 2 | long val = ((Number)super.generate(session, obj)).longValue(); | ||||||
3 | if (val == 0) | 3 | if (val == 0) | |||||||
4 | val = ((Number)super.generate(session, obj)).longValue(); |
| 4 | val = ((Number)super.generate(session, obj)).longValue(); | ||||||
5 | return IdentifierGeneratorFactory.createNumber(val, returnClass); | 5 | return IdentifierGeneratorFactory.createNumber(val, returnClass); | |||||||
6 | if (lo > maxLo) | 6 | if (lo > maxLo) | |||||||
7 | long hival = ((Number)super.generate(session, obj)).longValue(); |
| 7 | long hival = ((Number)super.generate(session, obj)).longValue(); | ||||||
8 | lo = (hival == 0) ? 1 : 0; | 8 | lo = (hival == 0) ? 1 : 0; | |||||||
9 | hi = hival * (maxLo + 1); | 9 | hi = hival * (maxLo + 1); | |||||||
|
| 10 | log.debug("new hi value: " + hival); | |||||||
10 | if (log.isDebugEnabled()) | | ||||||||
11 | log.debug("new hi value: " + hival); |
| | |||||||
12 | return IdentifierGeneratorFactory.createNumber(hi + lo++, returnClass); | 11 | return IdentifierGeneratorFactory.createNumber(hi + lo++, returnClass); |
Row | Violation |
---|---|
1 | Super method call long val=((Number)super.generate(session,obj)).longValue(); cannot be extracted from method |
2 | Super method call long val=((Number)super.generate(session,obj)).longValue(); cannot be extracted from method |
3 | Super method call val=((Number)super.generate(session,obj)).longValue(); cannot be extracted from method |
4 | Super method call val=((Number)super.generate(session,obj)).longValue(); cannot be extracted from method |
5 | Super method call long hival=((Number)super.generate(session,obj)).longValue(); cannot be extracted from method |
6 | Super method call long hival=((Number)super.generate(session,obj)).longValue(); cannot be extracted from method |
7 | Unmatched statement log.debug("new hi value: " + hival); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
8 | Unmatched statement log.debug("new hi value: " + hival); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
9 | The refactoring of the clones is infeasible, because classes org.hibernate.id.SequenceHiLoGenerator and org.hibernate.id.TableHiLoGenerator do not have a common superclass |