File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/cfg/ImprovedNamingStrategy.java | File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/persister/collection/AbstractCollectionPersister.java | |||
Method name: String foreignKeyColumnName(String, String, String, String)
|
Method name: Object readIdentifier(ResultSet, String, SessionImplementor)
|
|||
Number of AST nodes: 4 | Number of AST nodes: 4 | |||
1 | String header = propertyName != null ? StringHelper.unqualify( propertyName ) : propertyTableName;↵ | 1 | Object id = getIdentifierType().nullSafeGet( rs, alias, session, null );↵ | |
2 | if (header == null) ↵ | 2 | if ( id == null ) {↵ | |
3 | throw new AssertionFailure("NamingStrategy not properly filled");↵ | 3 | throw new ↵ | |
4 | return columnName( header )↵ | 4 | HibernateException( "null identifier column for collection: " + role );↵ | |
5 | }↵ | |||
5 | ; | 6 | return id; | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2 |
Clones location | Clones are in different classes |
Number of node comparisons | 8 |
Number of mapped statements | 2 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 2.0 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1 | Object id = getIdentifierType().nullSafeGet(rs, alias, session, null); | ||||||||||||||||
1 | String header = propertyName != null ? StringHelper.unqualify(propertyName) : propertyTableName; | | ||||||||||||||||
2 | if (header == null) |
| 2 | if (id == null) | ||||||||||||||
3 | throw new AssertionFailure("NamingStrategy not properly filled"); |
| 3 | throw new HibernateException("null identifier column for collection: " + role); | ||||||||||||||
|
| 4 | return id; | |||||||||||||||
4 | return columnName(header); |
| |
Row | Violation |
---|---|
1 | Type java.lang.String of variable header does not match with type java.lang.Object of variable id |
2 | Unmatched statement return id; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
3 | Unmatched return id; |
4 | Unmatched statement return columnName(header); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
5 | Unmatched return columnName(header); |
6 | The refactoring of the clones is infeasible, because classes org.hibernate.cfg.ImprovedNamingStrategy and org.hibernate.persister.collection.AbstractCollectionPersister do not have a common superclass |