File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/loader/criteria/CriteriaQueryTranslator.java | File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/sql/Update.java | |||
Method name: String getOrderBy()
|
Method name: String toStatementString()
|
|||
Number of AST nodes: 4 | Number of AST nodes: 5 | |||
1 | CriteriaImpl.OrderEntry oe = ( CriteriaImpl.OrderEntry ) criterionIterator.next();↵ | 1 | final Map.Entry e = (Map.Entry) iter.next();↵ | |
2 | orderBy.append( oe.getOrder().toSqlString↵ | 2 | if ( conditionsAppended ) {↵ | |
3 | buf.append( " and " );↵ | |||
4 | }↵ | |||
3 | ( oe.getCriteria(), this ) );↵ | 5 | buf.append( e.getKey() ).append( e.get↵ | |
4 | if ( criterionIterator.hasNext() ) {↵ | |||
5 | orderBy.append( ", " );↵ | |||
6 | } | 6 | Value() );↵ | |
7 |
| |||
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.1 |
Clones location | Clones are in different classes |
Number of node comparisons | 11 |
Number of mapped statements | 2 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 3 |
Time elapsed for statement mapping (ms) | 1.7 |
Clone type | Type 3 |
ID | Statement | ID | Statement | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
4 | CriteriaImpl.OrderEntry oe = (CriteriaImpl.OrderEntry)criterionIterator.next(); | | |||||||||||||||
5 | orderBy.append(oe.getOrder().toSqlString(oe.getCriteria(), this)); | | |||||||||||||||
| 30 | final Map.Entry e = (Map.Entry)iter.next(); | |||||||||||||||
6 | if (criterionIterator.hasNext()) |
| 31 | if (conditionsAppended) | |||||||||||||
7 | orderBy.append(", "); |
| 32 | buf.append(" and "); | |||||||||||||
| 33 | buf.append(e.getKey()).append(e.getValue()); | |||||||||||||||
|
| 34 | conditionsAppended = true; |
Row | Violation |
---|---|
1 | Expression conditionsAppended cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Unmatched statement conditionsAppended=true; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |