File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/collection/PersistentList.java | File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/collection/PersistentSet.java | |||
Method name: boolean remove(Object)
|
Method name: boolean add(Object)
|
|||
Number of AST nodes: 11 | Number of AST nodes: 11 | |||
1 | Boolean exists = isPutQueueEnabled() ? readElementExistence(value) : null;↵ | 1 | Boolean exists = isOperationQueueEnabled() ? readElementExistence( value ) : null;↵ | |
2 | if ( exists == null ) {↵ | 2 | if ( exists == null ) {↵ | |
3 | initialize( true );↵ | 3 | initialize( true );↵ | |
4 | if ( list.remove( value ) ) {↵ | 4 | if ( set.add( value ) ) {↵ | |
5 | dirty();↵ | 5 | dirty();↵ | |
6 | return true;↵ | 6 | return true;↵ | |
7 | }↵ | 7 | }↵ | |
8 | else {↵ | 8 | else {↵ | |
9 | return false;↵ | 9 | return false;↵ | |
10 | }↵ | 10 | }↵ | |
11 | }↵ | 11 | }↵ | |
12 | else if ( exists.booleanValue() ) {↵ | 12 | else if ( exists.booleanValue() ) {↵ | |
13 | ↵ | 13 | return false;↵ | |
14 | }↵ | |||
15 | else {↵ | |||
14 | queueOperation( new SimpleRemove(value) );↵ | 16 | queueOperation( new SimpleAdd(value) );↵ | |
15 | return true;↵ | 17 | return true;↵ | |
16 | }↵ | 18 |
| |
17 | else {↵ | |||
18 | return false;↵ | |||
19 | } | |||
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 1 |
Number of non-refactorable cases | 0 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.5 |
Clones location | Clones are in different classes having the same super class |
Number of node comparisons | 37 |
Number of mapped statements | 10 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 20.7 |
Clone type | Type 3 |
ID | Statement | ID | Statement | |||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | Boolean exists = isPutQueueEnabled() ? readElementExistence(value) : null; |
| 1 | Boolean exists = isOperationQueueEnabled() ? readElementExistence(value) : null; | ||||||||||||||||
2 | if (exists == null) | 2 | if (exists == null) | |||||||||||||||||
3 | initialize(true); | 3 | initialize(true); | |||||||||||||||||
4 | if (list.remove(value)) |
| 4 | if (set.add(value)) | ||||||||||||||||
5 | dirty(); | 5 | dirty(); | |||||||||||||||||
6 | return true; | 6 | return true; | |||||||||||||||||
else | else | |||||||||||||||||||
7 | return false; | 7 | return false; | |||||||||||||||||
8 | else if (exists.booleanValue()) | 8 | else if (exists.booleanValue()) | |||||||||||||||||
9 | queueOperation(new SimpleRemove(value)); |
| | |||||||||||||||||
10 | return true; |
| 9 | return false; | ||||||||||||||||
else | else | |||||||||||||||||||
|
| 10 | queueOperation(new SimpleAdd(value)); | |||||||||||||||||
11 | return false; |
| 11 | return true; |
Row | Violation |
---|---|
1 | Expression isPutQueueEnabled() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression isOperationQueueEnabled() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Unmatched statement queueOperation(new SimpleRemove(value)); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
4 | Unmatched statement queueOperation(new SimpleAdd(value)); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |