File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/ldap/sampler/LdapClient.java | File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/jdbc/sampler/JDBCSampler.java | |||
Method name: void disconnect()
|
Method name: void close(ResultSet)
|
|||
Number of AST nodes: 4 | Number of AST nodes: 3 | |||
1 | try {↵ | 1 | try {↵ | |
2 | if (dirContext != null) {↵ | 2 | if (rs != null) {↵ | |
3 | dirContext.close();↵ | 3 | rs.close();↵ | |
4 | dirContext = null;↵ | 4 | ↵ | |
5 | }↵ | 5 | }↵ | |
6 | } catch (NamingException e) {↵ | 6 | } catch (SQLException e) {↵ | |
7 | log.error("Ldap client - ", e);↵ | 7 | log.warn("Error closing ResultSet", e);↵ | |
8 | } | 8 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.5 |
Clones location | Clones are in different classes |
Number of node comparisons | 7 |
Number of mapped statements | 3 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 1.9 |
Clone type | Type 3 |
ID | Statement | ID | Statement | |||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | try |
| 1 | try | ||||||||||||||||||||||||||
2 | if (dirContext != null) |
| 2 | if (rs != null) | ||||||||||||||||||||||||||
3 | dirContext.close(); |
| 3 | rs.close(); | ||||||||||||||||||||||||||
4 | dirContext = null; |
| |
Row | Violation |
---|---|
1 | Expression log.error("Ldap client - ",e) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression log.warn("Error closing ResultSet",e) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Expression log.error("Ldap client - ",e) is a void method call, and thus it cannot be parameterized |
4 | Expression log.warn("Error closing ResultSet",e) is a void method call, and thus it cannot be parameterized |
5 | Type javax.naming.directory.DirContext of variable dirContext does not match with type java.sql.ResultSet of variable rs |
6 | Type javax.naming.directory.DirContext of variable dirContext does not match with type java.sql.ResultSet of variable rs |
7 | Unmatched statement dirContext=null; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |