try { if (dirContext != null) { dirContext.close(); dirContext = null; } } catch (NamingException e) { log.error("Ldap client - ", e); }
try { if (s != null) { s.close(); } } catch (SQLException e) { log.warn("Error closing Statement " + s.toString(), e); }
Clone fragments detected by clone detection tool
File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/ldap/sampler/LdapClient.java File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/jdbc/sampler/JDBCSampler.java
Method name: void disconnect() Method name: void close(Statement)
Number of AST nodes: 4 Number of AST nodes: 3
1
try {
1
try {
2
			if (dirContext != null) {
2
			if (s != null) {
3
				dirContext.close();
3
			
4
				dirContext = null;
4
    s.close();
5
			}
5
			}
6
		} catch (NamingException e) {
6
		} catch (SQLException e) {
7
			log.error("Ldap client - ", e);
7
			log.warn("Error closing Statement " + s.toString(), e);
8
		}
8
		}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.5
Clones locationClones are in different classes
Number of node comparisons7
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements3
    Number of unmapped statements in the first code fragment1
    Number of unmapped statements in the second code fragment0
    Time elapsed for statement mapping (ms)2.1
    Clone typeType 3
    Mapped Statements
    ID Statement ID Statement
    1
    try
    1
    try
    1
    try
    Differences
    Expression1Expression2Difference
    javax.naming.NamingExceptionjava.sql.SQLExceptionSUBCLASS_TYPE_MISMATCH
    javax.naming.NamingExceptionjava.sql.SQLExceptionSUBCLASS_TYPE_MISMATCH
    "Ldap client - ""Error closing Statement " + s.toString()TYPE_COMPATIBLE_REPLACEMENT
    javax.naming.NamingExceptionjava.sql.SQLExceptionSUBCLASS_TYPE_MISMATCH
    errorwarnMETHOD_INVOCATION_NAME_MISMATCH
    Preondition Violations
    Expression log.error("Ldap client - ",e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression log.warn("Error closing Statement " + s.toString(),e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression log.error("Ldap client - ",e) is a void method call, and thus it cannot be parameterized
    Expression log.warn("Error closing Statement " + s.toString(),e) is a void method call, and thus it cannot be parameterized
    1
    try
    2
    if (dirContext != null)
    2
    if (dirContext != null)
    2
    if (s != null)
    Differences
    Expression1Expression2Difference
    dirContextsVARIABLE_NAME_MISMATCH
    javax.naming.directory.DirContextjava.sql.StatementVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type javax.naming.directory.DirContext of variable dirContext does not match with type java.sql.Statement of variable s
    • Make classes javax.naming.directory.DirContext and java.sql.Statement extend a common superclass
    2
    if (s != null)
    3
    dirContext.close();
    3
    dirContext.close();
    3
    s.close();
    Differences
    Expression1Expression2Difference
    dirContextsVARIABLE_NAME_MISMATCH
    javax.naming.directory.DirContextjava.sql.StatementVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type javax.naming.directory.DirContext of variable dirContext does not match with type java.sql.Statement of variable s
    • Make classes javax.naming.directory.DirContext and java.sql.Statement extend a common superclass
    3
    s.close();
    4
    dirContext = null;
    4
    dirContext = null;
    Preondition Violations
    Unmatched statement dirContext=null; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
                                          
    Precondition Violations (7)
    Row Violation
    1Expression log.error("Ldap client - ",e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    2Expression log.warn("Error closing Statement " + s.toString(),e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    3Expression log.error("Ldap client - ",e) is a void method call, and thus it cannot be parameterized
    4Expression log.warn("Error closing Statement " + s.toString(),e) is a void method call, and thus it cannot be parameterized
    5Type javax.naming.directory.DirContext of variable dirContext does not match with type java.sql.Statement of variable s
    6Type javax.naming.directory.DirContext of variable dirContext does not match with type java.sql.Statement of variable s
    7Unmatched statement dirContext=null; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted