File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/http/util/accesslog/SessionFilter.java | File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/jms/client/ConnectionFactory.java | |||
Method name: CookieManager getCookieManager(String)
|
Method name: TopicConnection getTopicConnection()
|
|||
Number of AST nodes: 2 | Number of AST nodes: 3 | |||
1 | try {↵ | |||
2 | managersInUse.wait();↵ | |||
3 | } catch (InterruptedException e) {↵ | |||
4 | log.info("SessionFilter wait interrupted");↵ | |||
5 | ↵ | 1 | if (factory != null) {↵ | |
2 | try {↵ | |||
3 | return factory.createTopicConnection();↵ | |||
4 | } catch (JMSException e) {↵ | |||
5 | log.error(e.getMessage());↵ | |||
6 | }↵ | |||
6 | } | 7 | } | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.3 |
Clones location | Clones are in different classes |
Number of node comparisons | 5 |
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 1.2 |
Clone type | Type 2 |
ID | Statement | ID | Statement | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
14 | try |
| 2 | try | |||||||||||||||||||||||
|
| 3 | return factory.createTopicConnection(); | ||||||||||||||||||||||||
15 | managersInUse.wait(); |
| |
Row | Violation |
---|---|
1 | Expression e.getMessage() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression log.error(e.getMessage()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Expression log.info("SessionFilter wait interrupted") is a void method call, and thus it cannot be parameterized |
4 | Expression log.error(e.getMessage()) is a void method call, and thus it cannot be parameterized |
5 | Unmatched statement return factory.createTopicConnection(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |
6 | Unmatched return factory.createTopicConnection(); |
7 | Unmatched statement managersInUse.wait(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |
8 | The refactoring of the clones is infeasible, because classes org.apache.jmeter.protocol.http.util.accesslog.SessionFilter and org.apache.jmeter.protocol.jms.client.ConnectionFactory do not have a common superclass |