File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/jms/client/ConnectionFactory.java | File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/jms/client/ConnectionFactory.java | |||
Method name: QueueConnection getQueueConnection(Context, String)
|
Method name: TopicConnection getTopicConnection()
|
|||
Number of AST nodes: 3 | Number of AST nodes: 3 | |||
1 | if (factory != null) {↵ | 1 | if (factory != null) {↵ | |
2 | try {↵ | 2 | try {↵ | |
3 | return qfactory.createQueueConnection();↵ | 3 | return factory.createTopicConnection();↵ | |
4 | } catch (JMSException e) {↵ | 4 | } catch (JMSException e) {↵ | |
5 | log.error(e.getMessage());↵ | 5 | log.error(e.getMessage());↵ | |
6 | }↵ | 6 | }↵ | |
7 | } | 7 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.3 |
Clones location | Clones are declared in the same class |
Number of node comparisons | 5 |
Number of mapped statements | 3 |
Number of unmapped statements in the first code fragment | 0 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 1.4 |
Clone type | Type 2 |
ID | Statement | ID | Statement | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | if (factory != null) | 1 | if (factory != null) | ||||||||||||||||||||
2 | try | 2 | try | ||||||||||||||||||||
3 | return qfactory.createQueueConnection(); |
| 3 | return factory.createTopicConnection(); |
Row | Violation |
---|---|
1 | Expression qfactory.createQueueConnection() is a method call throwing exception(s) that should be caught by a try block that will be extracted |
2 | Expression factory.createTopicConnection() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Expression qfactory cannot be unified with expression factory , because common superclass javax.jms.ConnectionFactory does not declare member(s) public abstract javax.jms.QueueConnection createQueueConnection() throws javax.jms.JMSException, public abstract javax.jms.TopicConnection createTopicConnection() throws javax.jms.JMSException |
4 | Not all possible execution flows end in a return statement |