File path: /jfreechart-1.0.10/src/org/jfree/data/time/Month.java | File path: /jfreechart-1.0.10/src/org/jfree/data/time/Quarter.java | |||
Method name: boolean equals(Object)
|
Method name: boolean equals(Object)
|
|||
Number of AST nodes: 6 | Number of AST nodes: 6 | |||
1 | if (obj != null) {↵ | 1 | if (obj != null) {↵ | |
2 | if (obj instanceof Month) {↵ | 2 | if (obj instanceof Quarter) {↵ | |
3 | Month target = (Month) obj;↵ | 3 | Quarter target = (Quarter) obj;↵ | |
4 | return (this.month == target.getMonth() ↵ | 4 | return (this.quarter == target.getQuarter()↵ | |
5 | && (this.year == target.getYearValue()));↵ | 5 | && (this.year == target.getYearValue()));↵ | |
6 | }↵ | 6 | }↵ | |
7 | else {↵ | 7 | else {↵ | |
8 | return false;↵ | 8 | return false;↵ | |
9 | }↵ | 9 | }↵ | |
10 | }↵ | 10 | }↵ | |
11 | else {↵ | 11 | else {↵ | |
12 | return false;↵ | 12 | return false;↵ | |
13 | } | 13 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.3 |
Clones location | Clones are in different classes having the same super class |
Number of node comparisons | 20 |
Number of mapped statements | 5 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 3.0 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | if (obj != null) | 1 | if (obj != null) | |||||||||||||||||||
2 | if (obj instanceof Month) |
| 2 | if (obj instanceof Quarter) | ||||||||||||||||||
3 | Month target = (Month)obj; |
| 3 | Quarter target = (Quarter)obj; | ||||||||||||||||||
|
| 4 | return (this.quarter == target.getQuarter() && (this.year == target.getYearValue())); | |||||||||||||||||||
4 | return (this.month == target.getMonth() && (this.year == target.getYearValue())); |
| | |||||||||||||||||||
else | else | |||||||||||||||||||||
5 | return false; | 5 | return false; | |||||||||||||||||||
else | else | |||||||||||||||||||||
6 | return false; | 6 | return false; |
Row | Violation |
---|---|
1 | Expression obj instanceof Month cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression obj instanceof Quarter cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Expression (Month)obj cannot be parameterized, because it has dependencies to/from statements that will be extracted |
4 | Expression (Quarter)obj cannot be parameterized, because it has dependencies to/from statements that will be extracted |
5 | Unmatched statement return (this.quarter == target.getQuarter() && (this.year == target.getYearValue())); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
6 | Unmatched return (this.quarter == target.getQuarter() && (this.year == target.getYearValue())); |
7 | Unmatched statement return (this.month == target.getMonth() && (this.year == target.getYearValue())); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
8 | Unmatched return (this.month == target.getMonth() && (this.year == target.getYearValue())); |
9 | Clone fragment #1 returns variable target with type org.jfree.data.time.Month , while Clone fragment #2 returns variable target with type org.jfree.data.time.Quarter |
10 | Not all possible execution flows end in a return statement |