if (info != null) {
EntityCollection entities
= info.getOwner().getEntityCollection();
if (entities != null) {
String tip = null;
PieToolTipGenerator tipster = getToolTipGenerator();
if (tipster != null) {
// @mgs: using the method's return value was missing
tip = tipster.generateToolTip(dataset, currentKey);
}
String url = null;
if (getURLGenerator() != null) {
url = getURLGenerator().generateURL(dataset, currentKey,
getPieIndex());
}
PieSectionEntity entity = new PieSectionEntity(
upperArc, dataset, getPieIndex(), sectionIndex,
currentKey, tip, url);
entities.add(entity);
}
}
if (entityArea == null) {
entityArea = line.getBounds();
}
String tip = null;
XYToolTipGenerator generator = getToolTipGenerator(series, item);
if (generator != null) {
tip = generator.generateToolTip(dataset, series, item);
}
String url = null;
if (getURLGenerator() != null) {
url = getURLGenerator().generateURL(dataset, series, item);
}
XYItemEntity entity = new XYItemEntity(entityArea, dataset, series,
item, tip, url);
entities.add(entity);
Clone fragments detected by clone detection tool
File path: /jfreechart-1.0.10/src/org/jfree/chart/plot/PiePlot3D.java
|
|
File path: /jfreechart-1.0.10/src/org/jfree/chart/renderer/xy/YIntervalRenderer.java
|
Method name: void draw(Graphics2D, Rectangle2D, Point2D, PlotState, PlotRenderingInfo)
|
|
Method name: void drawItem(Graphics2D, XYItemRendererState, Rectangle2D, PlotRenderingInfo, XYPlot, ValueAxis, ValueAxis, XYDataset, int, int, CrosshairState, int)
|
Number of AST nodes: 12
|
|
Number of AST nodes: 11
|
|
1 | if (info != null) {↵ | | 1 | if (entityArea == null) {↵
|
2 | EntityCollection entities ↵ | | 2 | entity↵
|
3 | = info.getOwner().getEntityCollection();↵ | | 3 | Area = lin↵
|
4 | if (entities != null) {↵ | | |
|
5 | ↵ | | 4 | e.getBounds();↵
|
| | | 5 | }↵
|
6 | String tip = null;↵ | | 6 | String tip = null;↵
|
7 | PieToolTipGenerator tipster = getToolTipGenerator();↵ | | 7 | XYToolTipGenerator generator = getToolTipGenerator(↵
|
8 | ↵ | | 8 | series, item);↵
|
9 | if (tipster != null) {↵ | | 9 | if (generator != null) {↵
|
10 | // @mgs: using the method's return value was missing ↵ | | 10 | ↵
|
11 | tip = tipster.generateToolTip(dataset, currentKey);↵ | | 11 | tip = generator.generateToolTip(dataset, series, item);↵
|
12 | }↵ | | 12 | ↵
|
13 | ↵ | | 13 | }↵
|
14 | String url = null;↵ | | 14 | String url = null;↵
|
15 | if (getURLGenerator() != null) {↵ | | 15 | if (getURLGenerator() != null) {↵
|
16 | url = getURLGenerator().generateURL(dataset, currentKey,↵ | | 16 | url = getURLGenerator().generateURL(dataset, ↵
|
17 | getPieIndex());↵ | | |
|
18 | ↵ | | 17 | series, item);↵
|
19 | }↵ | | 18 | }↵
|
20 | PieSectionEntity entity = new PieSectionEntity(↵ | | 19 | XYItemEntity entity = new ↵
|
21 | upperArc, dataset, getPieIndex(), sectionIndex, ↵ | | 20 | XYItemEntity(entityArea, dataset, series,↵
|
22 | currentKey, tip, url);↵ | | 21 | item, tip, url);↵
|
23 | entities.add(entity);↵ | | 22 | entities.add(entity);
|
24 | }↵ | | | |
25 | } | | | |
See real code fragment |
|
See real code fragment |
Summary
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.6 |
Clones location | Clones are in different classes |
Number of node comparisons | 22 |
-
{Non-refactorable}
Mapping Summary
Number of mapped statements | 3 |
Number of unmapped statements in the first code fragment | 4 |
Number of unmapped statements in the second code fragment | 4 |
Time elapsed for statement mapping (ms) | 77.8 |
Clone type | Type 2 |
Mapped Statements
ID |
Statement |
|
ID |
Statement |
199 | String tip = null; | | 40 | String tip = null; |
| | | 41 | XYToolTipGenerator generator = getToolTipGenerator(series, item); |
200 | PieToolTipGenerator tipster = getToolTipGenerator(); | | | |
201 | if (tipster != null) | | 42 | if (generator != null) |
| | | 43 | tip = generator.generateToolTip(dataset, series, item); |
202 | tip = tipster.generateToolTip(dataset, currentKey); | | | |
| | | 44 | String url = null; |
203 | String url = null; | | | |
204 | if (getURLGenerator() != null) | | 45 | if (getURLGenerator() != null) |
| | | 46 | url = getURLGenerator().generateURL(dataset, series, item); |
205 | url = getURLGenerator().generateURL(dataset, currentKey, getPieIndex()); | | | |
Precondition Violations (7)
Row |
Violation |
1 | Unmatched statement PieToolTipGenerator tipster=getToolTipGenerator(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Type org.jfree.chart.labels.PieToolTipGenerator of variable tipster does not match with type org.jfree.chart.labels.XYToolTipGenerator of variable generator |
3 | Unmatched statement tip=generator.generateToolTip(dataset,series,item); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
4 | Unmatched statement tip=generator.generateToolTip(dataset,series,item); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |
5 | Unmatched statement tip=tipster.generateToolTip(dataset,currentKey); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
6 | Type org.jfree.chart.urls.PieURLGenerator of variable getURLGenerator() does not match with type org.jfree.chart.urls.XYURLGenerator of variable getURLGenerator() |
7 | The refactoring of the clones is infeasible, because classes org.jfree.chart.plot.PiePlot3D and org.jfree.chart.renderer.xy.YIntervalRenderer do not have a common superclass |