if (obj == this) { return true; } if (!(obj instanceof TimeSeriesURLGenerator)) { return false; } TimeSeriesURLGenerator that = (TimeSeriesURLGenerator) obj; if (!this.dateFormat.equals(that.dateFormat)) { return false; } if (!this.itemParameterName.equals(that.itemParameterName)) { return false; } if (!this.prefix.equals(that.prefix)) { return false; } if (!this.seriesParameterName.equals(that.seriesParameterName)) { return false; } return true;
if (obj == this) { return true; } if (!(obj instanceof TimeTableXYDataset)) { return false; } TimeTableXYDataset that = (TimeTableXYDataset) obj; if (this.domainIsPointsInTime != that.domainIsPointsInTime) { return false; } if (this.xPosition != that.xPosition) { return false; } if (!this.workingCalendar.getTimeZone().equals( that.workingCalendar.getTimeZone()) ) { return false; } if (!this.values.equals(that.values)) { return false; } return true;
Clone fragments detected by clone detection tool
File path: /jfreechart-1.0.10/src/org/jfree/chart/urls/TimeSeriesURLGenerator.java File path: /jfreechart-1.0.10/src/org/jfree/data/time/TimeTableXYDataset.java
Method name: boolean equals(Object) Method name: boolean equals(Object)
Number of AST nodes: 14 Number of AST nodes: 14
1
if (obj == this) {
1
if (obj == this) {
2
            return true;
2
            return true;
3
        }
3
        }
4
        if (!(obj instanceof TimeSeriesURLGenerator)) {
4
        if (!(obj instanceof TimeTableXYDataset)) {
5
            return false;
5
            return false;
6
        }
6
        }
7
        TimeSeriesURLGenerator that = (TimeSeriesURLGenerator) obj;
7
        TimeTableXYDataset that = (TimeTableXYDataset) obj;
8
        if (!this.dateFormat.equals(that.dateFormat)) {
8
        if (this.domainIsPointsInTime != that.domainIsPointsInTime) {
9
            return false;
9
            return false;
10
        }
10
        }
11
        if (!this.itemParameterName.equals(that.itemParameterName)) {
11
        if (this.xPosition != that.xPosition) {
12
            return false;
12
            return false;
13
        }
13
        }
14
        if (!this.prefix.equals(that.prefix)
14
        if (!this.workingCalendar.getTimeZone().equals(
15
            that.workingCalendar.getTimeZone())
15
) {
16
        ) {
16
            return false;
17
            return false;
17
        }
18
        }
18
        if (!this.seriesParameterName.equals(that.seriesParameterName)) {
19
        if (!this.values.equals(that.values)) {
19
            return false;
20
            return false;
20
        }
21
        }
21
        return true;
22
        return true;
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)3.4
Clones locationClones are in different classes
Number of node comparisons52
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements6
    Number of unmapped statements in the first code fragment1
    Number of unmapped statements in the second code fragment7
    Time elapsed for statement mapping (ms)2.2
    Clone typeType 3
    Mapped Statements
    ID Statement ID Statement
    1
    if (obj == this)
    1
    if (obj == this)
    2
    return true;
    2
    return true;
    3
    if (!(obj instanceof TimeSeriesURLGenerator))
    3
    if (!(obj instanceof TimeSeriesURLGenerator))
    3
    if (!(obj instanceof TimeTableXYDataset))
    Differences
    Expression1Expression2Difference
    org.jfree.chart.urls.TimeSeriesURLGeneratororg.jfree.data.time.TimeTableXYDatasetVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.jfree.chart.urls.TimeSeriesURLGenerator does not match with type org.jfree.data.time.TimeTableXYDataset
    • Make classes org.jfree.chart.urls.TimeSeriesURLGenerator and org.jfree.data.time.TimeTableXYDataset extend a common superclass
    3
    if (!(obj instanceof TimeTableXYDataset))
    4
    return false;
    4
    return false;
                                                                                                          
    5
    TimeTableXYDataset that = (TimeTableXYDataset)obj;
    5
    TimeSeriesURLGenerator that = (TimeSeriesURLGenerator)obj;
                                                                                                                          
                                                                                                                              
    6
    if (this.domainIsPointsInTime != that.domainIsPointsInTime)
                                    
    7
    return false;
    Preondition Violations
    Unmatched return false;
    7
    return false;
                                                                                  
    8
    if (this.xPosition != that.xPosition)
                                    
    9
    return false;
    Preondition Violations
    Unmatched return false;
    9
    return false;
                                                                                                                                                                                
    10
    if (!this.workingCalendar.getTimeZone().equals(that.workingCalendar.getTimeZone()))
    Preondition Violations
    Unmatched statement if(!this.workingCalendar.getTimeZone().equals(that.workingCalendar.getTimeZone())) cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    10
    if (!this.workingCalendar.getTimeZone().equals(that.workingCalendar.getTimeZone()))
                                      
    11
    return false;
    Preondition Violations
    Unmatched return false;
    11
    return false;
    6
    if (!this.dateFormat.equals(that.dateFormat))
    6
    if (!this.dateFormat.equals(that.dateFormat))
    12
    if (!this.values.equals(that.values))
    Differences
    Expression1Expression2Difference
    org.jfree.chart.urls.TimeSeriesURLGeneratororg.jfree.data.time.TimeTableXYDatasetVARIABLE_TYPE_MISMATCH
    dateFormatvaluesVARIABLE_NAME_MISMATCH
    java.text.DateFormatorg.jfree.data.DefaultKeyedValues2DVARIABLE_TYPE_MISMATCH
    dateFormatvaluesVARIABLE_NAME_MISMATCH
    java.text.DateFormatorg.jfree.data.DefaultKeyedValues2DVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type java.text.DateFormat of variable that.dateFormat does not match with type org.jfree.data.DefaultKeyedValues2D of variable that.values
    • Make classes org.jfree.chart.urls.TimeSeriesURLGenerator and org.jfree.data.time.TimeTableXYDataset extend a common superclass
    Expression that.dateFormat cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression that.values cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Type java.text.DateFormat of variable that.dateFormat does not match with type org.jfree.data.DefaultKeyedValues2D of variable that.values
    • Make classes java.text.DateFormat and org.jfree.data.DefaultKeyedValues2D extend a common superclass
    Type java.text.DateFormat of variable this.dateFormat does not match with type org.jfree.data.DefaultKeyedValues2D of variable this.values
    • Make classes java.text.DateFormat and org.jfree.data.DefaultKeyedValues2D extend a common superclass
    12
    if (!this.values.equals(that.values))
    7
    return false;
    13
    return false;
    Precondition Violations (12)
    Row Violation
    1Type org.jfree.chart.urls.TimeSeriesURLGenerator does not match with type org.jfree.data.time.TimeTableXYDataset
    2Unmatched return false;
    3Unmatched return false;
    4Unmatched statement if(!this.workingCalendar.getTimeZone().equals(that.workingCalendar.getTimeZone())) cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    5Unmatched return false;
    6Type java.text.DateFormat of variable that.dateFormat does not match with type org.jfree.data.DefaultKeyedValues2D of variable that.values
    7Expression that.dateFormat cannot be parameterized, because it has dependencies to/from statements that will be extracted
    8Expression that.values cannot be parameterized, because it has dependencies to/from statements that will be extracted
    9Type java.text.DateFormat of variable that.dateFormat does not match with type org.jfree.data.DefaultKeyedValues2D of variable that.values
    10Type java.text.DateFormat of variable this.dateFormat does not match with type org.jfree.data.DefaultKeyedValues2D of variable this.values
    11Not all possible execution flows end in a return statement
    12The refactoring of the clones is infeasible, because classes org.jfree.chart.urls.TimeSeriesURLGenerator and org.jfree.data.time.TimeTableXYDataset do not have a common superclass