if (entities != null) { String tip = null; PieToolTipGenerator tipster = getToolTipGenerator(); if (tipster != null) { // @mgs: using the method's return value was missing tip = tipster.generateToolTip(dataset, currentKey); } String url = null; if (getURLGenerator() != null) { url = getURLGenerator().generateURL(dataset, currentKey, getPieIndex()); } PieSectionEntity entity = new PieSectionEntity( upperArc, dataset, getPieIndex(), sectionIndex, currentKey, tip, url); entities.add(entity); }
String tip = null; XYToolTipGenerator generator = getToolTipGenerator(series, item); if (generator != null) { tip = generator.generateToolTip(dataset, series, item); } String url = null; if (getURLGenerator() != null) { url = getURLGenerator().generateURL(dataset, series, item); } XYItemEntity entity = new XYItemEntity(shape, dataset, series, item, tip, url); entities.add(entity);
Clone fragments detected by clone detection tool
File path: /jfreechart-1.0.10/src/org/jfree/chart/plot/PiePlot3D.java File path: /jfreechart-1.0.10/src/org/jfree/chart/renderer/xy/StackedXYAreaRenderer.java
Method name: void draw(Graphics2D, Rectangle2D, Point2D, PlotState, PlotRenderingInfo) Method name: void drawItem(Graphics2D, XYItemRendererState, Rectangle2D, PlotRenderingInfo, XYPlot, ValueAxis, ValueAxis, XYDataset, int, int, CrosshairState, int)
Number of AST nodes: 10 Number of AST nodes: 9
1
if (entities != null) {
2
                    String tip = null;
1
String tip = null;
3
                    PieToolTipGenerator tipster = getToolTipGenerator();
2
                    XYToolTipGenerator generator
4
                    if (tipster != null) {
3
                    
5
                        // @mgs: using the method's return value was missing 
4
    = getToolTipGenerator(series, item);
5
                    if (generator != null) {
6
                        tip = tipster.generateToolTip(dataset, currentKey);
6
                        tip = generator.generateToolTip(dataset, series, item);
7
                    }
7
                    }
8
                    String url = null;
8
                    String url = null;
9
                    if (getURLGenerator() != null) {
9
                    if (getURLGenerator() != null) {
10
                        url = getURLGenerator().generateURL(dataset, currentKey,
10
                        url = getURLGenerator().generateURL(dataset, series,
11
                                getPieIndex());
11
                                item);
12
                    }
12
                    }
13
                    PieSectionEntity entity = new PieSectionEntity(
13
                    XYItemEntity entity = new 
14
                            upperArc, dataset, getPieIndex(), sectionIndex, 
14
XYItemEntity(shape, dataset,
15
                            currentKey, tip, url);
15
                            series, item, tip, url);
16
                    entities.add(entity);
16
                    entities.add(entity);
17
                }
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.4
Clones locationClones are in different classes
Number of node comparisons28
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements4
    Number of unmapped statements in the first code fragment5
    Number of unmapped statements in the second code fragment5
    Time elapsed for statement mapping (ms)127.7
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    199
    String tip = null;
    88
    String tip = null;
                                                                                                                                        
    89
    XYToolTipGenerator generator = getToolTipGenerator(series, item);
                                            
    92
    String url = null;
    200
    PieToolTipGenerator tipster = getToolTipGenerator();
    200
    PieToolTipGenerator tipster = getToolTipGenerator();
    Preondition Violations
    Unmatched statement PieToolTipGenerator tipster=getToolTipGenerator(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
                                                                                                                  
    201
    if (tipster != null)
    201
    if (tipster != null)
    90
    if (generator != null)
    Differences
    Expression1Expression2Difference
    tipstergeneratorVARIABLE_NAME_MISMATCH
    org.jfree.chart.labels.PieToolTipGeneratororg.jfree.chart.labels.XYToolTipGeneratorVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.jfree.chart.labels.PieToolTipGenerator of variable tipster does not match with type org.jfree.chart.labels.XYToolTipGenerator of variable generator
    • Make classes org.jfree.chart.labels.PieToolTipGenerator and org.jfree.chart.labels.XYToolTipGenerator extend a common superclass
    90
    if (generator != null)
                                                                                                                  
    91
    tip = generator.generateToolTip(dataset, series, item);
    Preondition Violations
    Unmatched statement tip=generator.generateToolTip(dataset,series,item); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    Unmatched statement tip=generator.generateToolTip(dataset,series,item); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    91
    tip = generator.generateToolTip(dataset, series, item);
    202
    tip = tipster.generateToolTip(dataset, currentKey);
    202
    tip = tipster.generateToolTip(dataset, currentKey);
    Preondition Violations
    Unmatched statement tip=tipster.generateToolTip(dataset,currentKey); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
                                                                                                              
    203
    String url = null;
    203
    String url = null;
    Preondition Violations
    Unmatched statement String url=null; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
                                              
    204
    if (getURLGenerator() != null)
    204
    if (getURLGenerator() != null)
    93
    if (getURLGenerator() != null)
    Differences
    Expression1Expression2Difference
    org.jfree.chart.urls.PieURLGeneratororg.jfree.chart.urls.XYURLGeneratorVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.jfree.chart.urls.PieURLGenerator of variable getURLGenerator() does not match with type org.jfree.chart.urls.XYURLGenerator of variable getURLGenerator()
    • Make classes org.jfree.chart.urls.PieURLGenerator and org.jfree.chart.urls.XYURLGenerator extend a common superclass
    93
    if (getURLGenerator() != null)
                                                                                                                          
    94
    url = getURLGenerator().generateURL(dataset, series, item);
    205
    url = getURLGenerator().generateURL(dataset, currentKey, getPieIndex());
                                                                                                                                                      
    206
    PieSectionEntity entity = new PieSectionEntity(upperArc, dataset, getPieIndex(), sectionIndex, currentKey, tip, url);
    206
    PieSectionEntity entity = new PieSectionEntity(upperArc, dataset, getPieIndex(), sectionIndex, currentKey, tip, url);
    95
    XYItemEntity entity = new XYItemEntity(shape, dataset, series, item, tip, url);
    Differences
    Expression1Expression2Difference
    org.jfree.chart.entity.PieSectionEntityorg.jfree.chart.entity.XYItemEntitySUBCLASS_TYPE_MISMATCH
    org.jfree.chart.entity.PieSectionEntityorg.jfree.chart.entity.XYItemEntitySUBCLASS_TYPE_MISMATCH
    org.jfree.chart.entity.PieSectionEntityorg.jfree.chart.entity.XYItemEntitySUBCLASS_TYPE_MISMATCH
    new PieSectionEntity(upperArc,dataset,getPieIndex(),sectionIndex,currentKey,tip,url)new XYItemEntity(shape,dataset,series,item,tip,url)ARGUMENT_NUMBER_MISMATCH
    Preondition Violations
    Expression new PieSectionEntity(upperArc,dataset,getPieIndex(),sectionIndex,currentKey,tip,url) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression new XYItemEntity(shape,dataset,series,item,tip,url) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression new PieSectionEntity(upperArc,dataset,getPieIndex(),sectionIndex,currentKey,tip,url) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression new XYItemEntity(shape,dataset,series,item,tip,url) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    95
    XYItemEntity entity = new XYItemEntity(shape, dataset, series, item, tip, url);
                                                      
    96
    entities.add(entity);
    Preondition Violations
    Unmatched statement entities.add(entity); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    96
    entities.add(entity);
    207
    entities.add(entity);
    207
    entities.add(entity);
    Preondition Violations
    Unmatched statement entities.add(entity); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
                                                        
    Precondition Violations (15)
    Row Violation
    1Unmatched statement PieToolTipGenerator tipster=getToolTipGenerator(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    2Type org.jfree.chart.labels.PieToolTipGenerator of variable tipster does not match with type org.jfree.chart.labels.XYToolTipGenerator of variable generator
    3Unmatched statement tip=generator.generateToolTip(dataset,series,item); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    4Unmatched statement tip=generator.generateToolTip(dataset,series,item); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    5Unmatched statement tip=tipster.generateToolTip(dataset,currentKey); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    6Unmatched statement String url=null; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    7Type org.jfree.chart.urls.PieURLGenerator of variable getURLGenerator() does not match with type org.jfree.chart.urls.XYURLGenerator of variable getURLGenerator()
    8Expression new PieSectionEntity(upperArc,dataset,getPieIndex(),sectionIndex,currentKey,tip,url) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    9Expression new XYItemEntity(shape,dataset,series,item,tip,url) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    10Expression new PieSectionEntity(upperArc,dataset,getPieIndex(),sectionIndex,currentKey,tip,url) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    11Expression new XYItemEntity(shape,dataset,series,item,tip,url) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    12Unmatched statement entities.add(entity); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    13Unmatched statement entities.add(entity); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    14Clone fragment #1 returns variables tip, entity , while Clone fragment #2 returns variables tip, entity
    15The refactoring of the clones is infeasible, because classes org.jfree.chart.plot.PiePlot3D and org.jfree.chart.renderer.xy.StackedXYAreaRenderer do not have a common superclass