File path: /sql12/fw/src/net/sourceforge/squirrel_sql/fw/sql/ResultSetReader.java | File path: /sql12/fw/src/net/sourceforge/squirrel_sql/fw/sql/ResultSetReader.java | |||
Method name: Object readFloat(int)
|
Method name: Object readBigint(int)
|
|||
Number of AST nodes: 7 | Number of AST nodes: 6 | |||
1 | Object result = _rs.getObject(columnIdx);↵ | 1 | Object result = _rs.getObject(columnIdx);↵ | |
2 | if (result != null↵ | 2 | if (result != null↵ | |
3 | && !(result instanceof Double))↵ | 3 | && !(result instanceof Long))↵ | |
4 | {↵ | 4 | {↵ | |
5 | if (result instanceof Number) {↵ | 5 | if (result instanceof Number)↵ | |
6 | Number nbr = (Number) result;↵ | 6 | ↵ | |
7 | result = new Double(nbr.doubleValue());↵ | |||
8 | } else↵ | 7 | {↵ | |
8 | result = Long.valueOf(((Number)result).longValue());↵ | |||
9 | }↵ | |||
10 | else↵ | |||
9 | {↵ | 11 | {↵ | |
10 | result = new Double(result.toString());↵ | 12 | result = Long.valueOf(result.toString());↵ | |
11 | }↵ | 13 | }↵ | |
12 | }↵ | 14 | }↵ | |
13 | return result; | 15 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.6 |
Clones location | Clones are declared in the same class |
Number of node comparisons | 17 |
Number of mapped statements | 6 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 3.1 |
Clone type | Type 3 |
ID | Statement | ID | Statement | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | Object result = _rs.getObject(columnIdx); | 1 | Object result = _rs.getObject(columnIdx); | ||||||||||||||||
2 | if (result != null && !(result instanceof Double)) |
| 2 | if (result != null && !(result instanceof Long)) | |||||||||||||||
3 | if (result instanceof Number) | 3 | if (result instanceof Number) | ||||||||||||||||
4 | Number nbr = (Number)result; |
| | ||||||||||||||||
5 | result = new Double(nbr.doubleValue()); |
| 4 | result = Long.valueOf(((Number)result).longValue()); | |||||||||||||||
else | else | ||||||||||||||||||
6 | result = new Double(result.toString()); |
| 5 | result = Long.valueOf(result.toString()); | |||||||||||||||
7 | return result; | 6 | return result; |
Row | Violation |
---|---|
1 | Expression result instanceof Double cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression result instanceof Long cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Unmatched statement Number nbr=(Number)result; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
4 | Expression new Double(nbr.doubleValue()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
5 | Expression Long.valueOf(((Number)result).longValue()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
6 | Expression new Double(result.toString()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
7 | Expression Long.valueOf(result.toString()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
8 | Clone fragment #1 returns variables result , while Clone fragment #2 returns variables |