File path: /sql12/fw/src/net/sourceforge/squirrel_sql/fw/sql/ResultSetReader.java | File path: /sql12/fw/src/net/sourceforge/squirrel_sql/fw/sql/ResultSetReader.java | |||
Method name: Object readNumeric(int)
|
Method name: Object readFloat(int)
|
|||
Number of AST nodes: 5 | Number of AST nodes: 5 | |||
1 | if (result != null && !(result instanceof BigDecimal)) {↵ | 1 | if (result != null && !(result instanceof Double)) {↵ | |
2 | if (result instanceof Number) {↵ | 2 | if (result instanceof Number) {↵ | |
3 | Number nbr = (Number) result;↵ | 3 | Number nbr = (Number) result;↵ | |
4 | result = new BigDecimal(nbr.doubleValue());↵ | 4 | result = new Double(nbr.doubleValue());↵ | |
5 | } else {↵ | 5 | } else {↵ | |
6 | result = new BigDecimal(result.toString());↵ | 6 | result = new Double(result.toString());↵ | |
7 | }↵ | 7 | }↵ | |
8 | } | 8 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.3 |
Clones location | Clones are declared in the same class |
Number of node comparisons | 17 |
Number of mapped statements | 5 |
Number of unmapped statements in the first code fragment | 0 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 2.8 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
2 | if (result != null && !(result instanceof BigDecimal)) |
| 2 | if (result != null && !(result instanceof Double)) | ||||||||||||
3 | if (result instanceof Number) | 3 | if (result instanceof Number) | |||||||||||||
4 | Number nbr = (Number)result; | 4 | Number nbr = (Number)result; | |||||||||||||
5 | result = new BigDecimal(nbr.doubleValue()); |
| 5 | result = new Double(nbr.doubleValue()); | ||||||||||||
else | else | |||||||||||||||
6 | result = new BigDecimal(result.toString()); |
| 6 | result = new Double(result.toString()); |
Row | Violation |
---|---|
1 | Expression new BigDecimal(nbr.doubleValue()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression new Double(nbr.doubleValue()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Expression new BigDecimal(result.toString()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
4 | Expression new Double(result.toString()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |