File path: /sql12/plugins/firebird/src/org/firebirdsql/squirrel/tab/TriggerDetailsTab.java | File path: /sql12/plugins/firebird/src/org/firebirdsql/squirrel/tab/TriggerSourceTab.java | |||
Method name: PreparedStatement createStatement()
|
Method name: PreparedStatement createStatement()
|
|||
Number of AST nodes: 9 | Number of AST nodes: 9 | |||
1 | ISession session = getSession();↵ | 1 | final ISession session = getSession();↵ | |
2 | ↵ | 2 | final IDatabaseObjectInfo doi = getDatabaseObjectInfo();↵ | |
3 | if (s_log.isDebugEnabled()) {↵ | 3 | if (s_log.isDebugEnabled()) {↵ | |
4 | s_log.debug("Preparing SQL: "+SQL);↵ | 4 | s_log.debug("Preparing ↵ | |
5 | } ↵ | |||
6 | PreparedStatement pstmt↵ | 5 | trigger SQL statement: "+SQL);↵ | |
6 | s_log.debug("trigger name = "+doi.getSimpleName());↵ | |||
7 | }↵ | |||
7 | = session.getSQLConnection().p↵ | 8 | ISQLConnection conn = session.getSQLConnection();↵ | |
8 | repareStatement(SQL);↵ | 9 | PreparedStatement↵ | |
9 | IDatabaseObjectInfo doi = getDatabaseObjectInfo();↵ | |||
10 | if (s_log.isDebugEnabled()) {↵ | |||
11 | s_log.debug("setString param: "+doi.getSimpleName());↵ | |||
12 | } ↵ | |||
13 | ↵ | 10 | pstmt = conn.prepareStatement(SQL);↵ | |
14 | pstmt.setString(1, doi.getSimpleName());↵ | 11 | pstmt.setString(1, doi.getSimpleName());↵ | |
15 | return pstmt; | 12 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.1 |
Clones location | Clones are in different classes having the same super class |
Number of node comparisons | 37 |
Number of mapped statements | 5 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 4 |
Time elapsed for statement mapping (ms) | 71.5 |
Clone type | Type 3 |
ID | Statement | ID | Statement | |||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1 | final ISession session = getSession(); | ||||||||||||||
1 | ISession session = getSession(); | | ||||||||||||||
| 2 | final IDatabaseObjectInfo doi = getDatabaseObjectInfo(); | ||||||||||||||
2 | if (s_log.isDebugEnabled()) | 3 | if (s_log.isDebugEnabled()) | |||||||||||||
3 | s_log.debug("Preparing SQL: " + SQL); |
| 4 | s_log.debug("Preparing trigger SQL statement: " + SQL); | ||||||||||||
|
| 5 | s_log.debug("trigger name = " + doi.getSimpleName()); | |||||||||||||
| 6 | ISQLConnection conn = session.getSQLConnection(); | ||||||||||||||
4 | PreparedStatement pstmt = session.getSQLConnection().prepareStatement(SQL); |
| 7 | PreparedStatement pstmt = conn.prepareStatement(SQL); | ||||||||||||
5 | IDatabaseObjectInfo doi = getDatabaseObjectInfo(); | | ||||||||||||||
8 | pstmt.setString(1, doi.getSimpleName()); | 8 | pstmt.setString(1, doi.getSimpleName()); | |||||||||||||
9 | return pstmt; | 9 | return pstmt; |
Row | Violation |
---|---|
1 | Unmatched statement s_log.debug("trigger name = " + doi.getSimpleName()); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
2 | Expression session.getSQLConnection() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Expression conn cannot be parameterized, because it has dependencies to/from statements that will be extracted |