try { pstmt = conn.prepareStatement(ALL_INDICES_SQL); final ResultSet rs = pstmt.executeQuery(); while (rs.next()) { IDatabaseObjectInfo doi = new DatabaseObjectInfo(null, null, rs.getString(1), DatabaseObjectType.INDEX, md); childNodes.add(new ObjectTreeNode(session, doi)); } } finally { SQLUtilities.closeStatement(pstmt); }
try { pstmt = conn.prepareStatement(SQL); rs = pstmt.executeQuery(); while (rs.next()) { IDatabaseObjectInfo doi = new DatabaseObjectInfo( null, null, rs.getString(1), IObjectTypes.INSTANCE, md); // final Map map = new HashMap(); // map.put("Instance Number", new Integer(rs.getInt(1))); // map.put("Name", rs.getString(2)); // map.put("Host Name", rs.getString(3)); // map.put("Version", rs.getString(4)); // map.put("Startup Time", rs.getDate(5)); // map.put("Instance Status", rs.getString(6)); // map.put("Parallel", rs.getString(7)); // map.put("Thread #", new Integer(rs.getInt(8))); // map.put("Archiver", rs.getString(9)); // map.put("Log Switch Wait", rs.getString(10)); // map.put("Logins", rs.getString(11)); // map.put("Shutdown Pending", rs.getString(12)); // map.put("Database Status", rs.getString(13)); // map.put("Instance Role", rs.getString(14)); childNodes.add(new ObjectTreeNode(session, doi)); } } finally { SQLUtilities.closeResultSet(rs, true); }
Clone fragments detected by clone detection tool
File path: /sql12/plugins/firebird/src/org/firebirdsql/squirrel/exp/AllIndexesParentExpander.java File path: /sql12/plugins/oracle/src/net/sourceforge/squirrel_sql/plugins/oracle/expander/InstanceParentExpander.java
Method name: List createChildren(ISession, ObjectTreeNode) Method name: List createChildren(ISession, ObjectTreeNode)
Number of AST nodes: 6 Number of AST nodes: 6
1
try
1
try
2
        {
3
            
2
		{
4
pstmt = conn.prepareStatement(ALL_INDICES_SQL);
3
			pstmt = conn.prepareStatement(
5
            final ResultSet 
4
SQL);
6
rs = pstmt.executeQuery();
5
			rs = pstmt.executeQuery();
7
            while (rs.next())
6
			while (rs.next())
8
            {
9
                
7
			{
10
IDatabaseObjectInfo doi = new DatabaseObjectInfo(
8
				IDatabaseObjectInfo doi = new DatabaseObjectInfo(
11
null, null,
9
				   null, null,
12
                                            rs.getString(1),
13
                                            DatabaseObjectType.INDEX, md);
14
                
10
 rs.getString(1), IObjectTypes.INSTANCE, md);
11
				// final Map map = new HashMap();
12
				// map.put("Instance Number", new Integer(rs.getInt(1)));
13
				// map.put("Name", rs.getString(2));
14
				// map.put("Host Name", rs.getString(3));
15
				// map.put("Version", rs.getString(4));
16
				// map.put("Startup Time", rs.getDate(5));
17
				// map.put("Instance Status", rs.getString(6));
18
				// map.put("Parallel", rs.getString(7));
19
				// map.put("Thread #", new Integer(rs.getInt(8)));
20
				// map.put("Archiver", rs.getString(9));
21
				// map.put("Log Switch Wait", rs.getString(10));
22
				// map.put("Logins", rs.getString(11));
23
				// map.put("Shutdown Pending", rs.getString(12));
24
				// map.put("Database Status", rs.getString(13));
25
				// map.put("Instance Role", rs.getString(14));
15
childNodes.add(new ObjectTreeNode(session, doi));
26
				childNodes.add(new ObjectTreeNode(session, doi));
16
            }
17
        }
18
        finally
19
        {
20
            
27
			}
28
		} finally
29
		{
21
SQLUtilities.closeStatement(pstmt);
30
			SQLUtilities.close
22
        
31
ResultSet(rs, true);
23
}
32
		}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.5
Clones locationClones are in different classes
Number of node comparisons18
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements7
    Number of unmapped statements in the first code fragment0
    Number of unmapped statements in the second code fragment0
    Time elapsed for statement mapping (ms)19.9
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    5
    try
    5
    try
    6
    try
    Differences
    Expression1Expression2Difference
    closeStatementcloseResultSetMETHOD_INVOCATION_NAME_MISMATCH
    SQLUtilities.closeStatement(pstmt)SQLUtilities.closeResultSet(rs,true)ARGUMENT_NUMBER_MISMATCH
    Preondition Violations
    Expression SQLUtilities.closeStatement(pstmt) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression SQLUtilities.closeResultSet(rs,true) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression SQLUtilities.closeStatement(pstmt) is a void method call, and thus it cannot be parameterized
    Expression SQLUtilities.closeResultSet(rs,true) is a void method call, and thus it cannot be parameterized
    Expression SQLUtilities.closeStatement(pstmt) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression SQLUtilities.closeResultSet(rs,true) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression SQLUtilities.closeStatement(pstmt) is a void method call, and thus it cannot be parameterized
    Expression SQLUtilities.closeResultSet(rs,true) is a void method call, and thus it cannot be parameterized
    6
    try
    6
    pstmt = conn.prepareStatement(ALL_INDICES_SQL);
    6
    pstmt = conn.prepareStatement(ALL_INDICES_SQL);
    7
    pstmt = conn.prepareStatement(SQL);
    Differences
    Expression1Expression2Difference
    ALL_INDICES_SQLSQLVARIABLE_NAME_MISMATCH
    7
    pstmt = conn.prepareStatement(SQL);
    7
    final ResultSet rs = pstmt.executeQuery();
    8
    rs = pstmt.executeQuery();
    8
    while (rs.next())
    9
    while (rs.next())
    9
    IDatabaseObjectInfo doi = new DatabaseObjectInfo(null, null, rs.getString(1), DatabaseObjectType.INDEX, md);
    9
    IDatabaseObjectInfo doi = new DatabaseObjectInfo(null, null, rs.getString(1), DatabaseObjectType.INDEX, md);
    10
    IDatabaseObjectInfo doi = new DatabaseObjectInfo(null, null, rs.getString(1), IObjectTypes.INSTANCE, md);
    Differences
    Expression1Expression2Difference
    net.sourceforge.squirrel_sql.fw.sql.DatabaseObjectTypenet.sourceforge.squirrel_sql.plugins.oracle.IObjectTypesVARIABLE_TYPE_MISMATCH
    INDEXINSTANCEVARIABLE_NAME_MISMATCH
    Preondition Violations
    Type net.sourceforge.squirrel_sql.fw.sql.DatabaseObjectType does not match with type net.sourceforge.squirrel_sql.plugins.oracle.IObjectTypes
    • Make classes net.sourceforge.squirrel_sql.fw.sql.DatabaseObjectType and net.sourceforge.squirrel_sql.plugins.oracle.IObjectTypes extend a common superclass
    10
    IDatabaseObjectInfo doi = new DatabaseObjectInfo(null, null, rs.getString(1), IObjectTypes.INSTANCE, md);
    10
    childNodes.add(new ObjectTreeNode(session, doi));
    11
    childNodes.add(new ObjectTreeNode(session, doi));
    Precondition Violations (9)
    Row Violation
    1Expression SQLUtilities.closeStatement(pstmt) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    2Expression SQLUtilities.closeResultSet(rs,true) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    3Expression SQLUtilities.closeStatement(pstmt) is a void method call, and thus it cannot be parameterized
    4Expression SQLUtilities.closeResultSet(rs,true) is a void method call, and thus it cannot be parameterized
    5Expression SQLUtilities.closeStatement(pstmt) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    6Expression SQLUtilities.closeResultSet(rs,true) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    7Expression SQLUtilities.closeStatement(pstmt) is a void method call, and thus it cannot be parameterized
    8Expression SQLUtilities.closeResultSet(rs,true) is a void method call, and thus it cannot be parameterized
    9Type net.sourceforge.squirrel_sql.fw.sql.DatabaseObjectType does not match with type net.sourceforge.squirrel_sql.plugins.oracle.IObjectTypes