if (waitingForOk) { waitingForOk = false; showUpdateDialog(); }
if (!closed) { close(true); closed = true; }
Clone fragments detected by clone detection tool
File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/update/UpdateControllerImpl.java File path: /sql12/plugins/dataimport/src/com/csvreader/CsvReader.java
Method name: void showDialog() Method name: void close()
Number of AST nodes: 3 Number of AST nodes: 3
1
if (waitingForOk)
1
if (
2
			{
3
				waitingForOk = false;
4
				showUpdateDialog()
2
!closed) {
3
			close(true);
5
;
4
			closed = true;
6
			}
5
		}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons9
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements3
    Number of unmapped statements in the first code fragment0
    Number of unmapped statements in the second code fragment0
    Time elapsed for statement mapping (ms)96.1
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    if (waitingForOk)
    1
    if (waitingForOk)
    1
    if (!closed)
    Differences
    Expression1Expression2Difference
    waitingForOk!closedTYPE_COMPATIBLE_REPLACEMENT
    1
    if (!closed)
    2
    waitingForOk = false;
    2
    waitingForOk = false;
    3
    closed = true;
    Differences
    Expression1Expression2Difference
    waitingForOkclosedVARIABLE_NAME_MISMATCH
    falsetrueLITERAL_VALUE_MISMATCH
    Preondition Violations
    Expression waitingForOk is a field being modified, and thus it cannot be parameterized
    Expression closed is a field being modified, and thus it cannot be parameterized
    3
    closed = true;
    3
    showUpdateDialog();
    3
    showUpdateDialog();
    2
    close(true);
    Differences
    Expression1Expression2Difference
    showUpdateDialogcloseMETHOD_INVOCATION_NAME_MISMATCH
    showUpdateDialog()close(true)ARGUMENT_NUMBER_MISMATCH
    Preondition Violations
    Expression close(true) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    • Inline private method close
    Expression showUpdateDialog() is a void method call, and thus it cannot be parameterized
    Expression close(true) is a void method call, and thus it cannot be parameterized
    Expression close(true) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    • Inline private method close
    Expression showUpdateDialog() is a void method call, and thus it cannot be parameterized
    Expression close(true) is a void method call, and thus it cannot be parameterized
    2
    close(true);
    Precondition Violations (8)
    Row Violation
    1Expression waitingForOk is a field being modified, and thus it cannot be parameterized
    2Expression closed is a field being modified, and thus it cannot be parameterized
    3Expression close(true) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    4Expression showUpdateDialog() is a void method call, and thus it cannot be parameterized
    5Expression close(true) is a void method call, and thus it cannot be parameterized
    6Expression close(true) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    7Expression showUpdateDialog() is a void method call, and thus it cannot be parameterized
    8Expression close(true) is a void method call, and thus it cannot be parameterized