try { getCommand(infos).execute(); } catch (Exception e) { _session.showErrorMessage(e); }
if (!newName.equals(oldName)) { try { folder.setName(newName); } catch (Exception ex) { s_log.error("Error", ex); // ?? } }
Clone fragments detected by clone detection tool
File path: /sql12/plugins/refactoring/src/net/sourceforge/squirrel_sql/plugins/refactoring/actions/AbstractRefactoringAction.java File path: /sql12/plugins/favs/src/net/sourceforge/squirrel_sql/plugins/favs/QueryTreeModel.java
Method name: void actionPerformed(ActionEvent) Method name: void treeNodesChanged(TreeModelEvent)
Number of AST nodes: 2 Number of AST nodes: 3
1
try
2
				{
3
					getCommand(infos).execute(
1
if (!newName.equals(oldName)) {
2
						try {
4
);
3
							folder.setName(newName);
5
				} catch (Exception e)
4
						} catch (Exception ex) {
6
				{
5
				
7
					_session.showErrorMessage(e);
6
			
7
s_log.error("Error", ex); // ??
8
						}
8
				}
9
					}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.2
Clones locationClones are in different classes
Number of node comparisons4
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment1
    Number of unmapped statements in the second code fragment1
    Time elapsed for statement mapping (ms)283.8
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    5
    try
    5
    try
    11
    try
    Differences
    Expression1Expression2Difference
    eexVARIABLE_NAME_MISMATCH
    showErrorMessageerrorMETHOD_INVOCATION_NAME_MISMATCH
    _sessions_logVARIABLE_NAME_MISMATCH
    net.sourceforge.squirrel_sql.client.session.ISessionnet.sourceforge.squirrel_sql.fw.util.log.ILoggerVARIABLE_TYPE_MISMATCH
    _session.showErrorMessage(e)s_log.error("Error",ex)ARGUMENT_NUMBER_MISMATCH
    Preondition Violations
    Expression _session.showErrorMessage(e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression s_log.error("Error",ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression _session.showErrorMessage(e) is a void method call, and thus it cannot be parameterized
    Expression s_log.error("Error",ex) is a void method call, and thus it cannot be parameterized
    Type net.sourceforge.squirrel_sql.client.session.ISession of variable _session does not match with type net.sourceforge.squirrel_sql.fw.util.log.ILogger of variable s_log
    • Make classes net.sourceforge.squirrel_sql.client.session.ISession and net.sourceforge.squirrel_sql.fw.util.log.ILogger extend a common superclass
    Expression _session.showErrorMessage(e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression s_log.error("Error",ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression _session.showErrorMessage(e) is a void method call, and thus it cannot be parameterized
    Expression s_log.error("Error",ex) is a void method call, and thus it cannot be parameterized
    11
    try
    6
    getCommand(infos).execute();
    6
    getCommand(infos).execute();
    Preondition Violations
    Unmatched statement getCommand(infos).execute(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
                                                                  
                                                            
    12
    folder.setName(newName);
    Preondition Violations
    Unmatched statement folder.setName(newName); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    Unmatched statement folder.setName(newName); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    12
    folder.setName(newName);
    Precondition Violations (12)
    Row Violation
    1Expression _session.showErrorMessage(e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    2Expression s_log.error("Error",ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    3Expression _session.showErrorMessage(e) is a void method call, and thus it cannot be parameterized
    4Expression s_log.error("Error",ex) is a void method call, and thus it cannot be parameterized
    5Type net.sourceforge.squirrel_sql.client.session.ISession of variable _session does not match with type net.sourceforge.squirrel_sql.fw.util.log.ILogger of variable s_log
    6Expression _session.showErrorMessage(e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    7Expression s_log.error("Error",ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    8Expression _session.showErrorMessage(e) is a void method call, and thus it cannot be parameterized
    9Expression s_log.error("Error",ex) is a void method call, and thus it cannot be parameterized
    10Unmatched statement getCommand(infos).execute(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    11Unmatched statement folder.setName(newName); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    12Unmatched statement folder.setName(newName); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted