if (conn != null) { try { conn.close(); } catch (SQLException ex) { // i18n[ConnectToAliasCommand.error.closeconnection=Error occured closing Connection] s_log.error(s_stringMgr.getString("ConnectToAliasCommand.error.closeconnection"), ex); } }
try { getSession().closeSQLConnection(); } catch (SQLException ex) { showError(ex); }
Clone fragments detected by clone detection tool
File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/mainframe/action/ConnectToAliasCommand.java File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/gui/session/SessionPanel.java
Method name: void closeConnection(ISQLConnection) Method name: void closeConnection()
Number of AST nodes: 3 Number of AST nodes: 2
1
if (conn != null)
2
			{
3
				try
1
try
4
				{
2
		{
5
					conn.close();
3
			
6
				}
7
				catch (SQLException ex)
8
				{
9
                    // i18n[ConnectToAliasCommand.error.closeconnection=Error occured closing Connection]
10
					s_log.error(s_stringMgr.getString("ConnectToAliasCommand.error.closeconnection"), ex);
11
				}
12
	
4
getSession().closeSQLConnection();
5
		}
6
		catch (SQLException ex)
7
		{
8
			showError(ex);
13
		}
9
		}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.3
Clones locationClones are in different classes
Number of node comparisons4
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment1
    Number of unmapped statements in the second code fragment1
    Time elapsed for statement mapping (ms)105.4
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    2
    try
    2
    try
    1
    try
    Differences
    Expression1Expression2Difference
    errorshowErrorMETHOD_INVOCATION_NAME_MISMATCH
    s_log.error(s_stringMgr.getString("ConnectToAliasCommand.error.closeconnection"),ex)showError(ex)ARGUMENT_NUMBER_MISMATCH
    s_logMISSING_METHOD_INVOCATION_EXPRESSION
    Preondition Violations
    Expression s_log.error(s_stringMgr.getString("ConnectToAliasCommand.error.closeconnection"),ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression showError(ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    • Inline private method showError
    Expression s_log.error(s_stringMgr.getString("ConnectToAliasCommand.error.closeconnection"),ex) is a void method call, and thus it cannot be parameterized
    Expression showError(ex) is a void method call, and thus it cannot be parameterized
    Expression s_log.error(s_stringMgr.getString("ConnectToAliasCommand.error.closeconnection"),ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression showError(ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    • Inline private method showError
    Expression s_log.error(s_stringMgr.getString("ConnectToAliasCommand.error.closeconnection"),ex) is a void method call, and thus it cannot be parameterized
    Expression showError(ex) is a void method call, and thus it cannot be parameterized
    1
    try
                                                                              
    2
    getSession().closeSQLConnection();
    Preondition Violations
    Unmatched statement getSession().closeSQLConnection(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    2
    getSession().closeSQLConnection();
    3
    conn.close();
    3
    conn.close();
    Preondition Violations
    Unmatched statement conn.close(); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    Unmatched statement conn.close(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
                                    
    Precondition Violations (12)
    Row Violation
    1Expression s_log.error(s_stringMgr.getString("ConnectToAliasCommand.error.closeconnection"),ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    2Expression showError(ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    3Expression s_log.error(s_stringMgr.getString("ConnectToAliasCommand.error.closeconnection"),ex) is a void method call, and thus it cannot be parameterized
    4Expression showError(ex) is a void method call, and thus it cannot be parameterized
    5Expression s_log.error(s_stringMgr.getString("ConnectToAliasCommand.error.closeconnection"),ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    6Expression showError(ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    7Expression s_log.error(s_stringMgr.getString("ConnectToAliasCommand.error.closeconnection"),ex) is a void method call, and thus it cannot be parameterized
    8Expression showError(ex) is a void method call, and thus it cannot be parameterized
    9Unmatched statement getSession().closeSQLConnection(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    10Unmatched statement conn.close(); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    11Unmatched statement conn.close(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    12The refactoring of the clones is infeasible, because classes net.sourceforge.squirrel_sql.client.mainframe.action.ConnectToAliasCommand.SheetHandler and net.sourceforge.squirrel_sql.client.gui.session.SessionPanel do not have a common superclass