try
{
reader.close();
}
catch (Exception e)
{
s_log.error("closeReader: Unable to close FileReader - " + e.getMessage(), e);
}
if (printJob.printDialog()) {
try {
printJob.print();
} catch (PrinterException pe) {
s_log.error("Error printing", pe);
}
}
Clone fragments detected by clone detection tool
File path: /sql12/fw/src/net/sourceforge/squirrel_sql/fw/util/IOUtilitiesImpl.java
|
|
File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/util/PrintUtilities.java
|
Method name: void closeReader(Reader)
|
|
Method name: void print()
|
Number of AST nodes: 2
|
|
Number of AST nodes: 3
|
|
1 | try↵ | | |
|
2 | {↵ | | |
|
3 | reader.close();↵ | | |
|
4 | }↵ | | |
|
5 | catch (↵ | | 1 | if (printJob.printDialog()) {↵
|
| | | 2 | try {↵
|
| | | 3 | printJob.print();↵
|
6 | Exception e)↵ | | 4 | } catch (PrinterException pe)↵
|
7 | {↵ | | |
|
8 | s_log.error("closeReader: Unable to close FileReader - " + e.getMessage(), e);↵ | | |
|
9 | ↵ | | 5 | {↵
|
| | | 6 | s_log.error("Error printing", pe);↵
|
| | | 7 | }↵
|
10 | } | | 8 | }
|
See real code fragment |
|
See real code fragment |
Summary
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.3 |
Clones location | Clones are in different classes |
Number of node comparisons | 5 |
-
{Non-refactorable}
Mapping Summary
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 1.0 |
Clone type | Type 2 |
Mapped Statements
ID |
Statement |
|
ID |
Statement |
2 | try | | 4 | try |
3 | | | | |
| | | 5 | |
Precondition Violations (4)
Row |
Violation |
1 | Expression "closeReader: Unable to close FileReader - " + e.getMessage() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Unmatched statement reader.close(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |
3 | Unmatched statement printJob.print(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |
4 | The refactoring of the clones is infeasible, because classes net.sourceforge.squirrel_sql.fw.util.IOUtilitiesImpl and net.sourceforge.squirrel_sql.client.util.PrintUtilities do not have a common superclass |