File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/update/UpdateControllerImpl.java | File path: /sql12/plugins/dataimport/src/com/csvreader/CsvReader.java | |||
Method name: void showDialog()
|
Method name: void close()
|
|||
Number of AST nodes: 3 | Number of AST nodes: 3 | |||
1 | if (waitingForOk)↵ | 1 | if (↵ | |
2 | {↵ | |||
3 | waitingForOk = false;↵ | |||
4 | showUpdateDialog()↵ | 2 | !closed) {↵ | |
3 | close(true);↵ | |||
5 | ;↵ | 4 | closed = true;↵ | |
6 | } | 5 | } | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.1 |
Clones location | Clones are in different classes |
Number of node comparisons | 9 |
Number of mapped statements | 3 |
Number of unmapped statements in the first code fragment | 0 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 96.1 |
Clone type | Type 2 |
ID | Statement | ID | Statement | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | if (waitingForOk) |
| 1 | if (!closed) | |||||||||||||||||||
2 | waitingForOk = false; |
| 3 | closed = true; | |||||||||||||||||||
3 | showUpdateDialog(); |
| 2 | close(true); |
Row | Violation |
---|---|
1 | Expression waitingForOk is a field being modified, and thus it cannot be parameterized |
2 | Expression closed is a field being modified, and thus it cannot be parameterized |
3 | Expression close(true) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
4 | Expression showUpdateDialog() is a void method call, and thus it cannot be parameterized |
5 | Expression close(true) is a void method call, and thus it cannot be parameterized |
6 | Expression close(true) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
7 | Expression showUpdateDialog() is a void method call, and thus it cannot be parameterized |
8 | Expression close(true) is a void method call, and thus it cannot be parameterized |