if (conn != null)
{
try
{
conn.close();
}
catch (SQLException ex)
{
// i18n[ConnectToAliasCommand.error.closeconnection=Error occured closing Connection]
s_log.error(s_stringMgr.getString("ConnectToAliasCommand.error.closeconnection"), ex);
}
}
try {
connection.commit();
} catch (SQLException e) {
log.error("Failed to commit connection - "+connection, e);
}
Clone fragments detected by clone detection tool
File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/mainframe/action/ConnectToAliasCommand.java
|
|
File path: /sql12/plugins/dbcopy/src/net/sourceforge/squirrel_sql/plugins/dbcopy/CopyExecutor.java
|
Method name: void closeConnection(ISQLConnection)
|
|
Method name: void commitConnection(ISQLConnection)
|
Number of AST nodes: 3
|
|
Number of AST nodes: 2
|
|
1 | if (conn != null)↵ | | |
|
2 | {↵ | | |
|
3 | try↵ | | |
|
4 | {↵ | | |
|
5 | conn.close();↵ | | |
|
6 | }↵ | | |
|
7 | ↵ | | 1 | try {↵
|
| | | 2 | connection.commit();↵
|
8 | catch (SQLException ex)↵ | | 3 | } catch (SQLException e↵
|
9 | {↵ | | 4 | ) {↵
|
10 | // i18n[ConnectToAliasCommand.error.closeconnection=Error occured closing Connection]↵ | | 5 | ↵
|
11 | s_log.error(s_stringMgr.getString("ConnectToAliasCommand.error.closeconnection"), ex);↵ | | 6 | log.error("Failed to commit connection - "+connection, e);↵
|
12 | }↵ | | |
|
13 | } | | 7 | }
|
See real code fragment |
|
See real code fragment |
Summary
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.3 |
Clones location | Clones are in different classes |
Number of node comparisons | 4 |
-
{Non-refactorable}
Mapping Summary
Number of mapped statements | 2 |
Number of unmapped statements in the first code fragment | 0 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 21.9 |
Clone type | Type 2 |
Mapped Statements
ID |
Statement |
|
ID |
Statement |
2 | try | | 1 | try |
3 | | | 2 | |
Precondition Violations (5)
Row |
Violation |
1 | Expression conn.close() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression connection.commit() is a method call throwing exception(s) that should be caught by a try block that will be extracted |
3 | Expression conn.close() is a void method call, and thus it cannot be parameterized |
4 | Expression connection.commit() is a void method call, and thus it cannot be parameterized |
5 | The refactoring of the clones is infeasible, because classes net.sourceforge.squirrel_sql.client.mainframe.action.ConnectToAliasCommand.SheetHandler and net.sourceforge.squirrel_sql.plugins.dbcopy.CopyExecutor do not have a common superclass |