for (CheckUpdateListener listener: _checkUpdateListeners) { try { listener.checkUpToDate(); } catch (Exception ex) { listener.showErrorMessage( "Unexpected Exception", "Update check failed with Exception: " + ex.getMessage(), ex); } }
try { getSession().closeSQLConnection(); } catch (SQLException ex) { showError(ex); }
Clone fragments detected by clone detection tool
File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/update/gui/UpdateManagerDialog.java File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/gui/session/SessionPanel.java
Method name: void actionPerformed(ActionEvent) Method name: void closeConnection()
Number of AST nodes: 3 Number of AST nodes: 2
1
for (CheckUpdateListener listener: _checkUpdateListeners) {
2
               try {
3
                  listener.checkUpToDate();
4
               } 
1
try
2
		{
3
			getSession().closeSQLConnection();
4
		}
5
catch (Exception ex) {
5
		catch (SQLException ex)
6
                  listener.showErrorMessage(
7
                     "Unexpected Exception",
8
                     "Update check failed with Exception: " + ex.getMessage(),
9
                     ex);
10
               }
11
            
6
		{
7
			showError(ex);
12
}
8
		}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.3
Clones locationClones are in different classes
Number of node comparisons4
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements2
    Number of unmapped statements in the first code fragment0
    Number of unmapped statements in the second code fragment0
    Time elapsed for statement mapping (ms)299.5
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    3
    try
    3
    try
    1
    try
    Differences
    Expression1Expression2Difference
    java.lang.Exceptionjava.sql.SQLExceptionSUBCLASS_TYPE_MISMATCH
    java.lang.Exceptionjava.sql.SQLExceptionSUBCLASS_TYPE_MISMATCH
    showErrorMessageshowErrorMETHOD_INVOCATION_NAME_MISMATCH
    listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex)showError(ex)ARGUMENT_NUMBER_MISMATCH
    listenerMISSING_METHOD_INVOCATION_EXPRESSION
    Preondition Violations
    Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression showError(ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    • Inline private method showError
    Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) is a void method call, and thus it cannot be parameterized
    Expression showError(ex) is a void method call, and thus it cannot be parameterized
    Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression showError(ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    • Inline private method showError
    Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) is a void method call, and thus it cannot be parameterized
    Expression showError(ex) is a void method call, and thus it cannot be parameterized
    1
    try
    4
    listener.checkUpToDate();
    4
    listener.checkUpToDate();
    2
    getSession().closeSQLConnection();
    Differences
    Expression1Expression2Difference
    checkUpToDatecloseSQLConnectionMETHOD_INVOCATION_NAME_MISMATCH
    listenergetSession()AST_TYPE_MISMATCH
    Preondition Violations
    Expression listener.checkUpToDate() cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression getSession().closeSQLConnection() is a method call throwing exception(s) that should be caught by a try block that will be extracted
    Expression listener.checkUpToDate() is a void method call, and thus it cannot be parameterized
    Expression getSession().closeSQLConnection() is a void method call, and thus it cannot be parameterized
    2
    getSession().closeSQLConnection();
    Precondition Violations (13)
    Row Violation
    1Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    2Expression showError(ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    3Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) is a void method call, and thus it cannot be parameterized
    4Expression showError(ex) is a void method call, and thus it cannot be parameterized
    5Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    6Expression showError(ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    7Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) is a void method call, and thus it cannot be parameterized
    8Expression showError(ex) is a void method call, and thus it cannot be parameterized
    9Expression listener.checkUpToDate() cannot be parameterized, because it has dependencies to/from statements that will be extracted
    10Expression getSession().closeSQLConnection() is a method call throwing exception(s) that should be caught by a try block that will be extracted
    11Expression listener.checkUpToDate() is a void method call, and thus it cannot be parameterized
    12Expression getSession().closeSQLConnection() is a void method call, and thus it cannot be parameterized
    13The refactoring of the clones is infeasible, because classes and net.sourceforge.squirrel_sql.client.gui.session.SessionPanel do not have a common superclass