super(); if (app == null) { throw new IllegalArgumentException("Null IApplication passed"); } if (cache == null) { throw new IllegalArgumentException("Null FoldersCache passed"); } _app = app; _cache = cache; _frame = frame;
super(); if (app == null) { throw new IllegalArgumentException("app cannot be null"); } if (frame == null) { throw new IllegalArgumentException("frame cannot be null"); } _app = app; _frame = frame;
Clone fragments detected by clone detection tool
File path: /sql12/plugins/favs/src/net/sourceforge/squirrel_sql/plugins/favs/OrganizeSavedQueriesCommand.java File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/mainframe/action/SavePreferencesCommand.java
Method name: void OrganizeSavedQueriesCommand(IApplication, FoldersCache, Frame) Method name: void SavePreferencesCommand(IApplication, Frame)
Number of AST nodes: 8 Number of AST nodes: 7
1
super();
1
super();
2
		if (app == null) {
2
      if (app == null)
3
			
3
      {
4
throw new IllegalArgumentException("Null IApplication passed");
4
         throw new IllegalArgumentException("
5
		}
6
		if (cache == null) {
7
			
5
app cannot be null");
6
      }
7
      if (frame == null)
8
      {
8
throw new IllegalArgumentException("Null FoldersCache passed");
9
         throw new IllegalArgumentException("
9
		}
10
		_app = app;
11
		_cache = cache;
12
		
10
frame cannot be null");
11
      }
12
      _app = app;
13
_frame = frame;
13
      _frame = frame;
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.3
Clones locationClones are in different classes
Number of node comparisons20
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements7
    Number of unmapped statements in the first code fragment1
    Number of unmapped statements in the second code fragment0
    Time elapsed for statement mapping (ms)1.3
    Clone typeType 3
    Mapped Statements
    ID Statement ID Statement
    1
    super();
    1
    super();
    1
    super();
    Preondition Violations
    Super constructor call super(); cannot be extracted from constructor
    Super constructor call super(); cannot be extracted from constructor
    1
    super();
    2
    if (app == null)
    2
    if (app == null)
    3
    throw new IllegalArgumentException("Null IApplication passed");
    3
    throw new IllegalArgumentException("Null IApplication passed");
    3
    throw new IllegalArgumentException("app cannot be null");
    Differences
    Expression1Expression2Difference
    "Null IApplication passed""app cannot be null"LITERAL_VALUE_MISMATCH
    3
    throw new IllegalArgumentException("app cannot be null");
    4
    if (cache == null)
    4
    if (cache == null)
    4
    if (frame == null)
    Differences
    Expression1Expression2Difference
    cacheframeVARIABLE_NAME_MISMATCH
    net.sourceforge.squirrel_sql.plugins.favs.FoldersCachejava.awt.FrameVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type net.sourceforge.squirrel_sql.plugins.favs.FoldersCache of variable cache does not match with type java.awt.Frame of variable frame
    • Make classes net.sourceforge.squirrel_sql.plugins.favs.FoldersCache and java.awt.Frame extend a common superclass
    4
    if (frame == null)
    5
    throw new IllegalArgumentException("Null FoldersCache passed");
    5
    throw new IllegalArgumentException("Null FoldersCache passed");
    5
    throw new IllegalArgumentException("frame cannot be null");
    Differences
    Expression1Expression2Difference
    "Null FoldersCache passed""frame cannot be null"LITERAL_VALUE_MISMATCH
    5
    throw new IllegalArgumentException("frame cannot be null");
    6
    _app = app;
    6
    _app = app;
    7
    _cache = cache;
    7
    _cache = cache;
    Preondition Violations
    Unmatched statement _cache=cache; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
                                    
    8
    _frame = frame;
    7
    _frame = frame;
    Precondition Violations (4)
    Row Violation
    1Super constructor call super(); cannot be extracted from constructor
    2Super constructor call super(); cannot be extracted from constructor
    3Type net.sourceforge.squirrel_sql.plugins.favs.FoldersCache of variable cache does not match with type java.awt.Frame of variable frame
    4Unmatched statement _cache=cache; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted