for (CheckUpdateListener listener: _checkUpdateListeners) { try { listener.checkUpToDate(); } catch (Exception ex) { listener.showErrorMessage( "Unexpected Exception", "Update check failed with Exception: " + ex.getMessage(), ex); } }
if (_session != null) { try { getCommand().execute(); } catch (Exception e) { _session.showMessage(e); } }
Clone fragments detected by clone detection tool
File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/update/gui/UpdateManagerDialog.java File path: /sql12/plugins/postgres/src/net/sourceforge/squirrel_sql/plugins/postgres/actions/AbstractSessionAction.java
Method name: void actionPerformed(ActionEvent) Method name: void actionPerformed(ActionEvent)
Number of AST nodes: 3 Number of AST nodes: 3
1
for (CheckUpdateListener listener: _checkUpdateListeners) {
1
if (_session != null) {
2
               try {
2
            try {
3
                  listener.checkUpToDate();
3
                getCommand().execute();
4
               } catch (Exception ex) {
4
            } catch (Exception e) {
5
                  listener.showErrorMessage(
5
                
6
                     "Unexpected Exception",
7
                     "Update check failed with Exception: " + ex.getMessage(),
8
                     ex);
6
_session.showMessage(e);
9
               }
7
            
10
    
8
}
11
        }
9
        }
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.3
Clones locationClones are in different classes
Number of node comparisons5
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements2
    Number of unmapped statements in the first code fragment0
    Number of unmapped statements in the second code fragment0
    Time elapsed for statement mapping (ms)655.0
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    3
    try
    3
    try
    2
    try
    Differences
    Expression1Expression2Difference
    exeVARIABLE_NAME_MISMATCH
    showErrorMessageshowMessageMETHOD_INVOCATION_NAME_MISMATCH
    listener_sessionVARIABLE_NAME_MISMATCH
    net.sourceforge.squirrel_sql.client.update.gui.CheckUpdateListenernet.sourceforge.squirrel_sql.client.session.ISessionVARIABLE_TYPE_MISMATCH
    listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex)_session.showMessage(e)ARGUMENT_NUMBER_MISMATCH
    Preondition Violations
    Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression _session.showMessage(e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) is a void method call, and thus it cannot be parameterized
    Expression _session.showMessage(e) is a void method call, and thus it cannot be parameterized
    Type net.sourceforge.squirrel_sql.client.update.gui.CheckUpdateListener of variable listener does not match with type net.sourceforge.squirrel_sql.client.session.ISession of variable _session
    • Make classes net.sourceforge.squirrel_sql.client.update.gui.CheckUpdateListener and net.sourceforge.squirrel_sql.client.session.ISession extend a common superclass
    Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression _session.showMessage(e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) is a void method call, and thus it cannot be parameterized
    Expression _session.showMessage(e) is a void method call, and thus it cannot be parameterized
    2
    try
    4
    listener.checkUpToDate();
    4
    listener.checkUpToDate();
    3
    getCommand().execute();
    Differences
    Expression1Expression2Difference
    checkUpToDateexecuteMETHOD_INVOCATION_NAME_MISMATCH
    listenergetCommand()AST_TYPE_MISMATCH
    Preondition Violations
    Expression listener.checkUpToDate() cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression getCommand().execute() is a method call throwing exception(s) that should be caught by a try block that will be extracted
    Expression listener.checkUpToDate() is a void method call, and thus it cannot be parameterized
    Expression getCommand().execute() is a void method call, and thus it cannot be parameterized
    3
    getCommand().execute();
    Precondition Violations (14)
    Row Violation
    1Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    2Expression _session.showMessage(e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    3Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) is a void method call, and thus it cannot be parameterized
    4Expression _session.showMessage(e) is a void method call, and thus it cannot be parameterized
    5Type net.sourceforge.squirrel_sql.client.update.gui.CheckUpdateListener of variable listener does not match with type net.sourceforge.squirrel_sql.client.session.ISession of variable _session
    6Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    7Expression _session.showMessage(e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    8Expression listener.showErrorMessage("Unexpected Exception","Update check failed with Exception: " + ex.getMessage(),ex) is a void method call, and thus it cannot be parameterized
    9Expression _session.showMessage(e) is a void method call, and thus it cannot be parameterized
    10Expression listener.checkUpToDate() cannot be parameterized, because it has dependencies to/from statements that will be extracted
    11Expression getCommand().execute() is a method call throwing exception(s) that should be caught by a try block that will be extracted
    12Expression listener.checkUpToDate() is a void method call, and thus it cannot be parameterized
    13Expression getCommand().execute() is a void method call, and thus it cannot be parameterized
    14The refactoring of the clones is infeasible, because classes and net.sourceforge.squirrel_sql.plugins.postgres.actions.AbstractSessionAction do not have a common superclass