if(_viewTableTypesCacheable[i].equals(type)) { found = true; break; }
if (actionListeners[j].equals(listener)) { // We don't add a listener to a button twice // because the FindDialogSupport class will call // this method with the same button instances // whenever the replace dialog is opened. // // If we add the listener again and again replace // will be done as often as the dialog is opened. // This is especially nasty if the text to replace // is part of the replacement text. found = true; }
Clone fragments detected by clone detection tool
File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/session/schemainfo/SchemaInfoCache.java File path: /sql12/plugins/syntax/src/net/sourceforge/squirrel_sql/plugins/syntax/netbeans/SquirrelNBDialogFactory.java
Method name: boolean isCachedTableType(String) Method name: Dialog createDialog(String, JPanel, boolean, JButton[], boolean, int, int, ActionListener)
Number of AST nodes: 3 Number of AST nodes: 2
1
if(_viewTableTypesCacheable[i].equals(type))
1
if (actionListeners[j].equals(listener))
2
               {
3
                  // We don't add a listener to a button twice
4
                  // because the FindDialogSupport class will call
5
                  // this method with the same button instances
6
                  // whenever the replace dialog is opened.
7
                  //
8
                  // If we add the listener again and again replace
2
         {
9
         
3
         
10
         // will be done as often as the dialog is opened.
11
                  // This is especially nasty if the text to replace
12
                  // is part of the replacement text.
4
   found = true;
13
                  found = true;
5
            break;
14
      
6
         }
15
         }
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.3
Clones locationClones are in different classes
Number of node comparisons8
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements2
    Number of unmapped statements in the first code fragment1
    Number of unmapped statements in the second code fragment0
    Time elapsed for statement mapping (ms)1.3
    Clone typeType 3
    Mapped Statements
    ID Statement ID Statement
    3
    if (_viewTableTypesCacheable[i].equals(type))
    3
    if (_viewTableTypesCacheable[i].equals(type))
    17
    if (actionListeners[j].equals(listener))
    Differences
    Expression1Expression2Difference
    typelistenerVARIABLE_NAME_MISMATCH
    java.lang.Stringjava.awt.event.ActionListenerVARIABLE_TYPE_MISMATCH
    _viewTableTypesCacheableactionListenersVARIABLE_NAME_MISMATCH
    java.lang.String[]java.awt.event.ActionListener[]VARIABLE_TYPE_MISMATCH
    ijVARIABLE_NAME_MISMATCH
    Preondition Violations
    Type java.lang.String of variable type does not match with type java.awt.event.ActionListener of variable listener
    • Make classes java.lang.String and java.awt.event.ActionListener extend a common superclass
    Type java.lang.String[] of variable _viewTableTypesCacheable does not match with type java.awt.event.ActionListener[] of variable actionListeners
    • Make classes java.lang.String[] and java.awt.event.ActionListener[] extend a common superclass
    17
    if (actionListeners[j].equals(listener))
    4
    found = true;
    18
    found = true;
    5
    break;
    5
    break;
    Preondition Violations
    Unmatched break;
                      
    Precondition Violations (4)
    Row Violation
    1Type java.lang.String of variable type does not match with type java.awt.event.ActionListener of variable listener
    2Type java.lang.String[] of variable _viewTableTypesCacheable does not match with type java.awt.event.ActionListener[] of variable actionListeners
    3Unmatched break;
    4The refactoring of the clones is infeasible, because classes net.sourceforge.squirrel_sql.client.session.schemainfo.SchemaInfoCache and net.sourceforge.squirrel_sql.plugins.syntax.netbeans.SquirrelNBDialogFactory do not have a common superclass