if (_session != null) { try { getCommand().execute(); } catch (Exception e) { _session.showMessage(e); } }
try { getSession().closeSQLConnection(); } catch (SQLException ex) { showError(ex); }
Clone fragments detected by clone detection tool
File path: /sql12/plugins/postgres/src/net/sourceforge/squirrel_sql/plugins/postgres/actions/AbstractSessionAction.java File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/gui/session/SessionPanel.java
Method name: void actionPerformed(ActionEvent) Method name: void closeConnection()
Number of AST nodes: 3 Number of AST nodes: 2
1
if (_session != null) {
2
            try {
3
                getCommand().execute();
4
            } 
1
try
2
		{
3
			getSession().closeSQLConnection();
4
		}
5
catch (Exception e) {
5
		catch (SQLException e
6
                _session.showMessage
6
x)
7
		{
7
(e);
8
			showError(ex);
8
            }
9
        
10
}
9
		}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.3
Clones locationClones are in different classes
Number of node comparisons4
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements2
    Number of unmapped statements in the first code fragment0
    Number of unmapped statements in the second code fragment0
    Time elapsed for statement mapping (ms)403.9
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    2
    try
    2
    try
    1
    try
    Differences
    Expression1Expression2Difference
    java.lang.Exceptionjava.sql.SQLExceptionSUBCLASS_TYPE_MISMATCH
    eexVARIABLE_NAME_MISMATCH
    java.lang.Exceptionjava.sql.SQLExceptionSUBCLASS_TYPE_MISMATCH
    eexVARIABLE_NAME_MISMATCH
    java.lang.Exceptionjava.sql.SQLExceptionSUBCLASS_TYPE_MISMATCH
    showMessageshowErrorMETHOD_INVOCATION_NAME_MISMATCH
    _sessionMISSING_METHOD_INVOCATION_EXPRESSION
    Preondition Violations
    Expression _session.showMessage(e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression showError(ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    • Inline private method showError
    Expression _session.showMessage(e) is a void method call, and thus it cannot be parameterized
    Expression showError(ex) is a void method call, and thus it cannot be parameterized
    Expression _session.showMessage(e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression showError(ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    • Inline private method showError
    Expression _session.showMessage(e) is a void method call, and thus it cannot be parameterized
    Expression showError(ex) is a void method call, and thus it cannot be parameterized
    1
    try
    3
    getCommand().execute();
    3
    getCommand().execute();
    2
    getSession().closeSQLConnection();
    Differences
    Expression1Expression2Difference
    executecloseSQLConnectionMETHOD_INVOCATION_NAME_MISMATCH
    getCommandgetSessionMETHOD_INVOCATION_NAME_MISMATCH
    net.sourceforge.squirrel_sql.fw.util.ICommandnet.sourceforge.squirrel_sql.client.session.ISessionVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Expression getCommand().execute() is a method call throwing exception(s) that should be caught by a try block that will be extracted
    Expression getSession().closeSQLConnection() is a method call throwing exception(s) that should be caught by a try block that will be extracted
    Expression getCommand().execute() is a void method call, and thus it cannot be parameterized
    Expression getSession().closeSQLConnection() is a void method call, and thus it cannot be parameterized
    Type net.sourceforge.squirrel_sql.fw.util.ICommand of variable getCommand() does not match with type net.sourceforge.squirrel_sql.client.session.ISession of variable getSession()
    • Make classes net.sourceforge.squirrel_sql.fw.util.ICommand and net.sourceforge.squirrel_sql.client.session.ISession extend a common superclass
    2
    getSession().closeSQLConnection();
    Precondition Violations (14)
    Row Violation
    1Expression _session.showMessage(e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    2Expression showError(ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    3Expression _session.showMessage(e) is a void method call, and thus it cannot be parameterized
    4Expression showError(ex) is a void method call, and thus it cannot be parameterized
    5Expression _session.showMessage(e) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    6Expression showError(ex) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    7Expression _session.showMessage(e) is a void method call, and thus it cannot be parameterized
    8Expression showError(ex) is a void method call, and thus it cannot be parameterized
    9Expression getCommand().execute() is a method call throwing exception(s) that should be caught by a try block that will be extracted
    10Expression getSession().closeSQLConnection() is a method call throwing exception(s) that should be caught by a try block that will be extracted
    11Expression getCommand().execute() is a void method call, and thus it cannot be parameterized
    12Expression getSession().closeSQLConnection() is a void method call, and thus it cannot be parameterized
    13Type net.sourceforge.squirrel_sql.fw.util.ICommand of variable getCommand() does not match with type net.sourceforge.squirrel_sql.client.session.ISession of variable getSession()
    14The refactoring of the clones is infeasible, because classes net.sourceforge.squirrel_sql.plugins.postgres.actions.AbstractSessionAction and net.sourceforge.squirrel_sql.client.gui.session.SessionPanel do not have a common superclass