if (s_instance == null) { throw new IllegalArgumentException("UIFactory has not been initialized"); } return s_instance;
if (_conn == null) { throw new SQLException(s_stringMgr.getString("SQLConnection.noConn")); }
Clone fragments detected by clone detection tool
File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/gui/builders/UIFactory.java File path: /sql12/fw/src/net/sourceforge/squirrel_sql/fw/sql/SQLConnection.java
Method name: UIFactory getInstance() Method name: void validateConnection()
Number of AST nodes: 3 Number of AST nodes: 2
1
if (s_instance == null)
1
if (_conn == null)
2
		{
3
			throw new IllegalArgumentException("UIFactory has not been initialized");
2
 { throw new 
4
		}
5
		return s_instance;
3
SQLException(s_stringMgr.getString("SQLConnection.noConn")); }
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons4
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements2
    Number of unmapped statements in the first code fragment1
    Number of unmapped statements in the second code fragment0
    Time elapsed for statement mapping (ms)4.2
    Clone typeType 3
    Mapped Statements
    ID Statement ID Statement
    1
    if (s_instance == null)
    1
    if (s_instance == null)
    1
    if (_conn == null)
    Differences
    Expression1Expression2Difference
    s_instance_connVARIABLE_NAME_MISMATCH
    net.sourceforge.squirrel_sql.client.gui.builders.UIFactoryjava.sql.ConnectionVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type net.sourceforge.squirrel_sql.client.gui.builders.UIFactory of variable s_instance does not match with type java.sql.Connection of variable _conn
    • Make classes net.sourceforge.squirrel_sql.client.gui.builders.UIFactory and java.sql.Connection extend a common superclass
    1
    if (_conn == null)
    2
    throw new IllegalArgumentException("UIFactory has not been initialized");
    2
    throw new IllegalArgumentException("UIFactory has not been initialized");
    2
    throw new SQLException(s_stringMgr.getString("SQLConnection.noConn"));
    Differences
    Expression1Expression2Difference
    java.lang.IllegalArgumentExceptionjava.sql.SQLExceptionSUBCLASS_TYPE_MISMATCH
    "UIFactory has not been initialized"s_stringMgr.getString("SQLConnection.noConn")TYPE_COMPATIBLE_REPLACEMENT
    Preondition Violations
    Expression new SQLException(s_stringMgr.getString("SQLConnection.noConn")) is a method call throwing exception(s) that should be caught by a try block that will be extracted
    Expression s_stringMgr.getString("SQLConnection.noConn") is a method call throwing exception(s) that should be caught by a try block that will be extracted
    2
    throw new SQLException(s_stringMgr.getString("SQLConnection.noConn"));
    3
    return s_instance;
    3
    return s_instance;
    Preondition Violations
    Unmatched statement return s_instance; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    Unmatched return s_instance;
                                              
    Precondition Violations (5)
    Row Violation
    1Type net.sourceforge.squirrel_sql.client.gui.builders.UIFactory of variable s_instance does not match with type java.sql.Connection of variable _conn
    2Expression new SQLException(s_stringMgr.getString("SQLConnection.noConn")) is a method call throwing exception(s) that should be caught by a try block that will be extracted
    3Expression s_stringMgr.getString("SQLConnection.noConn") is a method call throwing exception(s) that should be caught by a try block that will be extracted
    4Unmatched statement return s_instance; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    5Unmatched return s_instance;