if (s_instance == null)
{
throw new IllegalArgumentException("UIFactory has not been initialized");
}
return s_instance;
if (_conn == null) { throw new SQLException(s_stringMgr.getString("SQLConnection.noConn")); }
Clone fragments detected by clone detection tool
File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/gui/builders/UIFactory.java
|
|
File path: /sql12/fw/src/net/sourceforge/squirrel_sql/fw/sql/SQLConnection.java
|
Method name: UIFactory getInstance()
|
|
Method name: void validateConnection()
|
Number of AST nodes: 3
|
|
Number of AST nodes: 2
|
|
1 | if (s_instance == null)↵ | | 1 | if (_conn == null)↵
|
2 | {↵ | | |
|
3 | throw new IllegalArgumentException("UIFactory has not been initialized");↵ | | 2 | { throw new ↵
|
4 | }↵ | | |
|
|
5 | return s_instance; | | 3 | SQLException(s_stringMgr.getString("SQLConnection.noConn")); }
|
See real code fragment |
|
See real code fragment |
Summary
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.1 |
Clones location | Clones are in different classes |
Number of node comparisons | 4 |
-
{Non-refactorable}
Mapping Summary
Number of mapped statements | 2 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 4.2 |
Clone type | Type 3 |
Mapped Statements
ID |
Statement |
|
ID |
Statement |
1 | if (s_instance == null) | | 1 | if (_conn == null) |
2 | throw new IllegalArgumentException("UIFactory has not been initialized"); | | 2 | throw new SQLException(s_stringMgr.getString("SQLConnection.noConn")); |
3 | return s_instance; | | | |
Precondition Violations (5)
Row |
Violation |
1 | Type net.sourceforge.squirrel_sql.client.gui.builders.UIFactory of variable s_instance does not match with type java.sql.Connection of variable _conn |
2 | Expression new SQLException(s_stringMgr.getString("SQLConnection.noConn")) is a method call throwing exception(s) that should be caught by a try block that will be extracted |
3 | Expression s_stringMgr.getString("SQLConnection.noConn") is a method call throwing exception(s) that should be caught by a try block that will be extracted |
4 | Unmatched statement return s_instance; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
5 | Unmatched return s_instance; |