File path: /sql12/plugins/dataimport/src/net/sourceforge/squirrel_sql/plugins/dataimport/importer/csv/CSVFileImporter.java | File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/session/mainpanel/SQLHistoryController.java | |||
Method name: boolean reset()
|
Method name: void windowClosed(WindowEvent)
|
|||
Number of AST nodes: 4 | Number of AST nodes: 2 | |||
1 | if (reader != null) {↵ | 1 | if↵ | |
2 | reader.close();↵ | |||
3 | }↵ | |||
4 | reader = new CsvReader(new InputStreamReader(new FileInputStream(importFile), settings.getImportChar↵ | 2 | (false == onWindowClosedCalled)↵ | |
3 | {↵ | |||
5 | set()), settings.getSeperator());↵ | 4 | onWindowClosed()↵ | |
6 | return true; | 5 | ;↵ | |
6 |
| |||
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2 |
Clones location | Clones are in different classes |
Number of node comparisons | 4 |
Number of mapped statements | 2 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 11.4 |
Clone type | Type 3 |
ID | Statement | ID | Statement | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | if (reader != null) |
| 1 | if (false == onWindowClosedCalled) | |||||||||||||||||||
2 | reader.close(); |
| 2 | onWindowClosed(); | |||||||||||||||||||
3 | reader = new CsvReader(new InputStreamReader(new FileInputStream(importFile), settings.getImportCharset()), settings.getSeperator()); |
| | ||||||||||||||||||||
4 | return true; |
| |
Row | Violation |
---|---|
1 | Expression reader.close() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression reader.close() is a void method call, and thus it cannot be parameterized |
3 | Expression onWindowClosed() is a void method call, and thus it cannot be parameterized |
4 | Expression reader.close() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
5 | Expression reader.close() is a void method call, and thus it cannot be parameterized |
6 | Expression onWindowClosed() is a void method call, and thus it cannot be parameterized |
7 | Unmatched statement reader=new CsvReader(new InputStreamReader(new FileInputStream(importFile),settings.getImportCharset()),settings.getSeperator()); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
8 | Unmatched return true; |
9 | The refactoring of the clones is infeasible, because classes net.sourceforge.squirrel_sql.plugins.dataimport.importer.csv.CSVFileImporter and do not have a common superclass |