try
{
_viewer.show(_ds);
}
catch (Throwable th)
{
s_log.error("Error processing a DataSet", th);
}
if (!newName.equals(oldName)) {
try {
folder.setName(newName);
} catch (Exception ex) {
s_log.error("Error", ex); // ??
}
}
Clone fragments detected by clone detection tool
File path: /sql12/fw/src/net/sourceforge/squirrel_sql/fw/datasetviewer/DataSetScrollingPanel.java
|
|
File path: /sql12/plugins/favs/src/net/sourceforge/squirrel_sql/plugins/favs/QueryTreeModel.java
|
Method name: void run()
|
|
Method name: void treeNodesChanged(TreeModelEvent)
|
Number of AST nodes: 2
|
|
Number of AST nodes: 3
|
|
| | | 1 | if (!newName.equals(oldName)) {↵
|
1 | try
↵ | | 2 | try {↵
|
2 | {↵ | | 3 | ↵
|
3 | _viewer.show(_ds);
↵ | | 4 | folder.setName(newName);↵
|
4 | }↵ | | 5 | ↵
|
5 | catch (Throwable th)
↵ | | 6 | } catch (Exception ex) {↵
|
6 | {↵ | | 7 | ↵
|
7 | s_log.error("Error processing a DataSet", th);↵ | | 8 | s_log.error("Error↵
|
| | | 9 | ", ex); // ??↵
|
| | | 10 | }↵
|
8 | } | | 11 | }
|
See real code fragment |
|
See real code fragment |
Summary
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2 |
Clones location | Clones are in different classes |
Number of node comparisons | 4 |
-
{Non-refactorable}
Mapping Summary
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 1.0 |
Clone type | Type 2 |
Mapped Statements
ID |
Statement |
|
ID |
Statement |
1 | try | | 11 | try |
2 | | | | |
| | | 12 | |
Precondition Violations (5)
Row |
Violation |
1 | Unmatched statement _viewer.show(_ds); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
2 | Unmatched statement _viewer.show(_ds); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |
3 | Unmatched statement folder.setName(newName); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
4 | Unmatched statement folder.setName(newName); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |
5 | The refactoring of the clones is infeasible, because classes net.sourceforge.squirrel_sql.fw.datasetviewer.DataSetScrollingPanel.UIUpdater and net.sourceforge.squirrel_sql.plugins.favs.QueryTreeModel.MyModelListener do not have a common superclass |