if (reader != null)
{
try
{
reader.close();
}
catch (Exception e)
{
s_log.error("closeReader: Unable to close FileReader - " + e.getMessage(), e);
}
}
try
{
cmd.execute();
}
catch (BaseException ex)
{
// i18n[BaseListInternalFrame.error.execdoubleclick=Error occured executing doubleclick event]
s_log.error(s_stringMgr.getString("BaseListInternalFrame.error.execdoubleclick"), ex);
}
Clone fragments detected by clone detection tool
File path: /sql12/fw/src/net/sourceforge/squirrel_sql/fw/util/IOUtilitiesImpl.java
|
|
File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/gui/db/BaseListInternalFrame.java
|
Method name: void closeReader(Reader)
|
|
Method name: void onMouseClicked(MouseEvent)
|
Number of AST nodes: 3
|
|
Number of AST nodes: 2
|
|
1 | if (reader != null)↵ | | |
|
2 | {↵ | | |
|
3 | try↵ | | |
|
4 | {↵ | | |
|
5 | reader.close();↵ | | |
|
6 | }↵ | | |
|
7 | ↵ | | 1 | try↵
|
| | | 2 | {↵
|
| | | 3 | cmd.execute();↵
|
| | | 4 | }↵
|
8 | catch (Exception e)↵ | | 5 | catch (BaseException ex)↵
|
9 | {↵ | | |
|
10 | s_log.error("closeReader: Unable to close FileReader - " + e.getMessage(↵ | | 6 | {↵
|
| | | 7 | // i18n[BaseListInternalFrame.error.execdoubleclick=Error occured executing doubleclick event]↵
|
11 | ), e);↵ | | 8 | s_log.error(s_stringMgr.getString("BaseListInternalFrame.error.execdoubleclick"), ex);↵
|
12 | }↵ | | |
|
13 | } | | 9 | }
|
See real code fragment |
|
See real code fragment |
Summary
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.4 |
Clones location | Clones are in different classes |
Number of node comparisons | 5 |
-
{Non-refactorable}
Mapping Summary
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 4.6 |
Clone type | Type 2 |
Mapped Statements
ID |
Statement |
|
ID |
Statement |
2 | try | | 4 | try |
3 | | | | |
| | | 5 | |
Precondition Violations (5)
Row |
Violation |
1 | Expression "closeReader: Unable to close FileReader - " + e.getMessage() cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Unmatched statement reader.close(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |
3 | Unmatched statement cmd.execute(); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
4 | Unmatched statement cmd.execute(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |
5 | The refactoring of the clones is infeasible, because classes net.sourceforge.squirrel_sql.fw.util.IOUtilitiesImpl and net.sourceforge.squirrel_sql.client.gui.db.BaseListInternalFrame do not have a common superclass |