if (s_instance == null) { throw new IllegalArgumentException("UIFactory has not been initialized"); } return s_instance;
if (_propChgReporter == null) { _propChgReporter = new PropertyChangeReporter(this); } return _propChgReporter;
Clone fragments detected by clone detection tool
File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/gui/builders/UIFactory.java File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/session/properties/SessionProperties.java
Method name: UIFactory getInstance() Method name: PropertyChangeReporter getPropertyChangeReporter()
Number of AST nodes: 3 Number of AST nodes: 3
1
if (s_instance == null)
1
if (
2
		{
3
			throw new IllegalArgumentException("UIFactory has not been initialized");
4
		}
5
		return s_instance
2
_propChgReporter == null)
3
      {
4
         _propChgReporter = new PropertyChangeReporter(this);
5
      }
6
;
6
      return _propChgReporter;
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons5
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)0.5
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    if (s_instance == null)
    1
    if (s_instance == null)
    1
    if (_propChgReporter == null)
    Differences
    Expression1Expression2Difference
    s_instance_propChgReporterVARIABLE_NAME_MISMATCH
    net.sourceforge.squirrel_sql.client.gui.builders.UIFactorynet.sourceforge.squirrel_sql.fw.util.PropertyChangeReporterVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type net.sourceforge.squirrel_sql.client.gui.builders.UIFactory of variable s_instance does not match with type net.sourceforge.squirrel_sql.fw.util.PropertyChangeReporter of variable _propChgReporter
    • Make classes net.sourceforge.squirrel_sql.client.gui.builders.UIFactory and net.sourceforge.squirrel_sql.fw.util.PropertyChangeReporter extend a common superclass
    1
    if (_propChgReporter == null)
                                                                                                              
    2
    _propChgReporter = new PropertyChangeReporter(this);
    Preondition Violations
    Unmatched statement _propChgReporter=new PropertyChangeReporter(this); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    Unmatched statement _propChgReporter=new PropertyChangeReporter(this); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    2
    _propChgReporter = new PropertyChangeReporter(this);
    2
    throw new IllegalArgumentException("UIFactory has not been initialized");
    2
    throw new IllegalArgumentException("UIFactory has not been initialized");
    Preondition Violations
    Unmatched statement throw new IllegalArgumentException("UIFactory has not been initialized"); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    Unmatched throw new IllegalArgumentException("UIFactory has not been initialized");
                                                                                                                                                            
                                                          
    3
    return _propChgReporter;
    Preondition Violations
    Unmatched return _propChgReporter;
    3
    return _propChgReporter;
    3
    return s_instance;
    3
    return s_instance;
    Preondition Violations
    Unmatched statement return s_instance; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    Unmatched return s_instance;
                                              
    Precondition Violations (9)
    Row Violation
    1Type net.sourceforge.squirrel_sql.client.gui.builders.UIFactory of variable s_instance does not match with type net.sourceforge.squirrel_sql.fw.util.PropertyChangeReporter of variable _propChgReporter
    2Unmatched statement _propChgReporter=new PropertyChangeReporter(this); cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    3Unmatched statement _propChgReporter=new PropertyChangeReporter(this); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    4Unmatched statement throw new IllegalArgumentException("UIFactory has not been initialized"); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted
    5Unmatched throw new IllegalArgumentException("UIFactory has not been initialized");
    6Unmatched return _propChgReporter;
    7Unmatched statement return s_instance; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted
    8Unmatched return s_instance;
    9The refactoring of the clones is infeasible, because the number of macthed statements is equal to zero