File path: /sql12/app/src/net/sourceforge/squirrel_sql/client/update/UpdateControllerImpl.java | File path: /sql12/plugins/dataimport/src/com/csvreader/CsvReader.java | |||
Method name: void showDialog()
|
Method name: void close(boolean)
|
|||
Number of AST nodes: 3 | Number of AST nodes: 2 | |||
1 | if (waitingForOk)↵ | 1 | if (↵ | |
2 | {↵ | |||
3 | waitingForOk = false;↵ | |||
4 | showUpdateDialog↵ | 2 | initialized) {↵ | |
5 | ();↵ | 3 | inputStream.close();↵ | |
6 | } | 4 | } | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 1 |
Number of non-refactorable cases | 0 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.1 |
Clones location | Clones are in different classes |
Number of node comparisons | 6 |
Number of mapped statements | 2 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 96.6 |
Clone type | Type 3 |
ID | Statement | ID | Statement | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | if (waitingForOk) |
| 10 | if (initialized) | |||||||||||||||||||
2 | waitingForOk = false; |
| | ||||||||||||||||||||
3 | showUpdateDialog(); |
| 11 | inputStream.close(); |
Row | Violation |
---|---|
1 | Unmatched statement waitingForOk=false; cannot be moved before the extracted code, because it has control dependencies from statements that will be extracted |
2 | Expression inputStream.close() is a method call throwing exception(s) that should be caught by a try block that will be extracted |
3 | Expression showUpdateDialog() is a void method call, and thus it cannot be parameterized |
4 | Expression inputStream.close() is a void method call, and thus it cannot be parameterized |
5 | Expression inputStream.close() is a method call throwing exception(s) that should be caught by a try block that will be extracted |
6 | Expression showUpdateDialog() is a void method call, and thus it cannot be parameterized |
7 | Expression inputStream.close() is a void method call, and thus it cannot be parameterized |