@Override public boolean predicate2(Object dm, Designer dsgr) { if (!(Model.getFacade().isAPseudostate(dm))) { return NO_PROBLEM; } Object k = Model.getFacade().getKind(dm); if (!Model.getFacade() .equalsPseudostateKind(k, Model.getPseudostateKind().getShallowHistory())) { return NO_PROBLEM; } // container state / composite state Object cs = Model.getFacade().getContainer(dm); if (cs == null) { LOG.debug("null parent state"); return NO_PROBLEM; } int initialStateCount = 0; Collection peers = Model.getFacade().getSubvertices(cs); for (Object sv : peers) { if (Model.getFacade().isAPseudostate(sv) && Model.getFacade().equalsPseudostateKind( Model.getFacade().getKind(sv), Model.getPseudostateKind().getShallowHistory())) { initialStateCount++; } } if (initialStateCount > 1) { return PROBLEM_FOUND; } return NO_PROBLEM; }
@Override public boolean predicate2(Object dm, Designer dsgr) { if (!(Model.getFacade().isACompositeState(dm))) { return NO_PROBLEM; } Object cs = /*(MCompositeState)*/ dm; // if this composite state is not attached to a statemachine // it is not the toplevel composite state. if (Model.getFacade().getStateMachine(cs) == null) { return NO_PROBLEM; } Collection peers = Model.getFacade().getSubvertices(cs); int initialStateCount = 0; if (peers == null) { return PROBLEM_FOUND; } for (Iterator iter = peers.iterator(); iter.hasNext();) { Object sv = iter.next(); if (Model.getFacade().isAPseudostate(sv) && (Model.getFacade().getKind(sv).equals( Model.getPseudostateKind().getInitial()))) { initialStateCount++; } } if (initialStateCount == 0) { return PROBLEM_FOUND; } return NO_PROBLEM; }
Clone fragments detected by clone detection tool
File path: /ArgoUML-0.34-src/argouml/src/argouml-app/src/org/argouml/uml/cognitive/critics/CrMultipleShallowHistoryStates.java File path: /ArgoUML-0.34-src/argouml/src/argouml-app/src/org/argouml/uml/cognitive/critics/CrNoInitialState.java
Method name: boolean predicate2(Object, Designer) Method name: boolean predicate2(Object, Designer)
Number of AST nodes: 3 Number of AST nodes: 4
1
@Override
1
@Override
2
    public boolean predicate2(Object dm, Designer dsgr) {
2
    public boolean predicate2(Object dm, Designer dsgr) {
3
        if (!(Model.getFacade().isAPseudostate(dm))) {
3
	if (!(Model.getFacade().isACompositeState(dm))) {
4
            return NO_PROBLEM;
4
	    return NO_PROBLEM;
5
        }
5
	}
6
        Object k = Model.getFacade().getKind(dm);
6
	Object cs = /*(MCompositeState)*/ dm;
7
        if (!Model.getFacade()
7
8
                .equalsPseudostateKind(k,
8
	// if this composite state is not attached to a statemachine
9
                        Model.getPseudostateKind().getShallowHistory())) {
9
	// it is not the toplevel composite state.
10
            return NO_PROBLEM;
10
	if (Model.getFacade().getStateMachine(cs) == null) {
11
        }
11
	    return NO_PROBLEM;
12
12
	}
13
        // container state / composite state
13
	Collection peers = Model.getFacade().getSubvertices(cs);
14
        Object cs = Model.getFacade().getContainer(dm);
14
	int initialStateCount = 0;
15
        if (cs == null) {
15
	if (peers == null) {
16
            LOG.debug("null parent state");
16
	    return PROBLEM_FOUND;
17
            return NO_PROBLEM;
17
	}
18
        }
18
	for (Iterator iter = peers.iterator(); iter.hasNext();) {
19
        
19
	    Object sv = iter.next();
20
        int initialStateCount = 0;
20
	    if (Model.getFacade().isAPseudostate(sv)
21
        Collection peers = Model.getFacade().getSubvertices(cs);
21
		&& (Model.getFacade().getKind(sv).equals(
22
        for (Object sv : peers) {
22
                        Model.getPseudostateKind().getInitial()))) {
23
            if (Model.getFacade().isAPseudostate(sv)
23
	        initialStateCount++;
24
                    && Model.getFacade().equalsPseudostateKind(
24
	    }
25
                            Model.getFacade().getKind(sv),
25
	}
26
                            Model.getPseudostateKind().getShallowHistory())) {
26
	if (initialStateCount == 0) {
27
                initialStateCount++;
27
	    return PROBLEM_FOUND;
28
            }
28
	}
29
        }
29
	return NO_PROBLEM;
30
        if (initialStateCount > 1) {
30
    }
31
            return PROBLEM_FOUND;
32
        }
33
        return NO_PROBLEM;
34
    }
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements4
    Number of unmapped statements in the first code fragment0
    Number of unmapped statements in the second code fragment0
    Time elapsed for statement mapping (ms)0.0
    Similarity Score0.636
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    12
    for (Object sv : peers)
    10
    for (Iterator iter = peers.iterator(); iter.hasNext(); )
                                                        
    11
    Object sv = iter.next();
    13
    if (Model.getFacade().isAPseudostate(sv) && Model.getFacade().equalsPseudostateKind(Model.getFacade().getKind(sv), Model.getPseudostateKind().getShallowHistory()))
    13
    if (Model.getFacade().isAPseudostate(sv) && Model.getFacade().equalsPseudostateKind(Model.getFacade().getKind(sv), Model.getPseudostateKind().getShallowHistory()))
    12
    if (Model.getFacade().isAPseudostate(sv) && (Model.getFacade().getKind(sv).equals(Model.getPseudostateKind().getInitial())))
    Differences
    Expression1Expression2Difference
    Model.getFacade().equalsPseudostateKind(Model.getFacade().getKind(sv),Model.getPseudostateKind().getShallowHistory())(Model.getFacade().getKind(sv).equals(Model.getPseudostateKind().getInitial()))TYPE_COMPATIBLE_REPLACEMENT
    Preondition Violations
    Expression Model.getFacade().equalsPseudostateKind(Model.getFacade().getKind(sv),Model.getPseudostateKind().getShallowHistory()) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    12
    if (Model.getFacade().isAPseudostate(sv) && (Model.getFacade().getKind(sv).equals(Model.getPseudostateKind().getInitial())))
    14
    initialStateCount++;
    13
    initialStateCount++;
    Precondition Violations (1)
    Row Violation
    1Expression Model.getFacade().equalsPseudostateKind(Model.getFacade().getKind(sv),Model.getPseudostateKind().getShallowHistory()) cannot be parameterized, because it has dependencies to/from statements that will be extracted