File path: /apache-ant-1.7.0/src/org/apache/tools/ant/types/selectors/SizeSelector.java | File path: /apache-ant-1.7.0/src/org/apache/tools/ant/types/selectors/TypeSelector.java | |||
Method name: void setParameters(Parameter[])
|
Method name: void setParameters(Parameter[])
|
|||
Number of AST nodes: 5 | Number of AST nodes: 5 | |||
1 | if (WHEN_KEY.equalsIgnoreCase(paramname)) {↵ | 1 | if (TYPE_KEY.equalsIgnoreCase(paramname)) {↵ | |
2 | SizeComparisons scmp = new SizeComparisons();↵ | 2 | FileType t = new FileType();↵ | |
3 | scmp.setValue(parameters[i].getValue());↵ | 3 | t.setValue(parameters[i].getValue());↵ | |
4 | setWhen(scmp);↵ | 4 | setType(t);↵ | |
5 | } else {↵ | 5 | } else {↵ | |
6 | setError("Invalid parameter " + paramname);↵ | 6 | setError("Invalid parameter " + paramname);↵ | |
7 | } | 7 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.3 |
Clones location | Clones are in different classes having the same super class |
Number of node comparisons | 26 |
Number of mapped statements | 5 |
Number of unmapped statements in the first code fragment | 0 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 1.7 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
12 | if (WHEN_KEY.equalsIgnoreCase(paramname)) |
| 5 | if (TYPE_KEY.equalsIgnoreCase(paramname)) | ||||||||||||||||||||
13 | SizeComparisons scmp = new SizeComparisons(); |
| 6 | FileType t = new FileType(); | ||||||||||||||||||||
14 | scmp.setValue(parameters[i].getValue()); |
| 7 | t.setValue(parameters[i].getValue()); | ||||||||||||||||||||
15 | setWhen(scmp); |
| 8 | setType(t); | ||||||||||||||||||||
else | else | |||||||||||||||||||||||
16 | setError("Invalid parameter " + paramname); | 9 | setError("Invalid parameter " + paramname); |
Row | Violation |
---|---|
1 | Expression setWhen(scmp) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression setType(t) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Expression setWhen(scmp) is a void method call, and thus it cannot be parameterized |
4 | Expression setType(t) is a void method call, and thus it cannot be parameterized |