File path: /apache-ant-1.7.0/src/org/apache/tools/ant/taskdefs/optional/j2ee/WebLogicHotDeploymentTool.java | File path: /apache-ant-1.7.0/src/org/apache/tools/ant/DirectoryScanner.java | |||
Method name: boolean isActionValid()
|
Method name: boolean isExcluded(String)
|
|||
Number of AST nodes: 4 | Number of AST nodes: 3 | |||
1 | for (int i = 0; i < VALID_ACTIONS.length; i++) {↵ | 1 | for (int i = 0; i < excludePatterns.length; i++) {↵ | |
2 | if (action.equals(VALID_ACTIONS[i])) {↵ | 2 | if (↵ | |
3 | valid = true;↵ | |||
4 | break↵ | 3 | matchPath(excludePatterns[i], name, isCaseSensitive())) {↵ | |
5 | ;↵ | 4 | return true;↵ | |
6 | }↵ | 5 | }↵ | |
7 | } | 6 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2 |
Clones location | Clones are in different classes |
Number of node comparisons | 7 |
Number of mapped statements | 2 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 7.1 |
Clone type | Type 3 |
ID | Statement | ID | Statement | |||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
3 | for (int i = 0; i < VALID_ACTIONS.length; i++) |
| 4 | for (int i = 0; i < excludePatterns.length; i++) | ||||||||||||||||||||
4 | if (action.equals(VALID_ACTIONS[i])) |
| 5 | if (matchPath(excludePatterns[i], name, isCaseSensitive())) | ||||||||||||||||||||
5 | valid = true; |
| | |||||||||||||||||||||
|
| 6 | return true; | |||||||||||||||||||||
6 | break; |
| |
Row | Violation |
---|---|
1 | Expression action.equals(VALID_ACTIONS[i]) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression matchPath(excludePatterns[i],name,isCaseSensitive()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Expression action.equals(VALID_ACTIONS[i]) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
4 | Expression matchPath(excludePatterns[i],name,isCaseSensitive()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
5 | Unmatched statement valid=true; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
6 | Unmatched return true; |
7 | Unmatched break; |