File path: /apache-ant-1.7.0/src/org/apache/tools/ant/taskdefs/optional/jsp/JspNameMangler.java | File path: /apache-ant-1.7.0/src/org/apache/tools/ant/taskdefs/Available.java | |||
Method name: String mapJspToBaseName(File)
|
Method name: boolean checkFile()
|
|||
Number of AST nodes: 4 | Number of AST nodes: 4 | |||
1 | for (int i = 0; i < keywords.length; ++i) {↵ | |||
1 | while (searchParents && parent != null && parent.exists()) {↵ | |||
2 | if (className.equals(keywords[i])) {↵ | 2 | if (c↵ | |
3 | heckFile(new File(parent, filename),↵ | |||
3 | className += "%";↵ | 4 | filename + "↵ | |
5 | in " + parent)) {↵ | |||
4 | break;↵ | 6 | re↵ | |
5 | }↵ | |||
7 | turn true;↵ | |||
8 | }↵ | |||
9 | parent = parent.getParentFile();↵ | |||
6 | } | 10 | } | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.1 |
Clones location | Clones are in different classes |
Number of node comparisons | 7 |
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 0.4 |
Clone type | Type 3 |
ID | Statement | ID | Statement | |||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
4 | if (className.equals(keywords[i])) |
| 31 | if (checkFile(new File(parent, filename), filename + " in " + parent)) | ||||||||||||||||
5 | className += "%"; |
| | |||||||||||||||||
6 | break; |
| | |||||||||||||||||
|
| 32 | return true; |
Row | Violation |
---|---|
1 | Unmatched statement className+="%"; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Unmatched break; |
3 | Unmatched return true; |