File path: /apache-ant-1.7.0/src/org/apache/tools/ant/types/EnumeratedAttribute.java | File path: /apache-ant-1.7.0/src/org/apache/tools/ant/DirectoryScanner.java | |||
Method name: int indexOfValue(String)
|
Method name: boolean isExcluded(String)
|
|||
Number of AST nodes: 3 | Number of AST nodes: 3 | |||
1 | for (int i = 0; i < values.length; i++) {↵ | 1 | for (int i = 0; i < excludePatterns.length; i++) {↵ | |
2 | if (value.equals(values[i])) {↵ | 2 | if (matchPath(excludePatterns[i], name, isCaseSensitive())) {↵ | |
3 | return i;↵ | 3 | return true;↵ | |
4 | }↵ | 4 | }↵ | |
5 | } | 5 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2 |
Clones location | Clones are in different classes |
Number of node comparisons | 5 |
Number of mapped statements | 2 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 7.2 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
4 | for (int i = 0; i < values.length; i++) |
| 4 | for (int i = 0; i < excludePatterns.length; i++) | ||||||||||||||||||||
5 | if (value.equals(values[i])) |
| 5 | if (matchPath(excludePatterns[i], name, isCaseSensitive())) | ||||||||||||||||||||
|
| 6 | return true; | |||||||||||||||||||||
6 | return i; |
| |
Row | Violation |
---|---|
1 | Expression value.equals(values[i]) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression matchPath(excludePatterns[i],name,isCaseSensitive()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Expression value.equals(values[i]) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
4 | Expression matchPath(excludePatterns[i],name,isCaseSensitive()) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
5 | Unmatched return true; |
6 | Unmatched statement return i; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
7 | Unmatched return i; |
8 | Clone fragment #1 returns variables i , while Clone fragment #2 returns variables |