File path: /apache-ant-1.7.0/src/org/apache/tools/ant/types/CommandlineJava.java | File path: /apache-ant-1.7.0/src/org/apache/tools/ant/taskdefs/optional/dotnet/NetCommand.java | |||
Method name: void addDefinitionsToList(ListIterator)
|
Method name: void addArguments(String[])
|
|||
Number of AST nodes: 3 | Number of AST nodes: 3 | |||
1 | if (props != null) {↵ | 1 | if (arguments != null && arguments.length != 0) {↵ | |
2 | for (int i = 0; i < props.length; i++) {↵ | 2 | for (int i = 0; i < arguments.length; i++) {↵ | |
3 | listIt.add("-D" + props[i]);↵ | 3 | addArgument(arguments[i]);↵ | |
4 | }↵ | 4 | ↵ | |
5 | ↵ | 5 | }↵ | |
6 | } | 6 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2 |
Clones location | Clones are in different classes |
Number of node comparisons | 5 |
Number of mapped statements | 2 |
Number of unmapped statements in the first code fragment | 0 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 2.2 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
3 | for (int i = 0; i < props.length; i++) |
| 2 | for (int i = 0; i < arguments.length; i++) | ||||||||||||||||||||||||||
4 | listIt.add("-D" + props[i]); |
| 3 | addArgument(arguments[i]); |
Row | Violation |
---|---|
1 | Expression listIt.add("-D" + props[i]) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression addArgument(arguments[i]) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Expression listIt.add("-D" + props[i]) is a void method call, and thus it cannot be parameterized |
4 | Expression addArgument(arguments[i]) is a void method call, and thus it cannot be parameterized |
5 | Expression "-D" + props[i] cannot be parameterized, because it has dependencies to/from statements that will be extracted |
6 | Expression arguments[i] cannot be parameterized, because it has dependencies to/from statements that will be extracted |
7 | Expression listIt.add("-D" + props[i]) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
8 | Expression addArgument(arguments[i]) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
9 | Expression listIt.add("-D" + props[i]) is a void method call, and thus it cannot be parameterized |
10 | Expression addArgument(arguments[i]) is a void method call, and thus it cannot be parameterized |