File path: /apache-ant-1.7.0/src/org/apache/tools/ant/util/DOMElementWriter.java | File path: /apache-ant-1.7.0/src/org/apache/tools/ant/util/DOMElementWriter.java | |||
Method name: boolean isReference(String)
|
Method name: boolean isReference(String)
|
|||
Number of AST nodes: 3 | Number of AST nodes: 3 | |||
1 | try {↵ | 1 | try {↵ | |
2 | Integer.parseInt(ent.substring(2, ent.length() - 1));↵ | 2 | Integer.parseInt(ent.substring(3, ent.length() - 1), 16);↵ | |
3 | return true;↵ | 3 | return true;↵ | |
4 | } catch (NumberFormatException nfe) {↵ | 4 | } catch (NumberFormatException nfe) {↵ | |
5 | return false;↵ | 5 | return false;↵ | |
6 | } | 6 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.1 |
Clones location | Clones are in the same method |
Number of node comparisons | 9 |
Number of mapped statements | 3 |
Number of unmapped statements in the first code fragment | 0 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 0.4 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
8 | try | 5 | try | |||||||||||||
9 | Integer.parseInt(ent.substring(2, ent.length() - 1)); |
| 6 | Integer.parseInt(ent.substring(3, ent.length() - 1), 16); | ||||||||||||
10 | return true; |
| 7 | return true; |
Row | Violation |
---|---|
1 | Expression Integer.parseInt(ent.substring(2,ent.length() - 1)) is a method call throwing exception(s) that should be caught by a try block that will be extracted |
2 | Expression Integer.parseInt(ent.substring(3,ent.length() - 1),16) is a method call throwing exception(s) that should be caught by a try block that will be extracted |
3 | Conditional return true; |
4 | Conditional return true; |