if (it.hasNext()) { PhoneModel m = (PhoneModel) it.next(); fillPhoneView(m, telephoneComboBox1, telephoneTextField1); } if (it.hasNext()) { PhoneModel m = (PhoneModel) it.next(); fillPhoneView(m, telephoneComboBox2, telephoneTextField2); }
if (it.hasNext()) { IEmailModel m = (IEmailModel) it.next(); fillEmailView(m, emailComboBox1, emailTextField1); } if (it.hasNext()) { IEmailModel m = (IEmailModel) it.next(); fillEmailView(m, emailComboBox2, emailTextField2); }
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/gui/dialog/contact/ContactEditorDialog.java File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/gui/dialog/contact/ContactEditorDialog.java
Method name: void updateComponents(boolean) Method name: void updateComponents(boolean)
Number of AST nodes: 6 Number of AST nodes: 6
1
if (it.hasNext()) {
1
if (it.hasNext()) {
2
				PhoneModel m = (PhoneModel) it.next();
2
				IEmailModel m = (IEmailModel) it.next();
3
				fillPhoneView(m, telephoneComboBox1, telephoneTextField1);
3
				fillEmailView(m, emailComboBox1, emailTextField1);
4
			}
4
			}
5
			if (it.hasNext()) {
5
			if (it.hasNext()) {
6
				PhoneModel m = (PhoneModel) it.next();
6
				IEmailModel m = (IEmailModel) it.next();
7
				fillPhoneView(m, telephoneComboBox2, telephoneTextField2);
7
				fillEmailView(m, emailComboBox2, emailTextField2);
8
			}
8
			}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.3
Clones locationClones are in the same method
Number of node comparisons29
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements4
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)54.8
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    40
    if (it.hasNext())
    30
    if (it.hasNext())
                                                                                      
    31
    IEmailModel m = (IEmailModel)it.next();
    Preondition Violations
    Unmatched statement IEmailModel m=(IEmailModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    31
    IEmailModel m = (IEmailModel)it.next();
    41
    PhoneModel m = (PhoneModel)it.next();
    41
    PhoneModel m = (PhoneModel)it.next();
    Preondition Violations
    Unmatched statement PhoneModel m=(PhoneModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
                                                                                  
    42
    fillPhoneView(m, telephoneComboBox1, telephoneTextField1);
    42
    fillPhoneView(m, telephoneComboBox1, telephoneTextField1);
    32
    fillEmailView(m, emailComboBox2, emailTextField2);
    Differences
    Expression1Expression2Difference
    fillPhoneViewfillEmailViewMETHOD_INVOCATION_NAME_MISMATCH
    org.columba.addressbook.model.PhoneModelorg.columba.addressbook.model.IEmailModelVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Expression fillPhoneView(m,telephoneComboBox1,telephoneTextField1) is a void method call, and thus it cannot be parameterized
    Expression fillEmailView(m,emailComboBox2,emailTextField2) is a void method call, and thus it cannot be parameterized
    Type org.columba.addressbook.model.PhoneModel of variable m does not match with type org.columba.addressbook.model.IEmailModel of variable m
    • Make classes org.columba.addressbook.model.PhoneModel and org.columba.addressbook.model.IEmailModel extend a common superclass
    32
    fillEmailView(m, emailComboBox2, emailTextField2);
    43
    if (it.hasNext())
    27
    if (it.hasNext())
                                                                                      
    28
    IEmailModel m = (IEmailModel)it.next();
    Preondition Violations
    Unmatched statement IEmailModel m=(IEmailModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    28
    IEmailModel m = (IEmailModel)it.next();
    44
    PhoneModel m = (PhoneModel)it.next();
    44
    PhoneModel m = (PhoneModel)it.next();
    Preondition Violations
    Unmatched statement PhoneModel m=(PhoneModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
                                                                                  
    45
    fillPhoneView(m, telephoneComboBox2, telephoneTextField2);
    45
    fillPhoneView(m, telephoneComboBox2, telephoneTextField2);
    29
    fillEmailView(m, emailComboBox1, emailTextField1);
    Differences
    Expression1Expression2Difference
    fillPhoneViewfillEmailViewMETHOD_INVOCATION_NAME_MISMATCH
    org.columba.addressbook.model.PhoneModelorg.columba.addressbook.model.IEmailModelVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Expression fillPhoneView(m,telephoneComboBox2,telephoneTextField2) is a void method call, and thus it cannot be parameterized
    Expression fillEmailView(m,emailComboBox1,emailTextField1) is a void method call, and thus it cannot be parameterized
    Type org.columba.addressbook.model.PhoneModel of variable m does not match with type org.columba.addressbook.model.IEmailModel of variable m
    • Make classes org.columba.addressbook.model.PhoneModel and org.columba.addressbook.model.IEmailModel extend a common superclass
    29
    fillEmailView(m, emailComboBox1, emailTextField1);
    Precondition Violations (10)
    Row Violation
    1Unmatched statement IEmailModel m=(IEmailModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    2Unmatched statement PhoneModel m=(PhoneModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    3Expression fillPhoneView(m,telephoneComboBox1,telephoneTextField1) is a void method call, and thus it cannot be parameterized
    4Expression fillEmailView(m,emailComboBox2,emailTextField2) is a void method call, and thus it cannot be parameterized
    5Type org.columba.addressbook.model.PhoneModel of variable m does not match with type org.columba.addressbook.model.IEmailModel of variable m
    6Unmatched statement IEmailModel m=(IEmailModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    7Unmatched statement PhoneModel m=(PhoneModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    8Expression fillPhoneView(m,telephoneComboBox2,telephoneTextField2) is a void method call, and thus it cannot be parameterized
    9Expression fillEmailView(m,emailComboBox1,emailTextField1) is a void method call, and thus it cannot be parameterized
    10Type org.columba.addressbook.model.PhoneModel of variable m does not match with type org.columba.addressbook.model.IEmailModel of variable m