File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/parser/VCardParser.java | File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/parser/VCardParser.java | |||
Method name: void write(IContactModel, OutputStream)
|
Method name: void write(IContactModel, OutputStream)
|
|||
Number of AST nodes: 9 | Number of AST nodes: 8 | |||
1 | for (int i = 0; i < s.length; i++) {↵ | |||
2 | identity.addAdditionalName(s[i]);↵ | |||
3 | }↵ | |||
4 | // add all nicknames↵ | |||
1 | s = ParserUtil.getArrayOfString(c.getNickName(), ",");↵ | 5 | s = ParserUtil.getArrayOfString(c.getNickName(), ",");↵ | |
2 | for (int i = 0; i < s.length; i++) {↵ | 6 | for (int i = 0; i < s.length; i++) {↵ | |
3 | identity.addNickname(s[i]);↵ | 7 | identity.addNickname(s[i]);↵ | |
4 | }↵ | 8 | }↵ | |
5 | // add all prefixes↵ | 9 | // add all prefixes↵ | |
6 | s = ParserUtil.getArrayOfString(c.getNamePrefix(), ",");↵ | 10 | s = ParserUtil.getArrayOfString(c.getNamePrefix(), ",");↵ | |
7 | for (int i = 0; i < s.length; i++) {↵ | 11 | for (int i = 0; i < s.length; i++) {↵ | |
8 | identity.addPrefix(s[i]);↵ | 12 | identity.addPrefix(s[i]);↵ | |
9 | }↵ | 13 |
| |
10 | // add all suffixes↵ | |||
11 | s = ParserUtil.getArrayOfString(c.getNameSuffix(), ",");↵ | |||
12 | for (int i = 0; i < s.length; i++) {↵ | |||
13 | identity.addSuffix(s[i]);↵ | |||
14 | } | |||
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.8 |
Clones location | Clones are in the same method |
Number of node comparisons | 34 |
Number of mapped statements | 8 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 0 |
Time elapsed for statement mapping (ms) | 2.1 |
Clone type | Type 3 |
ID | Statement | ID | Statement | |||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
15 | s = ParserUtil.getArrayOfString(c.getNickName(), ","); | 15 | s = ParserUtil.getArrayOfString(c.getNickName(), ","); | |||||||||||||||
16 | for (int i = 0; i < s.length; i++) | 16 | for (int i = 0; i < s.length; i++) | |||||||||||||||
17 | identity.addNickname(s[i]); | 17 | identity.addNickname(s[i]); | |||||||||||||||
18 | s = ParserUtil.getArrayOfString(c.getNamePrefix(), ","); | 18 | s = ParserUtil.getArrayOfString(c.getNamePrefix(), ","); | |||||||||||||||
19 | for (int i = 0; i < s.length; i++) | 19 | for (int i = 0; i < s.length; i++) | |||||||||||||||
20 | identity.addPrefix(s[i]); | 20 | identity.addPrefix(s[i]); | |||||||||||||||
21 | s = ParserUtil.getArrayOfString(c.getNameSuffix(), ","); |
| | |||||||||||||||
22 | for (int i = 0; i < s.length; i++) | 13 | for (int i = 0; i < s.length; i++) | |||||||||||||||
23 | identity.addSuffix(s[i]); |
| 14 | identity.addAdditionalName(s[i]); |
Row | Violation |
---|---|
1 | Unmatched statement s=ParserUtil.getArrayOfString(c.getNameSuffix(),","); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Expression identity.addSuffix(s[i]) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Expression identity.addAdditionalName(s[i]) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
4 | Expression identity.addSuffix(s[i]) is a void method call, and thus it cannot be parameterized |
5 | Expression identity.addAdditionalName(s[i]) is a void method call, and thus it cannot be parameterized |