if (it.hasNext()) { InstantMessagingModel m = (InstantMessagingModel) it.next(); fillIMView(m, imComboBox1, imTextField1); } if (it.hasNext()) { InstantMessagingModel m = (InstantMessagingModel) it.next(); fillIMView(m, imComboBox2, imTextField2); } if (it.hasNext()) { InstantMessagingModel m = (InstantMessagingModel) it.next(); fillIMView(m, imComboBox3, imTextField3); }
if (it.hasNext()) { IEmailModel m = (IEmailModel) it.next(); fillEmailView(m, emailComboBox1, emailTextField1); } if (it.hasNext()) { IEmailModel m = (IEmailModel) it.next(); fillEmailView(m, emailComboBox2, emailTextField2); } if (it.hasNext()) { IEmailModel m = (IEmailModel) it.next(); fillEmailView(m, emailComboBox3, emailTextField3); }
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/gui/dialog/contact/ContactEditorDialog.java File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/gui/dialog/contact/ContactEditorDialog.java
Method name: void updateComponents(boolean) Method name: void updateComponents(boolean)
Number of AST nodes: 9 Number of AST nodes: 9
1
if (it.hasNext()) {
1
if (it.hasNext()) {
2
				InstantMessagingModel m = (InstantMessagingModel) it.next();
2
				IEmailModel m = (IEmailModel) it.next();
3
				fillIMView(m, imComboBox1, imTextField1);
3
				fillEmailView(m, emailComboBox1, emailTextField1);
4
			}
4
			}
5
			if (it.hasNext()) {
5
			if (it.hasNext()) {
6
				InstantMessagingModel m = (InstantMessagingModel) it.next();
6
				IEmailModel m = (IEmailModel) it.next();
7
				fillIMView(m, imComboBox2, imTextField2);
7
				fillEmailView(m, emailComboBox2, emailTextField2);
8
			}
8
			}
9
			if (it.hasNext()) {
9
			if (it.hasNext()) {
10
				InstantMessagingModel m = (InstantMessagingModel) it.next();
10
				IEmailModel m = (IEmailModel) it.next();
11
				fillIMView(m, imComboBox3, imTextField3);
11
				fillEmailView(m, emailComboBox3, emailTextField3);
12
			}
12
			}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.5
Clones locationClones are in the same method
Number of node comparisons58
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements6
    Number of unmapped statements in the first code fragment3
    Number of unmapped statements in the second code fragment3
    Time elapsed for statement mapping (ms)102.0
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    53
    if (it.hasNext())
    33
    if (it.hasNext())
                                                                                      
    34
    IEmailModel m = (IEmailModel)it.next();
    Preondition Violations
    Unmatched statement IEmailModel m=(IEmailModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    34
    IEmailModel m = (IEmailModel)it.next();
    54
    InstantMessagingModel m = (InstantMessagingModel)it.next();
    54
    InstantMessagingModel m = (InstantMessagingModel)it.next();
    Preondition Violations
    Unmatched statement InstantMessagingModel m=(InstantMessagingModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
                                                                                                                              
    55
    fillIMView(m, imComboBox1, imTextField1);
    55
    fillIMView(m, imComboBox1, imTextField1);
    35
    fillEmailView(m, emailComboBox3, emailTextField3);
    Differences
    Expression1Expression2Difference
    fillIMViewfillEmailViewMETHOD_INVOCATION_NAME_MISMATCH
    org.columba.addressbook.model.InstantMessagingModelorg.columba.addressbook.model.IEmailModelVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Expression fillIMView(m,imComboBox1,imTextField1) is a void method call, and thus it cannot be parameterized
    Expression fillEmailView(m,emailComboBox3,emailTextField3) is a void method call, and thus it cannot be parameterized
    Type org.columba.addressbook.model.InstantMessagingModel of variable m does not match with type org.columba.addressbook.model.IEmailModel of variable m
    • Make classes org.columba.addressbook.model.InstantMessagingModel and org.columba.addressbook.model.IEmailModel extend a common superclass
    35
    fillEmailView(m, emailComboBox3, emailTextField3);
    56
    if (it.hasNext())
    30
    if (it.hasNext())
                                                                                      
    31
    IEmailModel m = (IEmailModel)it.next();
    Preondition Violations
    Unmatched statement IEmailModel m=(IEmailModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    31
    IEmailModel m = (IEmailModel)it.next();
    57
    InstantMessagingModel m = (InstantMessagingModel)it.next();
    57
    InstantMessagingModel m = (InstantMessagingModel)it.next();
    Preondition Violations
    Unmatched statement InstantMessagingModel m=(InstantMessagingModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
                                                                                                                              
    58
    fillIMView(m, imComboBox2, imTextField2);
    58
    fillIMView(m, imComboBox2, imTextField2);
    32
    fillEmailView(m, emailComboBox2, emailTextField2);
    Differences
    Expression1Expression2Difference
    fillIMViewfillEmailViewMETHOD_INVOCATION_NAME_MISMATCH
    org.columba.addressbook.model.InstantMessagingModelorg.columba.addressbook.model.IEmailModelVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Expression fillIMView(m,imComboBox2,imTextField2) is a void method call, and thus it cannot be parameterized
    Expression fillEmailView(m,emailComboBox2,emailTextField2) is a void method call, and thus it cannot be parameterized
    Type org.columba.addressbook.model.InstantMessagingModel of variable m does not match with type org.columba.addressbook.model.IEmailModel of variable m
    • Make classes org.columba.addressbook.model.InstantMessagingModel and org.columba.addressbook.model.IEmailModel extend a common superclass
    32
    fillEmailView(m, emailComboBox2, emailTextField2);
    59
    if (it.hasNext())
    27
    if (it.hasNext())
                                                                                      
    28
    IEmailModel m = (IEmailModel)it.next();
    Preondition Violations
    Unmatched statement IEmailModel m=(IEmailModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    28
    IEmailModel m = (IEmailModel)it.next();
    60
    InstantMessagingModel m = (InstantMessagingModel)it.next();
    60
    InstantMessagingModel m = (InstantMessagingModel)it.next();
    Preondition Violations
    Unmatched statement InstantMessagingModel m=(InstantMessagingModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
                                                                                                                              
    61
    fillIMView(m, imComboBox3, imTextField3);
    61
    fillIMView(m, imComboBox3, imTextField3);
    29
    fillEmailView(m, emailComboBox1, emailTextField1);
    Differences
    Expression1Expression2Difference
    fillIMViewfillEmailViewMETHOD_INVOCATION_NAME_MISMATCH
    org.columba.addressbook.model.InstantMessagingModelorg.columba.addressbook.model.IEmailModelVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Expression fillIMView(m,imComboBox3,imTextField3) is a void method call, and thus it cannot be parameterized
    Expression fillEmailView(m,emailComboBox1,emailTextField1) is a void method call, and thus it cannot be parameterized
    Type org.columba.addressbook.model.InstantMessagingModel of variable m does not match with type org.columba.addressbook.model.IEmailModel of variable m
    • Make classes org.columba.addressbook.model.InstantMessagingModel and org.columba.addressbook.model.IEmailModel extend a common superclass
    29
    fillEmailView(m, emailComboBox1, emailTextField1);
    Precondition Violations (15)
    Row Violation
    1Unmatched statement IEmailModel m=(IEmailModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    2Unmatched statement InstantMessagingModel m=(InstantMessagingModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    3Expression fillIMView(m,imComboBox1,imTextField1) is a void method call, and thus it cannot be parameterized
    4Expression fillEmailView(m,emailComboBox3,emailTextField3) is a void method call, and thus it cannot be parameterized
    5Type org.columba.addressbook.model.InstantMessagingModel of variable m does not match with type org.columba.addressbook.model.IEmailModel of variable m
    6Unmatched statement IEmailModel m=(IEmailModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    7Unmatched statement InstantMessagingModel m=(InstantMessagingModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    8Expression fillIMView(m,imComboBox2,imTextField2) is a void method call, and thus it cannot be parameterized
    9Expression fillEmailView(m,emailComboBox2,emailTextField2) is a void method call, and thus it cannot be parameterized
    10Type org.columba.addressbook.model.InstantMessagingModel of variable m does not match with type org.columba.addressbook.model.IEmailModel of variable m
    11Unmatched statement IEmailModel m=(IEmailModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    12Unmatched statement InstantMessagingModel m=(InstantMessagingModel)it.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
    13Expression fillIMView(m,imComboBox3,imTextField3) is a void method call, and thus it cannot be parameterized
    14Expression fillEmailView(m,emailComboBox1,emailTextField1) is a void method call, and thus it cannot be parameterized
    15Type org.columba.addressbook.model.InstantMessagingModel of variable m does not match with type org.columba.addressbook.model.IEmailModel of variable m