Element child = getParentElement().getChild(VCARD.TEL); // if not specified return empty iterator if (child == null) return new Vector().iterator(); Iterator it = child.getChildren().iterator(); Vector v = new Vector(); while (it.hasNext()) { Element e = (Element) it.next(); v.add(new PhoneModel(e.getValue(), e.getName())); } return v.iterator();
Element child = getParentElement().getChild(VCARD.IM); // if not specified return empty iterator if (child == null) return new Vector().iterator(); Iterator it = child.getChildren().iterator(); Vector v = new Vector(); while (it.hasNext()) { Element e = (Element) it.next(); v.add(new InstantMessagingModel(e.getValue(), e.getName())); } return v.iterator();
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/parser/XMLContactDocumentParser.java File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/parser/XMLContactDocumentParser.java
Method name: Iterator getPhoneIterator() Method name: Iterator getInstantMessagingIterator()
Number of AST nodes: 9 Number of AST nodes: 9
1
Element child = getParentElement().getChild(VCARD.TEL);
1
Element child = getParentElement().getChild(VCARD.IM);
2
		// if not specified return empty iterator
2
		// if not specified return empty iterator
3
		if (child == null)
3
		if (child == null)
4
			return new Vector().iterator();
4
			return new Vector().iterator();
5
		Iterator it = child.getChildren().iterator();
5
		Iterator it = child.getChildren().iterator();
6
		Vector v = new Vector();
6
		Vector v = new Vector();
7
		while (it.hasNext()) {
7
		while (it.hasNext()) {
8
			Element e = (Element) it.next();
8
			Element e = (Element) it.next();
9
			v.add(new PhoneModel(e.getValue(), e.getName()));
9
			v.add(new InstantMessagingModel(e.getValue(), e.getName()));
10
		}
10
		}
11
		return v.iterator();
11
		return v.iterator();
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.2
Clones locationClones are declared in the same class
Number of node comparisons30
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements9
    Number of unmapped statements in the first code fragment0
    Number of unmapped statements in the second code fragment0
    Time elapsed for statement mapping (ms)8.9
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    Element child = getParentElement().getChild(VCARD.TEL);
    1
    Element child = getParentElement().getChild(VCARD.TEL);
    1
    Element child = getParentElement().getChild(VCARD.IM);
    Differences
    Expression1Expression2Difference
    TELIMVARIABLE_NAME_MISMATCH
    1
    Element child = getParentElement().getChild(VCARD.IM);
    2
    if (child == null)
    2
    if (child == null)
    3
    return new Vector().iterator();
    3
    return new Vector().iterator();
    4
    Iterator it = child.getChildren().iterator();
    4
    Iterator it = child.getChildren().iterator();
    5
    Vector v = new Vector();
    5
    Vector v = new Vector();
    6
    while (it.hasNext())
    6
    while (it.hasNext())
    7
    Element e = (Element)it.next();
    7
    Element e = (Element)it.next();
    8
    v.add(new PhoneModel(e.getValue(), e.getName()));
    8
    v.add(new PhoneModel(e.getValue(), e.getName()));
    8
    v.add(new InstantMessagingModel(e.getValue(), e.getName()));
    Differences
    Expression1Expression2Difference
    org.columba.addressbook.model.PhoneModelorg.columba.addressbook.model.InstantMessagingModelVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Expression new PhoneModel(e.getValue(),e.getName()) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Expression new InstantMessagingModel(e.getValue(),e.getName()) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    Type org.columba.addressbook.model.PhoneModel of variable new PhoneModel(e.getValue(),e.getName()) does not match with type org.columba.addressbook.model.InstantMessagingModel of variable new InstantMessagingModel(e.getValue(),e.getName())
    • Make classes org.columba.addressbook.model.PhoneModel and org.columba.addressbook.model.InstantMessagingModel extend a common superclass
    8
    v.add(new InstantMessagingModel(e.getValue(), e.getName()));
    9
    return v.iterator();
    9
    return v.iterator();
    Precondition Violations (3)
    Row Violation
    1Expression new PhoneModel(e.getValue(),e.getName()) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    2Expression new InstantMessagingModel(e.getValue(),e.getName()) cannot be parameterized, because it has dependencies to/from statements that will be extracted
    3Type org.columba.addressbook.model.PhoneModel of variable new PhoneModel(e.getValue(),e.getName()) does not match with type org.columba.addressbook.model.InstantMessagingModel of variable new InstantMessagingModel(e.getValue(),e.getName())