File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/model/GroupModel.java | File path: /columba-1.4-src/core/src/main/java/org/columba/core/gui/frame/FrameManager.java | |||
Method name: XmlElement getMember(Object)
|
Method name: ViewItem createCustomViewItem(String)
|
|||
Number of AST nodes: 5 | Number of AST nodes: 5 | |||
1 | for (int i = 0; i < members.count(); i++) {↵ | 1 | for (int i = 0; i < custom.count(); i++) {↵ | |
2 | XmlElement m = members.getElement(i);↵ | 2 | XmlElement child = custom.getElement(i);↵ | |
3 | Integer str = new Integer(m.getAttribute("uid"));↵ | 3 | String name = child.getAttribute("id");↵ | |
4 | if ( str.equals(uid) )↵ | 4 | if (name.equals(id))↵ | |
5 | return m;↵ | 5 | return new ViewItem(child);↵ | |
6 | } | 6 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.3 |
Clones location | Clones are in different classes |
Number of node comparisons | 13 |
Number of mapped statements | 3 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 0.7 |
Clone type | Type 2 |
ID | Statement | ID | Statement | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
2 | for (int i = 0; i < members.count(); i++) |
| 5 | for (int i = 0; i < custom.count(); i++) | |||||||||||||||||||||
3 | XmlElement m = members.getElement(i); |
| 6 | XmlElement child = custom.getElement(i); | |||||||||||||||||||||
4 | Integer str = new Integer(m.getAttribute("uid")); |
| | ||||||||||||||||||||||
|
| 7 | String name = child.getAttribute("id"); | ||||||||||||||||||||||
5 | if (str.equals(uid)) |
| 8 | if (name.equals(id)) | |||||||||||||||||||||
6 | return m; |
| | ||||||||||||||||||||||
|
| 9 | return new ViewItem(child); |
Row | Violation |
---|---|
1 | Unmatched statement Integer str=new Integer(m.getAttribute("uid")); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Unmatched statement String name=child.getAttribute("id"); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
3 | Type java.lang.Object of variable uid does not match with type java.lang.String of variable id |
4 | Type java.lang.Integer of variable str does not match with type java.lang.String of variable name |
5 | Unmatched statement return m; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
6 | Unmatched return m; |
7 | Unmatched statement return new ViewItem(child); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
8 | Unmatched return new ViewItem(child); |