File path: /columba-1.4-src/calendar/src/main/java/org/columba/calendar/store/StoreEventDelegator.java | File path: /columba-1.4-src/core/src/main/java/org/columba/core/search/SearchManager.java | |||
Method name: void processCalendarEvents()
|
Method name: void execute(IWorkerStatusController)
|
|||
Number of AST nodes: 4 | Number of AST nodes: 3 | |||
1 | String activityId = model.getId();↵ | |||
2 | // remove old activity↵ | |||
3 | ActivityDepository.getInstance()↵ | |||
4 | .removeBrokedActivityById(activityId↵ | 1 | ISearchCriteria c = it2.next();↵ | |
2 | String searchCriteriaTechnicalName = c↵ | |||
5 | );↵ | 3 | .getTechnicalName();↵ | |
6 | // create new activity↵ | 4 | // ↵ | |
7 | Activity act = CalendarHelper↵ | |||
8 | .createActivity((IEventInfo) model);↵ | |||
9 | ActivityDepository.getInstance().addBrokedActivity(act,↵ | |||
10 | this, CategoryStructureEvent.ADDED_CREATED↵ | 5 | execute search↵ | |
6 | doExecute(ref.getSearchTerm(), p,↵ | |||
7 | searchCriteriaTechnicalName, ref↵ | |||
8 | .isSearchInside(), ref.getStartIndex(),↵ | |||
11 | ); | 9 | ref.getResultCount()); | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.0 |
Clones location | Clones are in different classes |
Number of node comparisons | 12 |
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 3 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 0.0 |
Clone type | Type 3 |
ID | Statement | ID | Statement | |||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 8 | ISearchCriteria c = it2.next(); | ||||||||||||||||||||||
|
| 9 | String searchCriteriaTechnicalName = c.getTechnicalName(); | |||||||||||||||||||||
30 | String activityId = model.getId(); | | ||||||||||||||||||||||
31 | ActivityDepository.getInstance().removeBrokedActivityById(activityId); | | ||||||||||||||||||||||
32 | Activity act = CalendarHelper.createActivity((IEventInfo)model); |
| | |||||||||||||||||||||
33 | ActivityDepository.getInstance().addBrokedActivity(act, this, CategoryStructureEvent.ADDED_CREATED); |
| 10 | doExecute(ref.getSearchTerm(), p, searchCriteriaTechnicalName, ref.isSearchInside(), ref.getStartIndex(), ref.getResultCount()); |
Row | Violation |
---|---|
1 | Unmatched statement String searchCriteriaTechnicalName=c.getTechnicalName(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Unmatched statement Activity act=CalendarHelper.createActivity((IEventInfo)model); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
3 | Expression ActivityDepository.getInstance().addBrokedActivity(act,this,CategoryStructureEvent.ADDED_CREATED) is a void method call, and thus it cannot be parameterized |
4 | Expression doExecute(ref.getSearchTerm(),p,searchCriteriaTechnicalName,ref.isSearchInside(),ref.getStartIndex(),ref.getResultCount()) is a void method call, and thus it cannot be parameterized |
5 | Expression ActivityDepository.getInstance().addBrokedActivity(act,this,CategoryStructureEvent.ADDED_CREATED) is a void method call, and thus it cannot be parameterized |
6 | Expression doExecute(ref.getSearchTerm(),p,searchCriteriaTechnicalName,ref.isSearchInside(),ref.getStartIndex(),ref.getResultCount()) is a void method call, and thus it cannot be parameterized |