File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/facade/ContactFacade.java | File path: /columba-1.4-src/core/src/main/java/org/columba/core/search/SearchManager.java | |||
Method name: List
|
Method name: void execute(IWorkerStatusController)
|
|||
Number of AST nodes: 4 | Number of AST nodes: 3 | |||
1 | while (it.hasNext()) {↵ | |||
2 | IContactModelPartial partial = it.next();↵ | |||
3 | IContactItem item = createContactItem(partial);↵ | |||
4 | groupItem.addContact(item);↵ | |||
5 | } | 1 | String providerTechnicalName = ref.getProviderTechnicalName();↵ | |
2 | ISearchProvider p = getProvider(providerTechnicalName);↵ | |||
3 | doExecute(ref.getSearchTerm(), p, ref↵ | |||
4 | .getSearchCriteriaTechnicalName(),↵ | |||
5 | ref.isSearchInside(), ref.getStartIndex(), ref↵ | |||
6 |
| |||
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.0 |
Clones location | Clones are in different classes |
Number of node comparisons | 9 |
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 0.0 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 20 | String providerTechnicalName = ref.getProviderTechnicalName(); | ||||||||||||||||||||||
| 21 | ISearchProvider p = getProvider(providerTechnicalName); | ||||||||||||||||||||||
21 | IContactModelPartial partial = it.next(); | | ||||||||||||||||||||||
22 | IContactItem item = createContactItem(partial); |
| | |||||||||||||||||||||
23 | groupItem.addContact(item); |
| 22 | doExecute(ref.getSearchTerm(), p, ref.getSearchCriteriaTechnicalName(), ref.isSearchInside(), ref.getStartIndex(), ref.getResultCount()); |
Row | Violation |
---|---|
1 | Unmatched statement IContactItem item=createContactItem(partial); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Expression groupItem.addContact(item) is a void method call, and thus it cannot be parameterized |
3 | Expression doExecute(ref.getSearchTerm(),p,ref.getSearchCriteriaTechnicalName(),ref.isSearchInside(),ref.getStartIndex(),ref.getResultCount()) is a void method call, and thus it cannot be parameterized |
4 | Expression groupItem.addContact(item) is a void method call, and thus it cannot be parameterized |
5 | Expression doExecute(ref.getSearchTerm(),p,ref.getSearchCriteriaTechnicalName(),ref.isSearchInside(),ref.getStartIndex(),ref.getResultCount()) is a void method call, and thus it cannot be parameterized |