if (dataStorage == null) { dataStorage = new XmlDataStorage(this); } return dataStorage;
if (defaultAccount == null) { defaultAccount = MailConfig.getInstance().getAccountList() .getDefaultAccount(); } return defaultAccount;
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/folder/AddressbookFolder.java File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/config/AccountItem.java
Method name: DataStorage getDataStorageInstance() Method name: AccountItem getDefaultAccount()
Number of AST nodes: 3 Number of AST nodes: 3
1
if (dataStorage == null) {
1
if (defaultAccount == null) {
2
            dataStorage = new XmlDataStorage(this
2
            defaultAccount = MailConfig.getInstance().getAccountList()
3
);
3
                                                 .getDefaultAccount();
4
        }
4
        }
5
        return dataStorage;
5
        return defaultAccount;
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons5
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)0.4
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    if (dataStorage == null)
    1
    if (dataStorage == null)
    1
    if (defaultAccount == null)
    Differences
    Expression1Expression2Difference
    dataStoragedefaultAccountVARIABLE_NAME_MISMATCH
    org.columba.addressbook.folder.DataStorageorg.columba.mail.config.AccountItemVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.columba.addressbook.folder.DataStorage of variable dataStorage does not match with type org.columba.mail.config.AccountItem of variable defaultAccount
    • Make classes org.columba.addressbook.folder.DataStorage and org.columba.mail.config.AccountItem extend a common superclass
    1
    if (defaultAccount == null)
                                                                                                                                                                    
    2
    defaultAccount = MailConfig.getInstance().getAccountList().getDefaultAccount();
    2
    dataStorage = new XmlDataStorage(this);
                                                                                    
                                                      
    3
    return defaultAccount;
    Preondition Violations
    Unmatched return defaultAccount;
    3
    return defaultAccount;
    3
    return dataStorage;
    3
    return dataStorage;
    Preondition Violations
    Unmatched return dataStorage;
                                                
    Precondition Violations (3)
    Row Violation
    1Type org.columba.addressbook.folder.DataStorage of variable dataStorage does not match with type org.columba.mail.config.AccountItem of variable defaultAccount
    2Unmatched return defaultAccount;
    3Unmatched return dataStorage;