File path: /columba-1.4-src/contact/src/main/java/org/columba/addressbook/facade/ContactFacade.java | File path: /columba-1.4-src/core/src/main/java/org/columba/core/search/SearchManager.java | |||
Method name: void addContact(IContactItem)
|
Method name: void execute(IWorkerStatusController)
|
|||
Number of AST nodes: 3 | Number of AST nodes: 4 | |||
1 | IFolder folder = dialog.getSelectedFolder↵ | 1 | while (it2.hasNext()) {↵ | |
2 | ();↵ | 2 | ISearchCriteria c = it2.next();↵ | |
3 | String uid = folder.getId();↵ | 3 | String ↵ | |
4 | addContact(uid, con↵ | 4 | searchCriteriaTechnicalName = c.getTechnicalName();↵ | |
5 | // execute search↵ | |||
6 | doExecute(ref.getSearchTerm(), p,↵ | |||
7 | searchCriteriaTechnicalName, ref.isSearchInside(),↵ | |||
5 | tactItem); | 8 | ref.getStartIndex(), ref.getResultCount());↵ | |
9 |
| |||
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.0 |
Clones location | Clones are in different classes |
Number of node comparisons | 9 |
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 0.0 |
Clone type | Type 2 |
ID | Statement | ID | Statement | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
6 | IFolder folder = dialog.getSelectedFolder(); | | |||||||||||||||||||
7 | String uid = folder.getId(); | | |||||||||||||||||||
| 16 | ISearchCriteria c = it2.next(); | |||||||||||||||||||
|
| 17 | String searchCriteriaTechnicalName = c.getTechnicalName(); | ||||||||||||||||||
8 | addContact(uid, contactItem); |
| 18 | doExecute(ref.getSearchTerm(), p, searchCriteriaTechnicalName, ref.isSearchInside(), ref.getStartIndex(), ref.getResultCount()); |
Row | Violation |
---|---|
1 | Unmatched statement String searchCriteriaTechnicalName=c.getTechnicalName(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Expression addContact(uid,contactItem) is a void method call, and thus it cannot be parameterized |
3 | Expression doExecute(ref.getSearchTerm(),p,searchCriteriaTechnicalName,ref.isSearchInside(),ref.getStartIndex(),ref.getResultCount()) is a void method call, and thus it cannot be parameterized |
4 | Expression addContact(uid,contactItem) is a void method call, and thus it cannot be parameterized |
5 | Expression doExecute(ref.getSearchTerm(),p,searchCriteriaTechnicalName,ref.isSearchInside(),ref.getStartIndex(),ref.getResultCount()) is a void method call, and thus it cannot be parameterized |