if (signatureFile != null) { String signature = getSignature(signatureFile); if (signature != null) { buf.append("\r\n\r\n"); // TODO: Should we take some action to ensure signature is valid // html? buf.append(signature); } }
AbstractMailCheckingAction action = get(uid); // remove this account if (action != null) { list.remove(action); }
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/composer/MessageComposer.java File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/mailchecking/MailCheckingManager.java
Method name: StreamableMimePart composeHtmlMimePart(boolean) Method name: void remove(int)
Number of AST nodes: 5 Number of AST nodes: 3
1
if (signatureFile != null) {
2
			String signature = getSignature(signatureFile);
3
			if (signature != null) {
4
				buf.append("\r\n\r\n");
5
				// TODO: Should we take some action to ensure signature is valid
6
				// html?
7
				buf.append(signature);
8
			}
9
		
1
AbstractMailCheckingAction action = get(uid);
2
        // remove this account
3
        if (action != null) {
4
            list.remove(action);
10
}
5
        }
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons7
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment3
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)0.7
    Clone typeType 3
    Mapped Statements
    ID Statement ID Statement
                                                                                                
    1
    AbstractMailCheckingAction action = get(uid);
    30
    String signature = getSignature(signatureFile);
                                                                                                      
    31
    if (signature != null)
    31
    if (signature != null)
    2
    if (action != null)
    Differences
    Expression1Expression2Difference
    signatureactionVARIABLE_NAME_MISMATCH
    java.lang.Stringorg.columba.mail.mailchecking.AbstractMailCheckingActionVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type java.lang.String of variable signature does not match with type org.columba.mail.mailchecking.AbstractMailCheckingAction of variable action
    • Make classes java.lang.String and org.columba.mail.mailchecking.AbstractMailCheckingAction extend a common superclass
    2
    if (action != null)
                                                  
    3
    list.remove(action);
    32
    buf.append("\r\n\r\n");
                                                          
    33
    buf.append(signature);
                                                        
    Precondition Violations (1)
    Row Violation
    1Type java.lang.String of variable signature does not match with type org.columba.mail.mailchecking.AbstractMailCheckingAction of variable action