if (myInstance == null) { myInstance = new PGPPassChecker(); } return myInstance;
if (serviceInstance == null) { // load instance of service serviceInstance = loadInstance(implementationName); } return serviceInstance;
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/pgp/PGPPassChecker.java File path: /columba-1.4-src/core/src/main/java/org/columba/core/facade/ServiceFacadeRegistry.java
Method name: PGPPassChecker getInstance() Method name: Object getServiceInstance()
Number of AST nodes: 3 Number of AST nodes: 3
1
if (myInstance == null) {
1
if (serviceInstance == null) {
2
			myInstance = new PGPPassChecker(
2
				// load instance of service
3
);
3
				serviceInstance = loadInstance(implementationName);
4
		}
4
		
5
	}
5
		return myInstance;
6
			return serviceInstance;
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons5
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)0.4
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    if (myInstance == null)
    1
    if (myInstance == null)
    1
    if (serviceInstance == null)
    Differences
    Expression1Expression2Difference
    myInstanceserviceInstanceVARIABLE_NAME_MISMATCH
    org.columba.mail.pgp.PGPPassCheckerjava.lang.ObjectVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.columba.mail.pgp.PGPPassChecker of variable myInstance does not match with type java.lang.Object of variable serviceInstance
    • Make classes org.columba.mail.pgp.PGPPassChecker and java.lang.Object extend a common superclass
    1
    if (serviceInstance == null)
                                                                                                            
    2
    serviceInstance = loadInstance(implementationName);
    2
    myInstance = new PGPPassChecker();
                                                                          
                                                        
    3
    return serviceInstance;
    Preondition Violations
    Unmatched return serviceInstance;
    3
    return serviceInstance;
    3
    return myInstance;
    3
    return myInstance;
    Preondition Violations
    Unmatched return myInstance;
                                              
    Precondition Violations (3)
    Row Violation
    1Type org.columba.mail.pgp.PGPPassChecker of variable myInstance does not match with type java.lang.Object of variable serviceInstance
    2Unmatched return serviceInstance;
    3Unmatched return myInstance;