if (dataStorage == null) { dataStorage = new MboxDataStorage(this); } return dataStorage;
if (spellcheckItem == null) { spellcheckItem = new SpellcheckItem(getRoot().getElement("/options/spellcheck")); } return spellcheckItem;
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/folder/mbox/CachedMboxFolder.java File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/config/ComposerOptionsXmlConfig.java
Method name: IDataStorage getDataStorageInstance() Method name: SpellcheckItem getSpellcheckItem()
Number of AST nodes: 3 Number of AST nodes: 3
1
if (dataStorage == null) {
1
if (spellcheckItem == null) {
2
            dataStorage = new MboxDataStorage(this);
2
            spellcheckItem = new SpellcheckItem(getRoot().getElement("/options/spellcheck"));
3
        }
3
        }
4

4
        return dataStorage;
5
        return spellcheckItem;
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons5
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)0.4
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    if (dataStorage == null)
    1
    if (dataStorage == null)
    1
    if (spellcheckItem == null)
    Differences
    Expression1Expression2Difference
    dataStoragespellcheckItemVARIABLE_NAME_MISMATCH
    org.columba.mail.folder.IDataStorageorg.columba.mail.config.SpellcheckItemVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.columba.mail.folder.IDataStorage of variable dataStorage does not match with type org.columba.mail.config.SpellcheckItem of variable spellcheckItem
    • Make classes org.columba.mail.folder.IDataStorage and org.columba.mail.config.SpellcheckItem extend a common superclass
    1
    if (spellcheckItem == null)
                                                                                                                                                                        
    2
    spellcheckItem = new SpellcheckItem(getRoot().getElement("/options/spellcheck"));
    2
    dataStorage = new MboxDataStorage(this);
                                                                                      
                                                      
    3
    return spellcheckItem;
    Preondition Violations
    Unmatched return spellcheckItem;
    3
    return spellcheckItem;
    3
    return dataStorage;
    3
    return dataStorage;
    Preondition Violations
    Unmatched return dataStorage;
                                                
    Precondition Violations (3)
    Row Violation
    1Type org.columba.mail.folder.IDataStorage of variable dataStorage does not match with type org.columba.mail.config.SpellcheckItem of variable spellcheckItem
    2Unmatched return spellcheckItem;
    3Unmatched return dataStorage;