if (viewItem == null) { viewItem = new ViewItem(getRoot().getElement("/options/gui/viewlist/view")); } return viewItem;
if( dataStorage == null ) { dataStorage = new ZippedMHDataStorage(this.getDirectoryFile()); } return dataStorage;
Clone fragments detected by clone detection tool
File path: /columba-1.4-src/mail/src/main/java/org/columba/mail/config/MainFrameOptionsXmlConfig.java File path: /columba-1.4-src/plugins/org.columba.mail.ZippedMHFolder/src/org/columba/mail/folder/zippedmh/ZippedMHFolder.java
Method name: ViewItem getViewItem() Method name: IDataStorage getDataStorageInstance()
Number of AST nodes: 3 Number of AST nodes: 3
1
if (viewItem == null) {
1
if( dataStorage == null ) {
2
            viewItem = new ViewItem(getRoot().getElement("/options/gui/viewlist/view"));
3
        }
4
        return viewItem
2
			dataStorage = new ZippedMHDataStorage(this.getDirectoryFile());
3
		}
5
;
4
		return dataStorage;
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons5
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)0.3
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    if (viewItem == null)
    1
    if (viewItem == null)
    1
    if (dataStorage == null)
    Differences
    Expression1Expression2Difference
    viewItemdataStorageVARIABLE_NAME_MISMATCH
    org.columba.core.config.ViewItemorg.columba.mail.folder.zippedmh.ZippedMHDataStorageVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type org.columba.core.config.ViewItem of variable viewItem does not match with type org.columba.mail.folder.zippedmh.ZippedMHDataStorage of variable dataStorage
    • Make classes org.columba.core.config.ViewItem and org.columba.mail.folder.zippedmh.ZippedMHDataStorage extend a common superclass
    1
    if (dataStorage == null)
                                                                                                                                    
    2
    dataStorage = new ZippedMHDataStorage(this.getDirectoryFile());
    2
    viewItem = new ViewItem(getRoot().getElement("/options/gui/viewlist/view"));
                                                                                                                                                              
                                                
    3
    return dataStorage;
    Preondition Violations
    Unmatched return dataStorage;
    3
    return dataStorage;
    3
    return viewItem;
    3
    return viewItem;
    Preondition Violations
    Unmatched return viewItem;
                                          
    Precondition Violations (3)
    Row Violation
    1Type org.columba.core.config.ViewItem of variable viewItem does not match with type org.columba.mail.folder.zippedmh.ZippedMHDataStorage of variable dataStorage
    2Unmatched return dataStorage;
    3Unmatched return viewItem;