String propertyName = type.getLHSPropertyName(); if (propertyName==null) { return ArrayHelper.slice( lhsPersister.toColumns(alias, property), begin, type.getColumnSpan(mapping) ); } else { return ( (PropertyMapping) lhsPersister ).toColumns(alias, propertyName); //bad cast }
if ( property == null ) { // this is a virtual id property... return new IdentifierProperty( type, mappedEntity.hasEmbeddedIdentifier(), mappedEntity.hasIdentifierMapper(), unsavedValue, generator ); } else { return new IdentifierProperty( property.getName(), property.getNodeName(), type, mappedEntity.hasEmbeddedIdentifier(), unsavedValue, generator ); }
Clone fragments detected by clone detection tool
File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/engine/JoinHelper.java File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/tuple/PropertyFactory.java
Method name: String[] getAliasedLHSColumnNames(AssociationType, String, int, int, OuterJoinLoadable, Mapping) Method name: IdentifierProperty buildIdentifierProperty(PersistentClass, IdentifierGenerator)
Number of AST nodes: 4 Number of AST nodes: 3
1
String propertyName = type.getLHSPropertyName();
1
if ( property
2
			if (propertyName==null) {
3
				return ArrayHelper.slice( 
4
						lhsPersister.toColumns(alias, pro
2
 == null ) {
3
			// this is a virtual id property...
4
			return new IdentifierProperty(
5
			        type,
6
					mappedEntity.hasEmbeddedIdentifier(),
5
perty), 
7
					mappedEntity.hasIdentifierMapper
6
						begin, 
7
						type.getColumnSpan(mapping) 
8
	
8
(),
9
					unsavedValue,
10
					generator
9
				);
11
				);
10
			}
12
		}
11
			else {
13
		else {
12
				return ( (PropertyMapping) lhsPersister ).toColumns(alias, propertyName); //bad cast
14
			return 
13
	
15
new IdentifierProperty(
16
					property.getName(),
17
					property.getNodeName(),
18
					type,
19
					mappedEntity.hasEmbeddedIdentifier(),
20
					unsavedValue,
21
					generator
22
				);
14
		}
23
		}
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.2
Clones locationClones are in different classes
Number of node comparisons9
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements1
    Number of unmapped statements in the first code fragment3
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)1.2
    Clone typeType 3
    Mapped Statements
    ID Statement ID Statement
    3
    String propertyName = type.getLHSPropertyName();
                                                                                                      
    4
    if (propertyName == null)
    4
    if (propertyName == null)
    5
    if (property == null)
    Differences
    Expression1Expression2Difference
    propertyNamepropertyVARIABLE_NAME_MISMATCH
    java.lang.Stringorg.hibernate.mapping.PropertyVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type java.lang.String of variable propertyName does not match with type org.hibernate.mapping.Property of variable property
    • Make classes java.lang.String and org.hibernate.mapping.Property extend a common superclass
    5
    if (property == null)
    5
    return ArrayHelper.slice(lhsPersister.toColumns(alias, property), begin, type.getColumnSpan(mapping));
    5
    return ArrayHelper.slice(lhsPersister.toColumns(alias, property), begin, type.getColumnSpan(mapping));
    Preondition Violations
    Unmatched return ArrayHelper.slice(lhsPersister.toColumns(alias,property),begin,type.getColumnSpan(mapping));
                                                                                                                                                                                                                
    else
            
    6
    return ((PropertyMapping)lhsPersister).toColumns(alias, propertyName);
    6
    return ((PropertyMapping)lhsPersister).toColumns(alias, propertyName);
    Preondition Violations
    Unmatched return ((PropertyMapping)lhsPersister).toColumns(alias,propertyName);
                                                                                                                                                    
                                                                                                                                                                                                                                                                                              
    7
    return new IdentifierProperty(property.getName(), property.getNodeName(), type, mappedEntity.hasEmbeddedIdentifier(), unsavedValue, generator);
    Preondition Violations
    Unmatched return new IdentifierProperty(property.getName(),property.getNodeName(),type,mappedEntity.hasEmbeddedIdentifier(),unsavedValue,generator);
    7
    return new IdentifierProperty(property.getName(), property.getNodeName(), type, mappedEntity.hasEmbeddedIdentifier(), unsavedValue, generator);
                                                                                                                                                                                                                                                                                
    6
    return new IdentifierProperty(type, mappedEntity.hasEmbeddedIdentifier(), mappedEntity.hasIdentifierMapper(), unsavedValue, generator);
    Preondition Violations
    Unmatched return new IdentifierProperty(type,mappedEntity.hasEmbeddedIdentifier(),mappedEntity.hasIdentifierMapper(),unsavedValue,generator);
    6
    return new IdentifierProperty(type, mappedEntity.hasEmbeddedIdentifier(), mappedEntity.hasIdentifierMapper(), unsavedValue, generator);
    Precondition Violations (5)
    Row Violation
    1Type java.lang.String of variable propertyName does not match with type org.hibernate.mapping.Property of variable property
    2Unmatched return ArrayHelper.slice(lhsPersister.toColumns(alias,property),begin,type.getColumnSpan(mapping));
    3Unmatched return ((PropertyMapping)lhsPersister).toColumns(alias,propertyName);
    4Unmatched return new IdentifierProperty(property.getName(),property.getNodeName(),type,mappedEntity.hasEmbeddedIdentifier(),unsavedValue,generator);
    5Unmatched return new IdentifierProperty(type,mappedEntity.hasEmbeddedIdentifier(),mappedEntity.hasIdentifierMapper(),unsavedValue,generator);