File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/event/def/DefaultSaveOrUpdateEventListener.java | File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/mapping/PersistentClass.java | |||
Method name: void onSaveOrUpdate(SaveOrUpdateEvent)
|
Method name: void checkColumnDuplication()
|
|||
Number of AST nodes: 4 | Number of AST nodes: 5 | |||
1 | final Object entity = source.getPersistenceContext().unproxyAndReassociate( object );↵ | |||
2 | event.setEntity( entity );↵ | |||
3 | event.setEntry( source.getPersistenceContext().getEntry( entity ) );↵ | |||
4 | //return the id in the event object↵ | |||
5 | event.setResultId( performSaveOrUpdate( event ) ); | 1 | while ( iter.hasNext() ) {↵ | |
2 | cols.clear();↵ | |||
3 | Join join = (Join) iter.next();↵ | |||
4 | checkColumnDuplication( cols, join.getKey().getColumnIterator() );↵ | |||
5 | checkPropertyColumnDuplication( cols, join.getPropertyIterator() );↵ | |||
6 |
| |||
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.0 |
Clones location | Clones are in different classes |
Number of node comparisons | 16 |
Number of mapped statements | 2 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 0.0 |
Clone type | Type 2 |
ID | Statement | ID | Statement | |||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 8 | cols.clear(); | ||||||||||||||||||||||
|
| 9 | Join join = (Join)iter.next(); | |||||||||||||||||||||
9 | final Object entity = source.getPersistenceContext().unproxyAndReassociate(object); | | ||||||||||||||||||||||
10 | event.setEntity(entity); |
| 10 | checkColumnDuplication(cols, join.getKey().getColumnIterator()); | ||||||||||||||||||||
11 | event.setEntry(source.getPersistenceContext().getEntry(entity)); |
| 11 | checkPropertyColumnDuplication(cols, join.getPropertyIterator()); | ||||||||||||||||||||
12 | event.setResultId(performSaveOrUpdate(event)); |
| |
Row | Violation |
---|---|
1 | Unmatched statement Join join=(Join)iter.next(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Expression event.setEntity(entity) is a void method call, and thus it cannot be parameterized |
3 | Expression checkColumnDuplication(cols,join.getKey().getColumnIterator()) is a void method call, and thus it cannot be parameterized |
4 | Expression event.setEntity(entity) is a void method call, and thus it cannot be parameterized |
5 | Expression checkColumnDuplication(cols,join.getKey().getColumnIterator()) is a void method call, and thus it cannot be parameterized |
6 | Expression event.setEntry(source.getPersistenceContext().getEntry(entity)) is a void method call, and thus it cannot be parameterized |
7 | Expression checkPropertyColumnDuplication(cols,join.getPropertyIterator()) is a void method call, and thus it cannot be parameterized |
8 | Expression event.setEntry(source.getPersistenceContext().getEntry(entity)) is a void method call, and thus it cannot be parameterized |
9 | Expression checkPropertyColumnDuplication(cols,join.getPropertyIterator()) is a void method call, and thus it cannot be parameterized |
10 | Unmatched statement event.setResultId(performSaveOrUpdate(event)); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |