File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/bytecode/util/BasicClassFilter.java | File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/persister/entity/JoinedSubclassEntityPersister.java | |||
Method name: boolean isInIncludedPackage(String)
|
Method name: int getTableId(String, String[])
|
|||
Number of AST nodes: 3 | Number of AST nodes: 3 | |||
1 | for ( int i = 0; i < includedPackages.length; i++ ) {↵ | 1 | for ( int j=0; j<tables.length; j++ ) {↵ | |
2 | ↵ | |||
3 | if ( className.startsWith( includedPackages[i] ) ) {↵ | 2 | if ( tableName.equals( tables[j] ) ) {↵ | |
4 | ↵ | |||
5 | return true;↵ | 3 | return ↵ | |
6 | ↵ | 4 | j;↵ | |
7 | }↵ | 5 | }↵ | |
8 | ↵ | |||
9 | } | 6 |
| |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.3 |
Clones location | Clones are in different classes |
Number of node comparisons | 5 |
Number of mapped statements | 2 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 0.7 |
Clone type | Type 2 |
ID | Statement | ID | Statement | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
2 | for (int i = 0; i < includedPackages.length; i++) |
| 1 | for (int j = 0; j < tables.length; j++) | |||||||||||||||||||||
3 | if (className.startsWith(includedPackages[i])) |
| 2 | if (tableName.equals(tables[j])) | |||||||||||||||||||||
|
| 3 | return j; | ||||||||||||||||||||||
4 | return true; |
| |
Row | Violation |
---|---|
1 | Expression className.startsWith(includedPackages[i]) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression tableName.equals(tables[j]) cannot be parameterized, because it has dependencies to/from statements that will be extracted |
3 | Unmatched statement return j; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
4 | Unmatched return j; |
5 | Unmatched return true; |
6 | Clone fragment #1 returns variables , while Clone fragment #2 returns variables j |