if ( !(other instanceof Broken) ) return false; Broken that = (Broken) other; return this.id.equals(that.id) && this.otherId.equals(that.otherId);
if ( !(that instanceof Address) ) return false; Address address = (Address) that; return address.getType().equals(type) && address.getPerson().getName().equals( person.getName() );
Clone fragments detected by clone detection tool
File path: /hibernate-distribution-3.3.2.GA/project/testsuite/src/test/java/org/hibernate/test/legacy/Broken.java File path: /hibernate-distribution-3.3.2.GA/project/testsuite/src/test/java/org/hibernate/test/onetoone/formula/Address.java
Method name: boolean equals(Object) Method name: boolean equals(Object)
Number of AST nodes: 4 Number of AST nodes: 4
1
if ( !(other instanceof Broken) ) return false;
1
if ( !(that instanceof Address) ) return false;
2
		Broken that = (Broken) other;
2
		Address address = (Address) that;
3
		return this.id.equals(that.id) && this.otherId.equals(that.otherId
3
		return address.getType().equals(type) && 
4
);
4
			address.getPerson().getName().equals( person.getName() );
Summary
Number of common nesting structure subtrees1
Number of refactorable cases0
Number of non-refactorable cases1
Time elapsed for finding largest common nesting structure subtrees (ms)0.1
Clones locationClones are in different classes
Number of node comparisons8
  1. {Non-refactorable}
    Mapping Summary
    Number of mapped statements2
    Number of unmapped statements in the first code fragment2
    Number of unmapped statements in the second code fragment2
    Time elapsed for statement mapping (ms)0.6
    Clone typeType 2
    Mapped Statements
    ID Statement ID Statement
    1
    if (!(other instanceof Broken))
    1
    if (!(other instanceof Broken))
    1
    if (!(that instanceof Address))
    Differences
    Expression1Expression2Difference
    otherthatVARIABLE_NAME_MISMATCH
    org.hibernate.test.legacy.Brokenorg.hibernate.test.onetoone.formula.AddressVARIABLE_TYPE_MISMATCH
    Preondition Violations
    Type boolean of variable other instanceof Broken does not match with type boolean of variable that instanceof Address
    • Make classes org.hibernate.test.legacy.Broken and org.hibernate.test.onetoone.formula.Address extend a common superclass
    1
    if (!(that instanceof Address))
    2
    return false;
    2
    return false;
                                                                      
    3
    Address address = (Address)that;
    3
    Broken that = (Broken)other;
                                                              
                                                                                                                                                                                                          
    4
    return address.getType().equals(type) && address.getPerson().getName().equals(person.getName());
    Preondition Violations
    Unmatched return address.getType().equals(type) && address.getPerson().getName().equals(person.getName());
    4
    return address.getType().equals(type) && address.getPerson().getName().equals(person.getName());
    4
    return this.id.equals(that.id) && this.otherId.equals(that.otherId);
    4
    return this.id.equals(that.id) && this.otherId.equals(that.otherId);
    Preondition Violations
    Unmatched return this.id.equals(that.id) && this.otherId.equals(that.otherId);
                                                                                                                                                  
    Precondition Violations (3)
    Row Violation
    1Type boolean of variable other instanceof Broken does not match with type boolean of variable that instanceof Address
    2Unmatched return address.getType().equals(type) && address.getPerson().getName().equals(person.getName());
    3Unmatched return this.id.equals(that.id) && this.otherId.equals(that.otherId);