File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/hql/ast/tree/FromElement.java | File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/loader/BasicLoader.java | |||
Method name: void addEmbeddedParameter(ParameterSpecification)
|
Method name: void postInstantiate()
|
|||
Number of AST nodes: 3 | Number of AST nodes: 4 | |||
1 | if ( embeddedParameters == null ) {↵ | 1 | if ( ↵ | |
2 | embeddedParameter↵ | 2 | isBag( collectionPersisters[i] ) ) {↵ | |
3 | if ( bagRoles == null ) {↵ | |||
3 | s = new ArrayList();↵ | 4 | bagRoles = new ArrayList();↵ | |
4 | }↵ | 5 | }↵ | |
5 | embeddedParameters.add( specification ); | 6 | bagRoles.add( collectionPersisters[i].getRole() );↵ | |
7 |
| |||
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.1 |
Clones location | Clones are in different classes |
Number of node comparisons | 5 |
Number of mapped statements | 2 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 0.5 |
Clone type | Type 2 |
ID | Statement | ID | Statement | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | if (embeddedParameters == null) |
| 13 | if (bagRoles == null) | |||||||||||
2 | embeddedParameters = new ArrayList(); |
| 14 | bagRoles = new ArrayList(); | |||||||||||
3 | embeddedParameters.add(specification); | | |||||||||||||
|
| 15 | bagRoles.add(collectionPersisters[i].getRole()); |
Row | Violation |
---|---|
1 | Expression bagRoles cannot be parameterized, because it has dependencies to/from statements that will be extracted |
2 | Expression embeddedParameters is a field being modified, and thus it cannot be parameterized |
3 | Unmatched statement bagRoles.add(collectionPersisters[i].getRole()); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
4 | Clone fragment #1 returns variables , while Clone fragment #2 returns variables bagRoles |