if ( callback && transactionContext.shouldAutoClose() && !transactionContext.isClosed() ) {
try {
transactionContext.managedClose();
}
catch (HibernateException he) {
log.error("Could not close session", he);
//swallow, the transaction was finished
}
}
try {
cacheRegion.destroy();
}
catch ( Exception e ) {
log.warn( "could not destroy query cache: " + cacheRegion.getName(), e );
}
Clone fragments detected by clone detection tool
File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/transaction/JDBCTransaction.java
|
|
File path: /hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/cache/StandardQueryCache.java
|
Method name: void closeIfRequired()
|
|
Method name: void destroy()
|
Number of AST nodes: 3
|
|
Number of AST nodes: 2
|
|
1 | if ( callback && transactionContext.shouldAutoClose() && !transactionContext.isClosed() ) {↵ | | |
|
2 | try {↵ | | |
|
3 | transactionContext.managedClose↵ | | 1 | try {↵
|
4 | ();↵ | | 2 | cacheRegion.destroy();↵
|
5 | }↵ | | 3 | }↵
|
6 | catch (HibernateException he) {↵ | | 4 | catch ( Exception e ) {↵
|
7 | log.error("Could not close session", he);↵ | | 5 | log.warn( "could not ↵
|
8 | //swallow, the transaction was finished↵ | | |
|
9 | }↵ | | 6 | destroy query cache: " + cacheRegion.getName(), e );↵
|
10 | } | | 7 | }
|
See real code fragment |
|
See real code fragment |
Summary
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2 |
Clones location | Clones are in different classes |
Number of node comparisons | 4 |
-
{Non-refactorable}
Mapping Summary
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 71.3 |
Clone type | Type 2 |
Mapped Statements
ID |
Statement |
|
ID |
Statement |
2 | try | | 1 | try |
| | | 2 | |
3 | transactionContext.managedClose(); | | | |
Precondition Violations (3)
Row |
Violation |
1 | Expression log.error("Could not close session",he) is a void method call, and thus it cannot be parameterized |
2 | Expression log.warn("could not destroy query cache: " + cacheRegion.getName(),e) is a void method call, and thus it cannot be parameterized |
3 | Unmatched statement cacheRegion.destroy(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |