File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java | File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/jms/client/ConnectionFactory.java | |||
Method name: NVPair parseOneParameter(String)
|
Method name: QueueConnection getQueueConnection(Context, String)
|
|||
Number of AST nodes: 3 | Number of AST nodes: 3 | |||
1 | if (decode) {↵ | 1 | if (↵ | |
2 | try {↵ | |||
3 | value = URLDecoder.decode(value,"UTF-8");↵ | |||
4 | } catch (UnsupportedEncodingException e) {↵ | |||
5 | log.warn(e.getMessage());↵ | |||
6 | }↵ | |||
7 | ↵ | 2 | factory != null) {↵ | |
3 | try {↵ | |||
4 | return qfactory.createQueueConnection();↵ | |||
5 | } catch (JMSException e) {↵ | |||
6 | log.error(e.getMessage());↵ | |||
7 | }↵ | |||
8 | } | 8 | } | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2 |
Clones location | Clones are in different classes |
Number of node comparisons | 5 |
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 0.6 |
Clone type | Type 2 |
ID | Statement | ID | Statement | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
10 | try |
| 2 | try | |||||||||||||||||||||
|
| 3 | return qfactory.createQueueConnection(); | ||||||||||||||||||||||
11 | value = URLDecoder.decode(value, "UTF-8"); |
| |
Row | Violation |
---|---|
1 | Expression log.warn(e.getMessage()) is a void method call, and thus it cannot be parameterized |
2 | Expression log.error(e.getMessage()) is a void method call, and thus it cannot be parameterized |
3 | Unmatched statement return qfactory.createQueueConnection(); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |
4 | Unmatched return qfactory.createQueueConnection(); |
5 | Unmatched statement value=URLDecoder.decode(value,"UTF-8"); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |