if (line == null) {
breader.close();
breader = null;
this.READER = null;
// this.READER = new BufferedReader(new
// FileReader(this.SOURCE));
// parse(this.READER,el);
}
LDAPArguments args = new LDAPArguments();
modifyTestElement(args);
// TODO: Why do we clone the return value? This is the only reference
// to it (right?) so we shouldn't need a separate copy.
return (TestElement) args.clone();
Clone fragments detected by clone detection tool
File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java
|
|
File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/ldap/config/gui/LDAPArgumentsPanel.java
|
Method name: int parse(BufferedReader, TestElement, int)
|
|
Method name: TestElement createTestElement()
|
Number of AST nodes: 4
|
|
Number of AST nodes: 3
|
|
1 | if (line == null) {↵ | | 1 | LDAPArguments args = n↵
|
2 | breader.close();↵ | | |
|
3 | breader = null;↵ | | |
|
4 | this.READER = null;↵ | | |
|
5 | // this.READER = new BufferedReader(new↵ | | 2 | ew LDAPArguments();↵
|
| | | 3 | modifyTestElement(args);↵
|
| | | 4 | // TODO: Why do we clone the return value? This is the only reference↵
|
6 | // FileReader(this.SOURCE));↵ | | 5 | // ↵
|
7 | // parse(this.READER,el);↵ | | |
|
8 | } | | 6 | to it (right?) so we shouldn't need a separate copy.↵
|
| | | 7 | return (TestElement) args.clone();
|
See real code fragment |
|
See real code fragment |
Summary
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.0 |
Clones location | Clones are in different classes |
Number of node comparisons | 9 |
-
{Non-refactorable}
Mapping Summary
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 0.0 |
Clone type | Type 2 |
Mapped Statements
ID |
Statement |
|
ID |
Statement |
| | | 1 | LDAPArguments args = new LDAPArguments(); |
12 | breader.close(); | | 2 | modifyTestElement(args); |
| | | 3 | return (TestElement)args.clone(); |
13 | breader = null; | | | |
14 | this.READER = null; | | | |
Precondition Violations (7)
Row |
Violation |
1 | Expression breader.close() is a void method call, and thus it cannot be parameterized |
2 | Expression modifyTestElement(args) is a void method call, and thus it cannot be parameterized |
3 | Expression breader.close() is a void method call, and thus it cannot be parameterized |
4 | Expression modifyTestElement(args) is a void method call, and thus it cannot be parameterized |
5 | Unmatched statement return (TestElement)args.clone(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
6 | Unmatched return (TestElement)args.clone(); |
7 | Unmatched statement breader=null; cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |