File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/gui/tree/JMeterTreeModel.java | File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/ldap/config/gui/LDAPArgumentsPanel.java | |||
Method name: List getNodesOfType(Class)
|
Method name: TestElement createTestElement()
|
|||
Number of AST nodes: 3 | Number of AST nodes: 3 | |||
1 | List nodeList = new LinkedList();↵ | 1 | L↵ | |
2 | traverseAndFind(type, (JMeterTreeNode) this.getRoot(), nodeList);↵ | |||
3 | return nodeList↵ | 2 | DAPArguments args = new LDAPArguments();↵ | |
3 | modifyTestElement(args);↵ | |||
4 | // TODO: Why do we clone the return value? This is the only reference↵ | |||
5 | // to it (right?) so we shouldn't need a separate copy.↵ | |||
4 | ; | 6 | return (TestElement) args.clone(); | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.0 |
Clones location | Clones are in different classes |
Number of node comparisons | 8 |
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 2 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 0.0 |
Clone type | Type 2 |
ID | Statement | ID | Statement | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1 | LDAPArguments args = new LDAPArguments(); | |||||||||||||||||||
1 | List nodeList = new LinkedList(); | | |||||||||||||||||||
2 | traverseAndFind(type, (JMeterTreeNode)this.getRoot(), nodeList); |
| 2 | modifyTestElement(args); | |||||||||||||||||
|
| 3 | return (TestElement)args.clone(); | ||||||||||||||||||
3 | return nodeList; |
| |
Row | Violation |
---|---|
1 | Expression traverseAndFind(type,(JMeterTreeNode)this.getRoot(),nodeList) is a void method call, and thus it cannot be parameterized |
2 | Expression modifyTestElement(args) is a void method call, and thus it cannot be parameterized |
3 | Expression traverseAndFind(type,(JMeterTreeNode)this.getRoot(),nodeList) is a void method call, and thus it cannot be parameterized |
4 | Expression modifyTestElement(args) is a void method call, and thus it cannot be parameterized |
5 | Unmatched statement return (TestElement)args.clone(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
6 | Unmatched return (TestElement)args.clone(); |
7 | Unmatched return nodeList; |