while (iter.hasNext()) {
try {
set.add(iter.next());
} catch (Exception err) {
log.error("", err);
}
}
if (decode) {
try {
value = URLDecoder.decode(value,"UTF-8");
} catch (UnsupportedEncodingException e) {
log.warn(e.getMessage());
}
}
Clone fragments detected by clone detection tool
File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/gui/action/ActionRouter.java
|
|
File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java
|
Method name: Set getAction(String)
|
|
Method name: NVPair parseOneParameter(String)
|
Number of AST nodes: 3
|
|
Number of AST nodes: 3
|
|
1 | while (iter.hasNext()) {↵ | | |
|
2 | try {↵ | | |
|
3 | set.add(iter.next());↵ | | |
|
4 | } catch (↵ | | 1 | if (decode) {↵
|
| | | 2 | try {↵
|
| | | 3 | value = URLDecoder.decode(value,"UTF-8");↵
|
5 | Exception err) {↵ | | 4 | } catch (UnsupportedEncodingException e) {↵
|
6 | log.error("", err);↵ | | |
|
7 | }↵ | | |
|
8 | ↵ | | 5 | log.warn(e.getMessage());↵
|
| | | 6 | }↵
|
9 | } | | 7 | }
|
See real code fragment |
|
See real code fragment |
Summary
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2 |
Clones location | Clones are in different classes |
Number of node comparisons | 5 |
-
{Non-refactorable}
Mapping Summary
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 1 |
Number of unmapped statements in the second code fragment | 1 |
Time elapsed for statement mapping (ms) | 0.9 |
Clone type | Type 2 |
Mapped Statements
ID |
Statement |
|
ID |
Statement |
5 | try | | 10 | try |
6 | | | | |
| | | 11 | value = URLDecoder.decode(value, "UTF-8"); |
Precondition Violations (5)
Row |
Violation |
1 | Expression log.error("",err) is a void method call, and thus it cannot be parameterized |
2 | Expression log.warn(e.getMessage()) is a void method call, and thus it cannot be parameterized |
3 | Expression log.error("",err) is a void method call, and thus it cannot be parameterized |
4 | Expression log.warn(e.getMessage()) is a void method call, and thus it cannot be parameterized |
5 | Unmatched statement value=URLDecoder.decode(value,"UTF-8"); cannot be moved before or after the extracted code, because it throws exception(s) that should be caught by a try block that will be extracted |