File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/control/gui/ModuleControllerGui.java | File path: /jakarta-jmeter-2.3.2/src/org/apache/jmeter/protocol/ldap/config/gui/LDAPArgumentsPanel.java | |||
Method name: void buildNodesModel(JMeterTreeNode, String, int)
|
Method name: TestElement createTestElement()
|
|||
Number of AST nodes: 4 | Number of AST nodes: 3 | |||
1 | name.append(parent_name);↵ | |||
2 | name.append(cur.getName());↵ | |||
3 | name.append(seperator);↵ | 1 | LDAPArguments args = new LDAPArguments();↵ | |
2 | modifyTestElement(args);↵ | |||
3 | // TODO: Why do we clone the return value? This is the only reference↵ | |||
4 | buildNodesModel(cur, name.toString(), level↵ | 4 | // to it (right?) so we shouldn't need a separate copy.↵ | |
5 | ); | 5 | return (TestElement) args.clone(); | |
See real code fragment | See real code fragment |
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.0 |
Clones location | Clones are in different classes having the same super class |
Number of node comparisons | 12 |
Number of mapped statements | 1 |
Number of unmapped statements in the first code fragment | 3 |
Number of unmapped statements in the second code fragment | 2 |
Time elapsed for statement mapping (ms) | 0.0 |
Clone type | Type 3 |
ID | Statement | ID | Statement | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1 | LDAPArguments args = new LDAPArguments(); | |||||||||||||||||||
|
| 3 | return (TestElement)args.clone(); | ||||||||||||||||||
10 | name.append(parent_name); |
| | ||||||||||||||||||
11 | name.append(cur.getName()); | | |||||||||||||||||||
12 | name.append(seperator); | | |||||||||||||||||||
13 | buildNodesModel(cur, name.toString(), level); |
| 2 | modifyTestElement(args); |
Row | Violation |
---|---|
1 | Unmatched statement return (TestElement)args.clone(); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Unmatched return (TestElement)args.clone(); |
3 | Unmatched statement name.append(parent_name); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
4 | Expression buildNodesModel(cur,name.toString(),level) is a void method call, and thus it cannot be parameterized |
5 | Expression modifyTestElement(args) is a void method call, and thus it cannot be parameterized |
6 | Expression buildNodesModel(cur,name.toString(),level) is a void method call, and thus it cannot be parameterized |
7 | Expression modifyTestElement(args) is a void method call, and thus it cannot be parameterized |