if (entities != null) {
String tip = null;
PieToolTipGenerator tipster = getToolTipGenerator();
if (tipster != null) {
// @mgs: using the method's return value was missing
tip = tipster.generateToolTip(dataset, currentKey);
}
String url = null;
if (getURLGenerator() != null) {
url = getURLGenerator().generateURL(dataset, currentKey,
getPieIndex());
}
PieSectionEntity entity = new PieSectionEntity(
upperArc, dataset, getPieIndex(), sectionIndex,
currentKey, tip, url);
entities.add(entity);
}
String tip = null;
XYToolTipGenerator generator
= getToolTipGenerator(series, item);
if (generator != null) {
tip = generator.generateToolTip(dataset, series, item);
}
String url = null;
if (getURLGenerator() != null) {
url = getURLGenerator().generateURL(dataset, series,
item);
}
XYItemEntity entity = new XYItemEntity(shape, dataset,
series, item, tip, url);
entities.add(entity);
Clone fragments detected by clone detection tool
File path: /jfreechart-1.0.10/src/org/jfree/chart/plot/PiePlot3D.java
|
|
File path: /jfreechart-1.0.10/src/org/jfree/chart/renderer/xy/StackedXYAreaRenderer.java
|
Method name: void draw(Graphics2D, Rectangle2D, Point2D, PlotState, PlotRenderingInfo)
|
|
Method name: void drawItem(Graphics2D, XYItemRendererState, Rectangle2D, PlotRenderingInfo, XYPlot, ValueAxis, ValueAxis, XYDataset, int, int, CrosshairState, int)
|
Number of AST nodes: 10
|
|
Number of AST nodes: 9
|
|
1 | if (entities != null) {↵ | | |
|
2 | String tip = null;↵ | | 1 | String tip = null;↵
|
3 | PieToolTipGenerator tipster = getToolTipGenerator();↵ | | 2 | XYToolTipGenerator generator↵
|
4 | if (tipster != null) {↵ | | 3 | ↵
|
5 | // @mgs: using the method's return value was missing ↵ | | 4 | = getToolTipGenerator(series, item);↵
|
| | | 5 | if (generator != null) {↵
|
6 | tip = tipster.generateToolTip(dataset, currentKey);↵ | | 6 | tip = generator.generateToolTip(dataset, series, item);↵
|
7 | }↵ | | 7 | }↵
|
8 | String url = null;↵ | | 8 | String url = null;↵
|
9 | if (getURLGenerator() != null) {↵ | | 9 | if (getURLGenerator() != null) {↵
|
10 | url = getURLGenerator().generateURL(dataset, currentKey,↵ | | 10 | url = getURLGenerator().generateURL(dataset, series,↵
|
11 | getPieIndex());↵ | | 11 | item);↵
|
12 | }↵ | | 12 | }↵
|
13 | PieSectionEntity entity = new PieSectionEntity(↵ | | 13 | XYItemEntity entity = new ↵
|
14 | upperArc, dataset, getPieIndex(), sectionIndex, ↵ | | 14 | XYItemEntity(shape, dataset,↵
|
15 | currentKey, tip, url);↵ | | 15 | series, item, tip, url);↵
|
16 | entities.add(entity);↵ | | 16 | entities.add(entity);
|
17 | } | | | |
See real code fragment |
|
See real code fragment |
Summary
Number of common nesting structure subtrees | 1 |
Number of refactorable cases | 0 |
Number of non-refactorable cases | 1 |
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.4 |
Clones location | Clones are in different classes |
Number of node comparisons | 17 |
-
{Non-refactorable}
Mapping Summary
Number of mapped statements | 4 |
Number of unmapped statements in the first code fragment | 3 |
Number of unmapped statements in the second code fragment | 3 |
Time elapsed for statement mapping (ms) | 31.5 |
Clone type | Type 3 |
Mapped Statements
ID |
Statement |
|
ID |
Statement |
199 | String tip = null; | | 88 | String tip = null; |
| | | 89 | XYToolTipGenerator generator = getToolTipGenerator(series, item); |
| | | 90 | if (generator != null) |
| | | 91 | tip = generator.generateToolTip(dataset, series, item); |
200 | PieToolTipGenerator tipster = getToolTipGenerator(); | | | |
201 | if (tipster != null) | | | |
202 | tip = tipster.generateToolTip(dataset, currentKey); | | | |
203 | String url = null; | | 92 | String url = null; |
204 | if (getURLGenerator() != null) | | 93 | if (getURLGenerator() != null) |
205 | url = getURLGenerator().generateURL(dataset, currentKey, getPieIndex()); | | 94 | url = getURLGenerator().generateURL(dataset, series, item); |
Precondition Violations (5)
Row |
Violation |
1 | Unmatched statement tip=tipster.generateToolTip(dataset,currentKey); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted |
2 | Type org.jfree.chart.urls.PieURLGenerator of variable getURLGenerator() does not match with type org.jfree.chart.urls.XYURLGenerator of variable getURLGenerator() |
3 | Type org.jfree.data.general.PieDataset of variable dataset does not match with type org.jfree.data.xy.XYDataset of variable dataset |
4 | Type org.jfree.chart.urls.PieURLGenerator of variable getURLGenerator() does not match with type org.jfree.chart.urls.XYURLGenerator of variable getURLGenerator() |
5 | Clone fragment #1 returns variables tip, url , while Clone fragment #2 returns variables tip, url |