1688-1-2

while (iterator.hasNext()) { Comparable key = (Comparable) iterator.next(); Paint p1 = getPaint(key); Paint p2 = that.getPaint(key); if (!PaintUtilities.equal(p1, p2)) { return false; } }
while (iterator.hasNext()) { Comparable key = (Comparable) iterator.next(); Stroke s1 = getStroke(key); Stroke s2 = that.getStroke(key); if (!ObjectUtilities.equal(s1, s2)) { return false; } }

Clone fragments detected by clone detection tool
File path: /jfreechart-1.0.10/src/org/jfree/chart/PaintMap.java |  | File path: /jfreechart-1.0.10/src/org/jfree/chart/StrokeMap.java
Method name: `boolean equals(Object)` |  | Method name: `boolean equals(Object)`
Number of AST nodes: 6 |  | Number of AST nodes: 6

1

    while (iterator.hasNext()) {↵

1

    while (iterator.hasNext()) {↵

2

                Comparable key = (Comparable) iterator.next();↵

2

                Comparable key = (Comparable) iterator.next();↵

3

                Paint p1 = getPaint(key);↵

3

                Stroke s1 = getStroke(key);↵

4

                Paint p2 = that.getPaint(key);↵

4

                Stroke s2 = that.getStroke(key);↵

5

                if (!PaintUtilities.equal(p1, p2)) {↵

5

                if (!ObjectUtilities.equal(s1, s2)) {↵

6

                    return false;↵

6

                    return false;↵

7

                }↵

7

                }↵

8

            }

8

            }

See real code fragment |  | See real code fragment

Summary
Number of common nesting structure subtrees | 1
Number of refactorable cases | 0
Number of non-refactorable cases | 1
Time elapsed for finding largest common nesting structure subtrees (ms) | 0.2
Clones location | Clones are in different classes
Number of node comparisons | 20

1. {Non-refactorable}

   Mapping Summary
   Number of mapped statements | 4
   Number of unmapped statements in the first code fragment | 2
   Number of unmapped statements in the second code fragment | 2
   Time elapsed for statement mapping (ms) | 6.7
   Clone type | Type 2

   Mapped Statements
   ID | Statement |  | ID | Statement
   --- | --- | --- | --- | ---

   10

       while (iterator.hasNext())

   10

       while (iterator.hasNext())

   11

       Comparable key = (Comparable)iterator.next();

   11

       Comparable key = (Comparable)iterator.next();

   12 | Stroke s1 = getStroke(key);

   Preondition Violations
   Unmatched statement Stroke s1=getStroke(key); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted

   12

       Stroke s1 = getStroke(key);

   12

       Paint p1 = getPaint(key);

   12 | Paint p1 = getPaint(key);

   Preondition Violations
   Unmatched statement Paint p1=getPaint(key); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted

   13 | Stroke s2 = that.getStroke(key);

   Preondition Violations
   Unmatched statement Stroke s2=that.getStroke(key); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted

   13

       Stroke s2 = that.getStroke(key);

   13

       Paint p2 = that.getPaint(key);

   13 | Paint p2 = that.getPaint(key);

   Preondition Violations
   Unmatched statement Paint p2=that.getPaint(key); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted

   14

       if (!PaintUtilities.equal(p1, p2))

   14 | if (! PaintUtilities.equal(p1, p2))
   14 | if (! ObjectUtilities.equal(s1, s2))

   Differences
   Expression1 | Expression2 | Difference
   --- | --- | ---
   p1 | s1 | VARIABLE_NAME_MISMATCH
   java.awt.Paint | java.awt.Stroke | VARIABLE_TYPE_MISMATCH
   org.jfree.util.PaintUtilities | org.jfree.util.ObjectUtilities | VARIABLE_TYPE_MISMATCH

   Preondition Violations

   Type java.awt.Paint of variable p1 does not match with type java.awt.Stroke of variable s1
   - Make classes java.awt.Paint and java.awt.Stroke extend a common superclass

   Type org.jfree.util.PaintUtilities of variable PaintUtilities does not match with type org.jfree.util.ObjectUtilities of variable ObjectUtilities
   - Make classes org.jfree.util.PaintUtilities and org.jfree.util.ObjectUtilities extend a common superclass

   14

       if (!ObjectUtilities.equal(s1, s2))

   15

       return false;

   15 | return false;
   15 | return false;

   Preondition Violations
   Conditional return false;
   Conditional return false;

   15

       return false;

   Precondition Violations (8)
   Row | Violation
   --- | ---
   1 | Unmatched statement Stroke s1=getStroke(key); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
   2 | Unmatched statement Paint p1=getPaint(key); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
   3 | Unmatched statement Stroke s2=that.getStroke(key); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
   4 | Unmatched statement Paint p2=that.getPaint(key); cannot be moved before or after the extracted code, because it has dependencies to/from statements that will be extracted
   5 | Type java.awt.Paint of variable p1 does not match with type java.awt.Stroke of variable s1
   6 | Type org.jfree.util.PaintUtilities of variable PaintUtilities does not match with type org.jfree.util.ObjectUtilities of variable ObjectUtilities
   7 | Conditional return false;
   8 | Conditional return false;